)]}'
{"pbr/packaging.py":[{"author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"change_message_id":"12ccc0bec4b239fbc851cd22b9ce5439c94c8fb1","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                [\u0027describe\u0027, \u0027--always\u0027], git_dir).replace(\u0027-\u0027, \u0027.\u0027)"},{"line_number":768,"context_line":"    # If we don\u0027t know the version, return an empty string so at least"},{"line_number":769,"context_line":"    # the downstream users of the value don\u0027t get a TypeError."},{"line_number":770,"context_line":"    return \u0027\u0027"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def _get_version_from_pkg_info(package_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fz5o%3D","line":770,"updated":"2013-10-09 14:29:04.000000000","message":"Based on the changes here, it seems like they\u0027d actually get an AttributeError?","commit_id":"9df6be79d74b7fdbc0fd6eeb6bb13c05f0263b0e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c77ca0ae14850802607c1588cef27643d25812f0","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                [\u0027describe\u0027, \u0027--always\u0027], git_dir).replace(\u0027-\u0027, \u0027.\u0027)"},{"line_number":768,"context_line":"    # If we don\u0027t know the version, return an empty string so at least"},{"line_number":769,"context_line":"    # the downstream users of the value don\u0027t get a TypeError."},{"line_number":770,"context_line":"    return \u0027\u0027"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def _get_version_from_pkg_info(package_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fzz0%3D","line":770,"in_reply_to":"AAAATH%2F%2Fz1Q%3D","updated":"2013-10-09 14:40:01.000000000","message":"Sorry, I think you\u0027re right, the exception mentioned in the comment is wrong. I was thinking \"so the downstream user doesn\u0027t do something with the wrong type\" and turned that into \"get a TypeError\".","commit_id":"9df6be79d74b7fdbc0fd6eeb6bb13c05f0263b0e"},{"author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"change_message_id":"998bc2513e21407b9e7448086fad370d619b410d","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                [\u0027describe\u0027, \u0027--always\u0027], git_dir).replace(\u0027-\u0027, \u0027.\u0027)"},{"line_number":768,"context_line":"    # If we don\u0027t know the version, return an empty string so at least"},{"line_number":769,"context_line":"    # the downstream users of the value don\u0027t get a TypeError."},{"line_number":770,"context_line":"    return \u0027\u0027"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def _get_version_from_pkg_info(package_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fz1Q%3D","line":770,"in_reply_to":"AAAATH%2F%2Fz3o%3D","updated":"2013-10-09 14:36:17.000000000","message":"I\u0027m not sure I understand how that could be proved by this change; is this just fixing a second, unrelated issue?","commit_id":"9df6be79d74b7fdbc0fd6eeb6bb13c05f0263b0e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ee70d9f8b68511a79768e654a665537bb87dcec4","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                [\u0027describe\u0027, \u0027--always\u0027], git_dir).replace(\u0027-\u0027, \u0027.\u0027)"},{"line_number":768,"context_line":"    # If we don\u0027t know the version, return an empty string so at least"},{"line_number":769,"context_line":"    # the downstream users of the value don\u0027t get a TypeError."},{"line_number":770,"context_line":"    return \u0027\u0027"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def _get_version_from_pkg_info(package_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fz3o%3D","line":770,"in_reply_to":"AAAATH%2F%2Fz5o%3D","updated":"2013-10-09 14:34:02.000000000","message":"I think I was seeing a type error from trying to combine None with a string. It\u0027s likely that attribute errors could have come up in other cases, too, though. It\u0027s also likely I mis-remembered by the time I wrote this comment.","commit_id":"9df6be79d74b7fdbc0fd6eeb6bb13c05f0263b0e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a58e3c8ff8ab05f55ef0a3a94c31422426115070","unresolved":false,"context_lines":[{"line_number":224,"context_line":"def _get_git_directory():"},{"line_number":225,"context_line":"    d \u003d _run_shell_command([\u0027git\u0027, \u0027rev-parse\u0027, \u0027--git-dir\u0027])"},{"line_number":226,"context_line":"    # Handle http://bugs.python.org/issue11638"},{"line_number":227,"context_line":"    if sys.version_info[0] \u003d\u003d 2:"},{"line_number":228,"context_line":"        d \u003d d.encode(\u0027utf-8\u0027)"},{"line_number":229,"context_line":"    return d"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FyTE%3D","line":227,"updated":"2013-10-09 20:24:48.000000000","message":"Move this to where the value is being used instead of here.","commit_id":"e541c40c981dd2aa7baebff2249104c4c9853d39"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a58e3c8ff8ab05f55ef0a3a94c31422426115070","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                [\u0027describe\u0027, \u0027--always\u0027], git_dir).replace(\u0027-\u0027, \u0027.\u0027)"},{"line_number":768,"context_line":"    # If we don\u0027t know the version, return an empty string so at least"},{"line_number":769,"context_line":"    # the downstream users of the value always have the same type of"},{"line_number":770,"context_line":"    # object to work with."},{"line_number":771,"context_line":"    return u\u0027\u0027"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FyS8%3D","line":770,"updated":"2013-10-09 20:24:48.000000000","message":"Update this to use six instead of a unicode literal.","commit_id":"e541c40c981dd2aa7baebff2249104c4c9853d39"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6d531149f31317310248bdf9b0947246a7bd6929","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"def _get_git_directory():"},{"line_number":225,"context_line":"    d \u003d _run_shell_command([\u0027git\u0027, \u0027rev-parse\u0027, \u0027--git-dir\u0027])"},{"line_number":226,"context_line":"    return d"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def get_boolean_option(option_dict, option_name, env_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FyDQ%3D","line":226,"updated":"2013-10-09 21:32:14.000000000","message":"After gutting the previous conditional reencoding you had in here, the remaining change to this function seems superfluous.","commit_id":"3c872e9a7076acaddf9196dd77f256a0ba0e9305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d48e5430c8321e192ea85bb3a00f1a712f152e12","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"def _get_git_directory():"},{"line_number":225,"context_line":"    d \u003d _run_shell_command([\u0027git\u0027, \u0027rev-parse\u0027, \u0027--git-dir\u0027])"},{"line_number":226,"context_line":"    return d"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def get_boolean_option(option_dict, option_name, env_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FyAk%3D","line":226,"in_reply_to":"AAAATH%2F%2FyDQ%3D","updated":"2013-10-09 21:49:45.000000000","message":"Done","commit_id":"3c872e9a7076acaddf9196dd77f256a0ba0e9305"}]}