)]}'
{"pbr/__init__.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4404f08543496eb182af8630e01e39fac18812e4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if \u0027PYTHONWARNINGS\u0027 not in os.environ:"},{"line_number":20,"context_line":"    warnings.filterwarnings("},{"line_number":21,"context_line":"        \u0027default\u0027, category\u003dDeprecationWarning, module\u003d\u0027pbr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_c4a7b0a7","line":21,"updated":"2017-12-12 21:20:56.000000000","message":"What is this section doing?","commit_id":"ea7a50fdadcd07612ad9a90723a05f93e4d27fee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ec2e4480ce806ec9c069e05b06ee001a4634969","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if \u0027PYTHONWARNINGS\u0027 not in os.environ:"},{"line_number":20,"context_line":"    warnings.filterwarnings("},{"line_number":21,"context_line":"        \u0027default\u0027, category\u003dDeprecationWarning, module\u003d\u0027pbr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_98ed7b8d","line":21,"in_reply_to":"df87a7cf_c4a7b0a7","updated":"2017-12-13 11:14:23.000000000","message":"Oops. I think I was trying to ensure DeprecationWarnings were always shown by default, but it seems this isn\u0027t necessary","commit_id":"ea7a50fdadcd07612ad9a90723a05f93e4d27fee"}],"pbr/packaging.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"585e914cb9cc0b6473cf40ecd31d0c8cda1c4ccc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"def _any_existing(file_list):"},{"line_number":77,"context_line":"    existing \u003d [f for f in file_list if os.path.exists(f)]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    deprecated \u003d [f for f in existing if f in PY_REQUIREMENTS_FILES]"},{"line_number":80,"context_line":"    if deprecated:"},{"line_number":81,"context_line":"        warnings.warn(\u0027Support for \\\u0027-pyN\\\u0027-suffixed requirements files is \u0027"},{"line_number":82,"context_line":"                      \u0027deprecated in pbr 4.0 and will be removed in 5.0. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_2d44aa1a","line":79,"updated":"2018-01-08 15:05:16.000000000","message":"This function appears to only be used for requirements files, but it isn\u0027t actually tied to that list and could be used with any list of files. Adding the warning specifically for requirements files feels like mixing two separate concerns. I wonder if it would be better to add an optional argument to provide the deprecated items to warn about? Or just do the warning outside of the function where the list of requirements files is built and used on line 92.","commit_id":"c05c76550e96162325c9a922ea33c1042f42f2b7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a5039c4f350e44e2f3ce30f8e40c550215e2832","unresolved":false,"context_lines":[{"line_number":76,"context_line":"def _any_existing(file_list):"},{"line_number":77,"context_line":"    existing \u003d [f for f in file_list if os.path.exists(f)]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    deprecated \u003d [f for f in existing if f in PY_REQUIREMENTS_FILES]"},{"line_number":80,"context_line":"    if deprecated:"},{"line_number":81,"context_line":"        warnings.warn(\u0027Support for \\\u0027-pyN\\\u0027-suffixed requirements files is \u0027"},{"line_number":82,"context_line":"                      \u0027deprecated in pbr 4.0 and will be removed in 5.0. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_06e1692a","line":79,"in_reply_to":"9f91af0f_2d44aa1a","updated":"2018-01-09 14:36:17.000000000","message":"Fair point. I was also missing tests. Addressed both point in the next patchset.","commit_id":"c05c76550e96162325c9a922ea33c1042f42f2b7"}]}