)]}'
{"pbr/packaging.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b926843882ac5723f361ec0021bc5725055e5410","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        elif (project_name and"},{"line_number":176,"context_line":"                project_name in BROKEN_ON_27 and sys.version_info \u003e\u003d (2, 7)):"},{"line_number":177,"context_line":"            log.info("},{"line_number":178,"context_line":"                \u0027[pbr] Excluding %s, not needed on Python\u003e2.6\u0027 % project_name)"},{"line_number":179,"context_line":"        else:"},{"line_number":180,"context_line":"            requirements.append(line)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fl38%3D","line":178,"updated":"2013-10-31 18:37:38.000000000","message":"So, I think I did a disservice asking you to split this patch earlier - thank you for humouring me even though it must have come across as bonghits. \n\nI read the if/elif/elif/elif/else as being lots of paths to skip and one to add.\n\nSo...\nThis looks fine, but:\n - it would be great if the code was more regular.\n\nE.g.\n\n if\n    line \u003d blah.\n elif\n    line \u003d blah\n elif\n    line \u003d None\n    reason \u003d \u0027Index location\u0027\n elif \n    line \u003d None\n    reason \u003d \u0027Python 2.6 only dependency\u0027\n \n if line is not None:\n     requirements.append(line)\n else:\n     log.info(... % (reason,))\n\nWhat do you think?","commit_id":"619fe5caab3df5519ad4c736537e6ef7bc275ae7"}]}