)]}'
{"pbr/packaging.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"5d4953e73eab710d38fdf103b186a89272124680","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bc6o%3D","line":725,"updated":"2013-11-25 22:09:27.000000000","message":"Please include a comment about why this isn\u0027t using super().","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"022d75822cb3015c05213dc7bcf08eaa25a167a8","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bb9A%3D","line":725,"in_reply_to":"AAAATn%2F%2Bc6o%3D","updated":"2013-11-26 03:54:09.000000000","message":"Done","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"5d4953e73eab710d38fdf103b186a89272124680","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list):"},{"line_number":729,"context_line":"                self.builders \u003d self.builders.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bc6g%3D","line":726,"updated":"2013-11-25 22:09:27.000000000","message":"The blank line doesn\u0027t add anything here - since you\u0027re going to be adding a comment, please also remove it :)","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"022d75822cb3015c05213dc7bcf08eaa25a167a8","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list):"},{"line_number":729,"context_line":"                self.builders \u003d self.builders.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bb88%3D","line":726,"in_reply_to":"AAAATn%2F%2Bc6g%3D","updated":"2013-11-26 03:54:09.000000000","message":"Done","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"d40753473aa9f77b7c00edf20c96e5798949fe5e","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            # Finalize sphinx.setup_command.BuildDoc options"},{"line_number":726,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list) and self.builders:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Bb3o%3D","line":725,"updated":"2013-11-26 04:56:00.000000000","message":"Still doesn\u0027t mention why this isn\u0027t using super() :) Why isn\u0027t it using super?","commit_id":"d8630ef4903abd636e143f7dc51af1427aa27adf"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"e0fb94753c5ea76ecda9930a08858594f34afe31","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            # Finalize sphinx.setup_command.BuildDoc options"},{"line_number":726,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list) and self.builders:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BTxk%3D","line":725,"in_reply_to":"AAAATn%2F%2BWGA%3D","updated":"2013-11-27 15:15:18.000000000","message":"Sure. will do","commit_id":"d8630ef4903abd636e143f7dc51af1427aa27adf"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"55fe7a9014fcb05e077b3a6065c6b9399c6f9c6a","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            # Finalize sphinx.setup_command.BuildDoc options"},{"line_number":726,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list) and self.builders:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Bbng%3D","line":725,"in_reply_to":"AAAATn%2F%2Bb3o%3D","updated":"2013-11-26 06:10:51.000000000","message":"Oh, I see. I misunderstood your question before. That\u0027s because this is not a new style class, and the super keyword will not work ;)","commit_id":"d8630ef4903abd636e143f7dc51af1427aa27adf"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"7357365768879098336e51b2c6892b46a07ad4c2","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    setup_command.BuildDoc.run(self)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        def finalize_options(self):"},{"line_number":725,"context_line":"            # Finalize sphinx.setup_command.BuildDoc options"},{"line_number":726,"context_line":"            setup_command.BuildDoc.finalize_options(self)"},{"line_number":727,"context_line":"            # Allow builders to be configurable - as a comma separated list."},{"line_number":728,"context_line":"            if not isinstance(self.builders, list) and self.builders:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BWGA%3D","line":725,"in_reply_to":"AAAATn%2F%2Bbng%3D","updated":"2013-11-27 05:01:19.000000000","message":"Ok - so I\u0027d like you to capture the answer to that question here, for anyone perusing the code later.","commit_id":"d8630ef4903abd636e143f7dc51af1427aa27adf"}],"pbr/tests/test_setup.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"5d4953e73eab710d38fdf103b186a89272124680","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.assertIn(\u0027html\u0027, build_doc.builders)"},{"line_number":278,"context_line":"        self.assertIn(\u0027man\u0027, build_doc.builders)"},{"line_number":279,"context_line":"        self.assertIn(\u0027doctest\u0027, build_doc.builders)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class ParseRequirementsTest(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bc6M%3D","line":279,"updated":"2013-11-25 22:09:27.000000000","message":"Please add another test that shows the behaviour when the setting is set to an empty string.\n\nAnd a third test that shows behaviour when it has just one option (e.g. doctest, or man).","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"022d75822cb3015c05213dc7bcf08eaa25a167a8","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.assertIn(\u0027html\u0027, build_doc.builders)"},{"line_number":278,"context_line":"        self.assertIn(\u0027man\u0027, build_doc.builders)"},{"line_number":279,"context_line":"        self.assertIn(\u0027doctest\u0027, build_doc.builders)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"class ParseRequirementsTest(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bb9E%3D","line":279,"in_reply_to":"AAAATn%2F%2Bc6M%3D","updated":"2013-11-26 03:54:09.000000000","message":"Thanks for the suggestion! That indeed revealed an issue.","commit_id":"0fad34c9d5770259543fddfa95540387084105fd"}]}