)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0b65d9868d361bd8833eeaa3dcff9c55050e28b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Natal Ngétal \u003chobbestigrou@erakis.eu\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-21 16:31:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change python3.5 job to python3.7 job on Stein+"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a mechanically generated patch to add a unit test job running"},{"line_number":10,"context_line":"under Python 3.7 and drop the Python 3.5 unit test job."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5fc1f717_bf657f1f","line":7,"updated":"2019-03-21 15:33:24.000000000","message":"I guess you need to update the message too","commit_id":"5a49eb978bf84108c133d1bbd5ff8011f59bc198"}],"tox.ini":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"4652c6541a416c19082a6c1d430ad03a3aeb2aa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d docs,pep8,py{37,36,35,27}"},{"line_number":4,"context_line":"[testenv]"},{"line_number":5,"context_line":"usedevelop \u003d True"},{"line_number":6,"context_line":"install_command \u003d pip install {opts} {packages}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5fc1f717_bf25950c","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":35},"updated":"2019-04-02 10:42:48.000000000","message":"I do not find the propose logic optimal because it will take agest to run py27 tests, it will run docs first (why?).\n\nOrder is important as we want to priorietize things that can break and also take care of speed: aiming to fail as fast as possible.\n\nBased on what used on other projects, I would propose using:\n\nenvlist \u003d pep8,py{27,37,36,35},docs\n\nWhy? linting first, is cheap. py27 after as is oldest supprot python followed by the *newest* one (the rest after in desc order). Docs last as is least likely for us to update docs. Also, those doing the docs only are already used to do tox -e docs anyway.\n\nAlso you are missing two key entries for tox ini:\n\nskip_missing_interpreters \u003d True\nignore_basepython_conflict \u003d True\n\nBoth of these options would improve developers experience,\nwithout affecting CI testing.","commit_id":"7db0c2f96ee475e6e1c3ea357e32d39052db9d7e"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1f83c9e5cf5f61ef99b0d6ae805d2134b7ed9ea0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1"},{"line_number":3,"context_line":"envlist \u003d pep8,py{37,36,35,27},docs"},{"line_number":4,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":5,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":7,"id":"3fce034c_b7147845","line":3,"updated":"2019-04-18 15:00:31.000000000","message":"Not that I ever run tox without specifying envs, but it\u0027s probably overkill to run all three py3 jobs.\n\nAlso worth noting that the reason for putting py3 jobs before py2 jobs is mostly historical at this point. testrepository had a weird incompatibility where if you ran py2 tests and then ran py3 tests it would fail on py3. py3 then py2 worked fine. Since we\u0027ve switched to stestr that shouldn\u0027t be an issue anymore though.\n\nThat said, I\u0027m pretty indifferent to this list and wouldn\u0027t -1 for anything not crazy. :-)","commit_id":"d371cf497581b38bf5370960a222e91567456e34"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1f83c9e5cf5f61ef99b0d6ae805d2134b7ed9ea0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1"},{"line_number":3,"context_line":"envlist \u003d pep8,py{37,36,35,27},docs"},{"line_number":4,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":5,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3fce034c_34c96625","line":4,"updated":"2019-04-18 15:00:31.000000000","message":"Since we\u0027re adding this, can we switch to setting basepython globally and get rid of all the explicit ones for each venv?","commit_id":"d371cf497581b38bf5370960a222e91567456e34"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd7f62a3d29f6a9043827cee6ccce8e74c41d5fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1"},{"line_number":3,"context_line":"envlist \u003d pep8,py{37,36,35,27},docs"},{"line_number":4,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":5,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"bfb3d3c7_534815cb","line":4,"in_reply_to":"3fce034c_34c96625","updated":"2019-05-21 08:51:50.000000000","message":"I suggest we do this as a follow-up","commit_id":"d371cf497581b38bf5370960a222e91567456e34"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c5a8558b713883e29c5b4b9ce863c7c04ef6de50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1"},{"line_number":3,"context_line":"envlist \u003d pep8,py{37,36,35,27},docs"},{"line_number":4,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":5,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":9,"id":"bfb3d3c7_e117be50","line":4,"updated":"2019-05-23 14:03:45.000000000","message":"My point was that we\u0027re adding this option and a required minversion to support it, but we aren\u0027t actually making use of the feature it adds.","commit_id":"20d95468bcc5df499b17e28b6ce440ad03a9a94f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"97c637f828d2dd19f86631264f49aa1a7c8a6ae7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1"},{"line_number":3,"context_line":"envlist \u003d pep8,py{37,36,35,27},docs"},{"line_number":4,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":5,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":9,"id":"bfb3d3c7_a7d8f67e","line":4,"in_reply_to":"bfb3d3c7_e117be50","updated":"2019-05-23 14:49:35.000000000","message":"Fair. In that case, see https://review.opendev.org/#/c/660297/","commit_id":"20d95468bcc5df499b17e28b6ce440ad03a9a94f"}]}