)]}'
{"pbr/git.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"61ca39a2d246e3b51497817defed715a4a7ddfec","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                # on \", \" which is the separator between elements"},{"line_number":251,"context_line":"                candidate \u003d tag_string.split(\", \")[0].replace(\"-\", \".\")"},{"line_number":252,"context_line":"                if _is_valid_version(candidate):"},{"line_number":253,"context_line":"                    tags.add(candidate)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        yield sha, tags, msg"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_86bfbd77","line":253,"updated":"2018-12-07 22:19:39.000000000","message":"Hmm, this is going to return a tag that doesn\u0027t exist because of the s/-/./ above. I guess that\u0027s okay though since the consuming code doesn\u0027t look for the actual git tag again, it\u0027s just using the string for versioning. I\u0027m wondering if we should mention this in the docstring though in case it ever does get reused for something else.","commit_id":"5cf046adb3d1f94f1cbc87637af2c07af55588f6"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"415e8b5dbcc79ed73ab8265aff25d0ceee994219","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    uses."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    .. caution:: this function risk to return a tag that doesn\u0027t exist really"},{"line_number":227,"context_line":"                 inside the git objects list due to replacement made "},{"line_number":228,"context_line":"                 to tag name to also list pre-release suffix."},{"line_number":229,"context_line":"                 Compliant with the SemVer specification (e.g 1.2.3-rc1)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e624e71b","line":227,"range":{"start_line":227,"start_character":68,"end_line":227,"end_character":69},"updated":"2018-12-14 15:29:27.000000000","message":"Nit: trailing whitespace","commit_id":"064d1a556ed57211bc526bfa12ef73323fd05121"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"415e8b5dbcc79ed73ab8265aff25d0ceee994219","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    .. caution:: this function risk to return a tag that doesn\u0027t exist really"},{"line_number":227,"context_line":"                 inside the git objects list due to replacement made "},{"line_number":228,"context_line":"                 to tag name to also list pre-release suffix."},{"line_number":229,"context_line":"                 Compliant with the SemVer specification (e.g 1.2.3-rc1)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    :return: An iterator of (hash, tags_set, 1st_line) tuples."},{"line_number":232,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a6e34f9f","line":229,"range":{"start_line":229,"start_character":58,"end_line":229,"end_character":71},"updated":"2018-12-14 15:29:27.000000000","message":"As part of the example, maybe show what this becomes after replacement. Something like \"(e.g. 1.2.3-rc1 becomes 1.2.3.rc1)\".","commit_id":"064d1a556ed57211bc526bfa12ef73323fd05121"}]}