)]}'
{"id":"openstack%2Fpbr~705693","triplet_id":"openstack%2Fpbr~master~Ia1a4722e555bda561ab8fbc735d115279ff6ea98","project":"openstack/pbr","branch":"master","topic":"drop-py27-support","hashtags":[],"change_id":"Ia1a4722e555bda561ab8fbc735d115279ff6ea98","subject":"Drop python 2.7 support and testing","status":"ABANDONED","created":"2020-02-04 14:29:23.000000000","updated":"2020-08-06 08:34:14.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"810fd5bad4617c36f445ea7ae42717b4501fe366","_number":705693,"virtual_id_number":705693,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"date":"2020-06-16 16:04:05.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-16 19:29:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":-1,"date":"2020-06-16 16:01:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":-2,"date":"2020-06-16 17:12:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-25 23:54:53.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-06-16 16:01:48.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2020-06-16 16:04:05.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2020-06-16 17:12:13.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-06-16 19:29:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aee3a06e22dd81d44d6d0a0967a8e7bca2324ead","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-04 14:29:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8314929f8e360e6456e463c4523bad8f3da9054","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-04 15:49:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/b913ddc9900642d7905ab6db4df9df3b : SUCCESS in 3m 21s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/822385e7fc11432b85ddcd44ee76ec09 : SUCCESS in 1h 16m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f2e20cd5ad80447d817855705690f8af : SUCCESS in 6m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9541e7db2bda485b81312b20a894a63b : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cd64b21919c44231af23ebf429bc8dab : SUCCESS in 3m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/975d4ced7662476a98b808f4bf9a3efb : SUCCESS in 4m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ac0861699d114c3ebd16a0c66079d263 : SUCCESS in 5m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/54f30212564147f1b9d4aa351def1b69 : SUCCESS in 5m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59500022fa8e4edcb368252f3422481d : SUCCESS in 4m 35s\n- pbr-installation-devstack https://zuul.opendev.org/t/openstack/build/6e795bd97aa842b5b171c8c86ff7444d : FAILURE in 25m 38s\n- pbr-installation-upstream-devstack https://zuul.opendev.org/t/openstack/build/755bbf7de7d045f592664f34233f84a3 : FAILURE in 21m 12s","accounts_in_message":[],"_revision_number":1},{"id":"473466fb5bcd1880cb77771bdc97bd69369cacfd","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-05 13:57:01.000000000","message":"Patch Set 1:\n\nI wondering if we should remove `pbr-installation-devstack` zuul jobs.\n\nI\u0027m not sure but these job are based on playbooks named \u0027legacy\u0027 so given that we drop backward compatibility I think we could remove these jobs.\n\nAnybody with more understanding of these jobs and how they works are welcome.\n\nI observed that they gave us python 2 environment...\n\n```\n+ /opt/stack/new/pbr/tools/integration.sh:main:L137:   /tmp/tmp.7bcBhACcRQ/eptest/venv/bin/pip install -f /tmp/tmp.7bcBhACcRQ/.wheelhouse -e /tmp/tmp.7bcBhACcRQ/eppbrdir\nDEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support\nLooking in indexes: http://mirror.ord.rax.opendev.org/pypi/simple, http://mirror.ord.rax.opendev.org/wheel/ubuntu-18.04-x86_64\nLooking in links: /tmp/tmp.7bcBhACcRQ/.wheelhouse\nObtaining file:///tmp/tmp.7bcBhACcRQ/eppbrdir\nERROR: Package \u0027pbr\u0027 requires a different Python: 2.7.17 not in \u0027\u003e\u003d3.6\u0027\nERROR: the main setup script run by this job failed - exit code: 1\n    please look at the relevant log files to determine the root cause\nRunning devstack worlddump.py\n```","accounts_in_message":[],"_revision_number":1},{"id":"d77b0416681bce8473ba5efb100473882794ca49","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-05 14:02:43.000000000","message":"Patch Set 1: Code-Review-2\n\nI can look into the failing jobs here. However, it\u0027s worth noting that we generally don\u0027t pin pbr in packages so this is going to break things for *everyone* that\u0027s still running Python 2.7 code. I think this is maybe one we\u0027d want to wait for another cycle for. We should probably discuss with gmann or even raise this on openstack-discuss. -2 til we figure that out.","accounts_in_message":[],"_revision_number":1},{"id":"666e077e8bafb87c55b636281ad5a78a4ec1dd45","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-05 14:32:33.000000000","message":"Patch Set 1: Workflow-1\n\nI agree, we must wait and discuss before dropping the support in pbr.  It risk to introduce severe side effects in the whole python ecosystem.","accounts_in_message":[],"_revision_number":1},{"id":"9d4f0feca150db054effcee2753ea88d34ffd680","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-02-05 18:46:05.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nSince we need to keep py27 testing, what about adding a note to those places where you would remove it? I left some suggestions...","accounts_in_message":[],"_revision_number":1},{"id":"276fe84c66effc813122c8e4baff7a197f6a8888","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-06 10:07:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7529cde97a3d9f542b947cbc49606b7f088c5c5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 11:27:43.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/c4f866df7b0a45649704d2e7fb94075d : SUCCESS in 2m 48s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6aef5da701b24d27bf4792f4b8fb64a5 : SUCCESS in 1h 18m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/373d9e9b559c4529bb2e661f4c0a6b60 : SUCCESS in 6m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/34ca3c8e1b2d4caab451a5c8c4106d65 : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2599ad956d7943cfa2b538d1ec482f80 : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/49e9410ef15e43e692a4aea01df5ce3a : SUCCESS in 7m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8934b186e94347b48a00ba297343330e : SUCCESS in 6m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3fd42b6bc40041189d88b499d50bf470 : SUCCESS in 5m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b7b4c5ee5fb840adb824d0b15fa5b477 : SUCCESS in 4m 46s\n- pbr-installation-devstack https://zuul.opendev.org/t/openstack/build/73fde847f4a442a8b871db4f639f756d : FAILURE in 19m 58s\n- pbr-installation-upstream-devstack https://zuul.opendev.org/t/openstack/build/bd8482c5eeb141dda59c4e03cf606e87 : FAILURE in 19m 14s","accounts_in_message":[],"_revision_number":2},{"id":"d48a7644a1cd33561cf63f260d6e30b4c05fede6","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-02-07 09:16:04.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"66f58125572e47f8d226e9d04cc7eae35f065fd4","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-04-25 23:54:53.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e I can look into the failing jobs here. However, it\u0027s worth noting\n \u003e that we generally don\u0027t pin pbr in packages so this is going to\n \u003e break things for *everyone* that\u0027s still running Python 2.7 code. I\n \u003e think this is maybe one we\u0027d want to wait for another cycle for. We\n \u003e should probably discuss with gmann or even raise this on\n \u003e openstack-discuss. -2 til we figure that out.\n\nI agree to keep it as it is. swift and storlets are keeping py2.7 support also we need pbr for stable branch py2.7 testing. We can do it sometime in later cycles.","accounts_in_message":[],"_revision_number":2},{"id":"7a12766d93edbd887ce2fed87a04229a2c90a4dd","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-06-16 15:48:37.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e I can look into the failing jobs here. However, it\u0027s worth noting\n \u003e that we generally don\u0027t pin pbr in packages so this is going to\n \u003e break things for *everyone* that\u0027s still running Python 2.7 code. I\n \u003e think this is maybe one we\u0027d want to wait for another cycle for. We\n \u003e should probably discuss with gmann or even raise this on\n \u003e openstack-discuss. -2 til we figure that out.\n\nSo it looks like this won\u0027t be an issue since we can use \u0027python_requires\u0027 to validate handle things. \u0027setuptools\u0027 is doing just this [1] and creating e.g. a new virtualenv with Python 2.7 ends up with the correct version getting installed.\n\nThis needs some fixups but otherwise should be okay.\n\n[1] https://github.com/pypa/setuptools/blob/v47.3.0/setup.cfg#L48","accounts_in_message":[],"_revision_number":2},{"id":"0748e8e676f74b41b7d8b94f5e6dcb8957556b42","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-06-16 15:59:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b29c3944d539f0d4d2fd4a2449a03a5065d2129","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2020-06-16 16:01:48.000000000","message":"Patch Set 3: Code-Review-1\n\nYou can\u0027t pin pbr so you can\u0027t just use older pbr easily with older software.","accounts_in_message":[],"_revision_number":3},{"id":"52834c8e8592138282c344ab889c65c2397ebb00","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-06-16 16:02:28.000000000","message":"Patch Set 3:\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"077a9faf92a019fddf677bbf263d2e3d91690ba0","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2020-06-16 16:02:54.000000000","message":"Patch Set 3:\n\n\u003e \u003e I can look into the failing jobs here. However, it\u0027s worth noting\n \u003e \u003e that we generally don\u0027t pin pbr in packages so this is going to\n \u003e \u003e break things for *everyone* that\u0027s still running Python 2.7 code.\n \u003e I\n \u003e \u003e think this is maybe one we\u0027d want to wait for another cycle for.\n \u003e We\n \u003e \u003e should probably discuss with gmann or even raise this on\n \u003e \u003e openstack-discuss. -2 til we figure that out.\n \u003e \n \u003e So it looks like this won\u0027t be an issue since we can use\n \u003e \u0027python_requires\u0027 to validate handle things. \u0027setuptools\u0027 is doing\n \u003e just this [1] and creating e.g. a new virtualenv with Python 2.7\n \u003e ends up with the correct version getting installed.\n \u003e \n \u003e This needs some fixups but otherwise should be okay.\n \u003e \n \u003e [1] https://github.com/pypa/setuptools/blob/v47.3.0/setup.cfg#L48\n\nThis functionality depends on newer tools like pip and setuptools which you can\u0027t presume are in place on distros.","accounts_in_message":[],"_revision_number":3},{"id":"c69027c9dba8aa4f2b0be63bb8830fc92418ef77","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-06-16 16:03:53.000000000","message":"Patch Set 3:\n\n\u003e You can\u0027t pin pbr so you can\u0027t just use older pbr easily with older\n \u003e software.\n\nDoesn\u0027t the \u0027python-requires\u0027 machinery take care of this for us? If I run:\n\n  virtualenv --python python2.7 venv\n\nI see setuptools 44.1.1 installed, not the latest version (currently 47.3.0), since 44.1.1 was the last version without the \u0027python_requires \u003e\u003d 3.6\u0027 marker","accounts_in_message":[],"_revision_number":3},{"id":"8840c0e7cb1f749cc9f7f421d2efd8af2ee57c9d","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-06-16 16:04:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d7a878e4df1c42f171640913c884f173f542fba6","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2020-06-16 16:09:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8eb1a21692f09fbed504865b6eee1e216f4d2ea4","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2020-06-16 16:12:48.000000000","message":"Patch Set 3:\n\n\u003e \u003e You can\u0027t pin pbr so you can\u0027t just use older pbr easily with\n \u003e older\n \u003e \u003e software.\n \u003e \n \u003e Doesn\u0027t the \u0027python-requires\u0027 machinery take care of this for us?\n \u003e If I run:\n \u003e \n \u003e virtualenv --python python2.7 venv\n \u003e \n \u003e I see setuptools 44.1.1 installed, not the latest version\n \u003e (currently 47.3.0), since 44.1.1 was the last version without the\n \u003e \u0027python_requires \u003e\u003d 3.6\u0027 marker\n\nThat is a different scenario. PBR is insatlled with setup_requires. This uses easy install under the hood. Setuptools installed into a virtualenv is installed using bundled software in the virtualenv itself. This software can be kept up to date.\n\nThere are two methods I see this breaking. The first is if I\u0027m a distro package user and have gotten pip and setuptools from my distro. Pip installing a pbr package under python2 will likely break on xenial and centos 7 if you drop python2 here.\n\nThe other case is whether or not setup_requires does the right thing at all in cases where python2 is reasonably up to date (ubuntu bionic). I expect easy install will always pull the latest version it can find then fail later when it doesn\u0027t run under python2.","accounts_in_message":[],"_revision_number":3},{"id":"64daa42b522496c6492d3b82c5a0e9a0a1687a5c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-06-16 17:12:13.000000000","message":"Patch Set 3: Code-Review-2\n\n\u003e \u003e \u003e You can\u0027t pin pbr so you can\u0027t just use older pbr easily with\n \u003e \u003e older\n \u003e \u003e \u003e software.\n \u003e \u003e\n \u003e \u003e Doesn\u0027t the \u0027python-requires\u0027 machinery take care of this for us?\n \u003e \u003e If I run:\n \u003e \u003e\n \u003e \u003e virtualenv --python python2.7 venv\n \u003e \u003e\n \u003e \u003e I see setuptools 44.1.1 installed, not the latest version\n \u003e \u003e (currently 47.3.0), since 44.1.1 was the last version without the\n \u003e \u003e \u0027python_requires \u003e\u003d 3.6\u0027 marker\n \u003e \n \u003e That is a different scenario. PBR is insatlled with setup_requires.\n \u003e This uses easy install under the hood. Setuptools installed into a\n \u003e virtualenv is installed using bundled software in the virtualenv\n \u003e itself. This software can be kept up to date.\n \u003e\n \u003e There are two methods I see this breaking. The first is if I\u0027m a\n \u003e distro package user and have gotten pip and setuptools from my\n \u003e distro. Pip installing a pbr package under python2 will likely\n \u003e break on xenial and centos 7 if you drop python2 here.\n \u003e \n \u003e The other case is whether or not setup_requires does the right\n \u003e thing at all in cases where python2 is reasonably up to date\n \u003e (ubuntu bionic). I expect easy install will always pull the latest\n \u003e version it can find then fail later when it doesn\u0027t run under\n \u003e python2.\n\nIt seems setuptools uses easy_install only if pip isn\u0027t available [1]. That\u0027s very recent behavior though (v42.0.0, released November 2019) and not something to rely on yet, meaning all the above makes sense. Darn.\n\n[1] https://github.com/pypa/setuptools/commit/d6948c636f5e657ac56911b71b7a459d326d8389","accounts_in_message":[],"_revision_number":3},{"id":"7a71d8146f952d14a92066b42f56fedff50b6ddc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-16 19:29:35.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/ed8c6819aabe426dacf9222e9be9d549 : FAILURE in 3m 42s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/600f9509fee44aa691388a02c5f16f59 : SUCCESS in 1h 17m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cc5704d685dd421c8a67abee733d8c75 : SUCCESS in 6m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4b427d66ba304ce0be197ca5a6ca57c7 : FAILURE in 8m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/015ed80ac15146f0845939c6232dae5b : SUCCESS in 6m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d6cd6d8273164aaa9e9ba51e17b4d6f0 : SUCCESS in 6m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e1155d3e064341f1a7e269ff0a5bee30 : SUCCESS in 7m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5d05b81657514c0ba371b0c23f1056ce : SUCCESS in 8m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cfb67e674a1e47629cf39212eb800eea : SUCCESS in 5m 50s\n- pbr-installation-devstack https://zuul.opendev.org/t/openstack/build/4f9f16044ff545bd82bdf83befc87f95 : FAILURE in 19m 31s\n- pbr-installation-upstream-devstack https://zuul.opendev.org/t/openstack/build/dcdd9959a3ec4b14ae4014d129c30ad4 : FAILURE in 20m 54s","accounts_in_message":[],"_revision_number":3},{"id":"3b7db403de19f11fc67f75576c1ffb2e420a4a2d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 08:34:14.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c0b052e1a5cf8b8f62d897fcd66a194bc9b7404f","revisions":{"0107c8f252faade3e71705ccd2c117600d59fa8a":{"kind":"REWORK","_number":1,"created":"2020-02-04 14:29:23.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/93/705693/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/pbr","ref":"refs/changes/93/705693/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/pbr refs/changes/93/705693/1"}}},"commit":{"parents":[{"commit":"9257b6843568052be1dc1a5f3df6f629795e08b2","subject":"Merge \"Switch to Ussuri jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/9257b6843568052be1dc1a5f3df6f629795e08b2"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-02-04 14:25:54.000000000","tz":60},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-02-04 14:29:10.000000000","tz":60},"subject":"[ussuri][goal] Drop python 2.7 support and testing","message":"[ussuri][goal] Drop python 2.7 support and testing\n\nOpenStack is dropping the py2.7 support in Ussuri cycle.\n\nComplete discussion \u0026 schedule can be found in\n-\nhttp://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html\n- https://etherpad.openstack.org/p/drop-python2-support\n\nUssuri Communtiy-wide goal:\nhttps://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html\n\nChange-Id: Ia1a4722e555bda561ab8fbc735d115279ff6ea98\nSem-Ver: api-break\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/0107c8f252faade3e71705ccd2c117600d59fa8a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/0107c8f252faade3e71705ccd2c117600d59fa8a"}]},"branch":"refs/heads/master"},"16b6c64ae18ddf628ba4630899f205c842e83d45":{"kind":"REWORK","_number":2,"created":"2020-02-06 10:07:23.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/93/705693/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/pbr","ref":"refs/changes/93/705693/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/pbr refs/changes/93/705693/2"}}},"commit":{"parents":[{"commit":"9257b6843568052be1dc1a5f3df6f629795e08b2","subject":"Merge \"Switch to Ussuri jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/9257b6843568052be1dc1a5f3df6f629795e08b2"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-02-04 14:25:54.000000000","tz":60},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-02-06 10:07:11.000000000","tz":60},"subject":"[ussuri][goal] Drop python 2.7 support and testing","message":"[ussuri][goal] Drop python 2.7 support and testing\n\nOpenStack is dropping the py2.7 support in Ussuri cycle.\n\nComplete discussion \u0026 schedule can be found in\n-\nhttp://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html\n- https://etherpad.openstack.org/p/drop-python2-support\n\nUssuri Communtiy-wide goal:\nhttps://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html\n\nChange-Id: Ia1a4722e555bda561ab8fbc735d115279ff6ea98\nSem-Ver: api-break\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/16b6c64ae18ddf628ba4630899f205c842e83d45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/16b6c64ae18ddf628ba4630899f205c842e83d45"}]},"branch":"refs/heads/master"},"c0b052e1a5cf8b8f62d897fcd66a194bc9b7404f":{"kind":"REWORK","_number":3,"created":"2020-06-16 15:59:20.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/93/705693/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/pbr","ref":"refs/changes/93/705693/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/pbr refs/changes/93/705693/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/pbr refs/changes/93/705693/3"}}},"commit":{"parents":[{"commit":"9257b6843568052be1dc1a5f3df6f629795e08b2","subject":"Merge \"Switch to Ussuri jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/9257b6843568052be1dc1a5f3df6f629795e08b2"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-02-04 14:25:54.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-06-16 15:57:08.000000000","tz":60},"subject":"Drop python 2.7 support and testing","message":"Drop python 2.7 support and testing\n\nDrop support for Python 2.7. Applications and libraries that still use\nPython 2.7 can continue to use older versions of pbr.\n\nAs part of this change, we also need to add support for virtualenv 20.x,\nwhich has changed how the programmatic API works [1] as part of a larger\nrewrite. This has to be done at the same time as dropping Python 2.7\nsupport since 20.x does not appear to be compatible with Python 2.7.\n\n[1] https://github.com/pypa/virtualenv/issues/1585#issuecomment-585228492\n\nChange-Id: Ia1a4722e555bda561ab8fbc735d115279ff6ea98\nSem-Ver: api-break\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/c0b052e1a5cf8b8f62d897fcd66a194bc9b7404f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/pbr/commit/c0b052e1a5cf8b8f62d897fcd66a194bc9b7404f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}