)]}'
{"lower-constraints.txt":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e98a3784911a1798a03fe1a35c41ba595e911e53","unresolved":false,"context_lines":[{"line_number":34,"context_line":"testtools\u003d\u003d2.2.0"},{"line_number":35,"context_line":"traceback2\u003d\u003d1.4.0"},{"line_number":36,"context_line":"unittest2\u003d\u003d1.1.0"},{"line_number":37,"context_line":"virtualenv\u003d\u003d20.0.3"}],"source_content_type":"text/plain","patch_set":9,"id":"9f560f44_2f45cb43","line":37,"updated":"2020-08-05 15:48:32.000000000","message":"If we\u0027re dropping upper constraints should we drop this file too (and the corresponding test job)?","commit_id":"f96874d2c372e52aea53ff923654a919dc19224a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"59cd95181b24876ef4f220751044fd7b55941270","unresolved":false,"context_lines":[{"line_number":34,"context_line":"testtools\u003d\u003d2.2.0"},{"line_number":35,"context_line":"traceback2\u003d\u003d1.4.0"},{"line_number":36,"context_line":"unittest2\u003d\u003d1.1.0"},{"line_number":37,"context_line":"virtualenv\u003d\u003d20.0.3"}],"source_content_type":"text/plain","patch_set":9,"id":"9f560f44_cf3ecf89","line":37,"in_reply_to":"9f560f44_2f45cb43","updated":"2020-08-05 15:55:01.000000000","message":"Probably.\n\nThough since we can\u0027t enforce that this is the minimum version of virtualenv someone might use, we should probably update the run_cli code to try and catch with the old create_environment method too. That way it shouldn\u0027t matter.","commit_id":"f96874d2c372e52aea53ff923654a919dc19224a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d5941619f0f778b53771aa40b6d24c7b4228c296","unresolved":false,"context_lines":[{"line_number":34,"context_line":"testtools\u003d\u003d2.2.0"},{"line_number":35,"context_line":"traceback2\u003d\u003d1.4.0"},{"line_number":36,"context_line":"unittest2\u003d\u003d1.1.0"},{"line_number":37,"context_line":"virtualenv\u003d\u003d20.0.3"}],"source_content_type":"text/plain","patch_set":9,"id":"9f560f44_4f6bdf83","line":37,"in_reply_to":"9f560f44_6f66a3c3","updated":"2020-08-05 15:58:40.000000000","message":"Oh, very good point. I was thinking this was necessary for production use, but the problematic code is only in tests.","commit_id":"f96874d2c372e52aea53ff923654a919dc19224a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1b31da25b1864dd2653aff897fb20f68c21b488e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"testtools\u003d\u003d2.2.0"},{"line_number":35,"context_line":"traceback2\u003d\u003d1.4.0"},{"line_number":36,"context_line":"unittest2\u003d\u003d1.1.0"},{"line_number":37,"context_line":"virtualenv\u003d\u003d20.0.3"}],"source_content_type":"text/plain","patch_set":9,"id":"9f560f44_6f66a3c3","line":37,"in_reply_to":"9f560f44_cf3ecf89","updated":"2020-08-05 15:57:13.000000000","message":"Since virtualenv is only used in the tests I think we can probably get away with telling people to run `tox -r` to rebuild envs. If it is code used on the \"production\" side of pbr I\u0027d agree.","commit_id":"f96874d2c372e52aea53ff923654a919dc19224a"}],"pbr/tests/test_integration.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f01aa702039f416dbcfeb852ff46d3397d72109e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"try:"},{"line_number":15,"context_line":"    import configparser"},{"line_number":16,"context_line":"except ImportError:"},{"line_number":17,"context_line":"    import ConfigParser as configparser"},{"line_number":18,"context_line":"import os.path"},{"line_number":19,"context_line":"import shlex"},{"line_number":20,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_7285e359","line":17,"updated":"2020-08-05 21:23:33.000000000","message":"Do we still need to support py2 for this code?","commit_id":"4a377863bb73b670105af1673f007d0267ad7e52"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f01aa702039f416dbcfeb852ff46d3397d72109e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        with open(constraints, \u0027r\u0027) as src:"},{"line_number":102,"context_line":"            with open(tmp_constraints, \u0027w\u0027) as dest:"},{"line_number":103,"context_line":"                for line in src:"},{"line_number":104,"context_line":"                    if project_name not in line:"},{"line_number":105,"context_line":"                        dest.write(line)"},{"line_number":106,"context_line":"        pip_cmd \u003d PIP_CMD + [\u0027-c\u0027, tmp_constraints]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_b2c93bad","line":104,"updated":"2020-08-05 21:23:33.000000000","message":"We may need to have better regex checking with this. With this, when testing something like ironic, it is also going to strip out ironic-lib, ironic-python-agent, and python-ironicclient.","commit_id":"4a377863bb73b670105af1673f007d0267ad7e52"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"11140053af45c8d57fea69d4da362de74d71fe79","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        with open(constraints, \u0027r\u0027) as src:"},{"line_number":102,"context_line":"            with open(tmp_constraints, \u0027w\u0027) as dest:"},{"line_number":103,"context_line":"                for line in src:"},{"line_number":104,"context_line":"                    if project_name not in line:"},{"line_number":105,"context_line":"                        dest.write(line)"},{"line_number":106,"context_line":"        pip_cmd \u003d PIP_CMD + [\u0027-c\u0027, tmp_constraints]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_720683d0","line":104,"in_reply_to":"9f560f44_b2c93bad","updated":"2020-08-05 21:27:15.000000000","message":"Maybe::\n\nif project_name not in line.split(\u0027\u003d\u003d\u003d\u0027):","commit_id":"4a377863bb73b670105af1673f007d0267ad7e52"}],"pbr/tests/test_packaging.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9c0a39bdfefdc91e6748777a5109ae63140c11dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"import imp"},{"line_number":44,"context_line":"import os"},{"line_number":45,"context_line":"import re"},{"line_number":46,"context_line":"import sys"},{"line_number":47,"context_line":"import sysconfig"},{"line_number":48,"context_line":"import tempfile"},{"line_number":49,"context_line":"import textwrap"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_49654645","line":46,"updated":"2020-06-30 17:47:55.000000000","message":"pep8: F401 \u0027sys\u0027 imported but unused","commit_id":"82886f74bab182970d772f643b627b0c0a04a3a5"}],"tox.ini":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9d52c86f9d9dc3764a3cd6f1b573b3317e3442f7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  OS_TEST_TIMEOUT\u003d{env:OS_TEST_TIMEOUT:60}"},{"line_number":14,"context_line":"# NOTE(stephenfin): pbr intentionally does not use constraints since we support"},{"line_number":15,"context_line":"# a broader range of Python versions than OpenStack as a whole"},{"line_number":16,"context_line":"deps \u003d"},{"line_number":17,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"bf51134e_7b07141e","line":16,"updated":"2020-06-16 16:47:29.000000000","message":"I wonder if we will need to track a different set of upper-constraints, just so there is some enforcement on the versions used. But maybe with a project like PBR that is not needed.","commit_id":"cd367725d7e3cee12502e22d2cf76866fa27798d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f971a8496a988a76bd5f7d07929570628465ed0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  OS_TEST_TIMEOUT\u003d{env:OS_TEST_TIMEOUT:60}"},{"line_number":14,"context_line":"# NOTE(stephenfin): pbr intentionally does not use constraints since we support"},{"line_number":15,"context_line":"# a broader range of Python versions than OpenStack as a whole"},{"line_number":16,"context_line":"deps \u003d"},{"line_number":17,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"bf51134e_fe2152a1","line":16,"in_reply_to":"bf51134e_7b07141e","updated":"2020-06-16 16:52:17.000000000","message":"I considered dropping upper-constraints for just py27, since our \u0027python_version\u0027 markers mean we constrain an increasing number of the packages there. However, it seems like unnecessary complexity given the limited number of packages in use here.","commit_id":"cd367725d7e3cee12502e22d2cf76866fa27798d"}]}