)]}'
{"doc/source/conf.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"79587f2f71772b4393abd8013545fd78f0955a26","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_f2cd735e","line":14,"updated":"2020-10-10 23:31:36.000000000","message":"I don\u0027t believe this header is accurate. This file is autogenerated by sphinx and we shouldn\u0027t assert arbitrary copyright over it.","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a6994ff653f21debfdaec5998afcb981e9496617","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_1b13d6b9","line":14,"in_reply_to":"9f560f44_f2cd735e","updated":"2020-10-12 12:20:20.000000000","message":"Depends on projects but I faced issues with that on few oslo project where linters warned about this, so I prefered to put this header everywhere to avoid the issue without to digging project by project, but I\u0027m fine to drop it if you prefer.","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"}],"test-requirements.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4d48b4b3dc7956a952d7e2fc00f707af1a5e8ae4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2;python_version\u003e\u003d\u00273.4\u0027 # BSD"},{"line_number":21,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pre-commit\u003e\u003d2.6.0;python_version\u003e\u003d\u00273.6\u0027 # MIT"}],"source_content_type":"text/plain","patch_set":6,"id":"9f560f44_60b4fff1","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":40},"updated":"2020-10-09 10:44:09.000000000","message":"testenv pep8 will be executed with python 3 so I think that only track the py3 version is enough.\n\nI don\u0027t see different scenario who would have possible side effect.","commit_id":"0b11a29df0ff1dbd435e4ee90f31591f39a0bdb3"}],"tox.ini":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"79587f2f71772b4393abd8013545fd78f0955a26","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_12d107f9","line":21,"updated":"2020-10-10 23:31:36.000000000","message":"I\u0027m not opposed to having pre-commit config in a repo, but am opposed to using it in the gate as doing so completely bypasses all caching of python packages that we try to do. Instead it installs the deps from source via github which is known to be flaky. We should continue to run flake8 as a normally installed pypi package in the gate to avoid this flakyness.","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bbb26e93decd6153a069b8310102c9fcee1f1c53","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_71bf93fb","line":21,"in_reply_to":"9f560f44_114c5774","updated":"2020-10-12 13:38:37.000000000","message":"got it, thanks Moisés :)\n\n@Clark any thoughts about the formalization part?","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3892465f63de1c6a5a885fdc207ede786b9b66ff","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_aeda6ae2","line":21,"in_reply_to":"9f560f44_12d107f9","updated":"2020-10-12 13:09:02.000000000","message":"I\u0027m not sure to see why calling pre-commit here will bypass our cache, please can you give me more details?\n\nI think it\u0027s because pre-commit will pull/install flake, isn\u0027t?\n\nThen maybe we could solve it by simply refer to the right version/commit of flake8 in our test-requirements, tox will setup our env before pre-commit so pre-commit  will do nothing normally concerning flake8 if it is already present  and this could allow us to continue to take advantage of our caching feature, isn\u0027t?\n\nflake8 is blacklisted from openstack/requirements tests so we can easily setup something around this point to mix our solutions.\n\nThoughts?\n\n[1] https://opendev.org/openstack/requirements/src/branch/master/blacklist.txt#L6","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a6994ff653f21debfdaec5998afcb981e9496617","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_fb7a62ed","line":21,"in_reply_to":"9f560f44_12d107f9","updated":"2020-10-12 12:20:20.000000000","message":"ack, I\u0027ll revert this change.","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b2d6adde83f34af56b8b464a2bd8f8f38e34417e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_0e9a76c3","line":21,"in_reply_to":"9f560f44_5bcc2e33","updated":"2020-10-12 12:33:12.000000000","message":"Agreed, the formalization/uniformization of this tool through our entire scope will fail by abandonning this part","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"04b61bf7b76a6eb00c5027247a5b0d03c4ae1c85","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_114c5774","line":21,"in_reply_to":"9f560f44_aeda6ae2","updated":"2020-10-12 13:28:39.000000000","message":"I don\u0027t think it will not pull if you already have the requirement installed. And yes, the cache bypass is because pre-commit will pull the repos described in .pre-commit-config.yaml","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"535b3c637aea0e7cc7c27dc354bcf6c6886b590f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"commands \u003d stestr run --suppress-attachments {posargs}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"commands \u003d pre-commit run -a"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[testenv:docs]"},{"line_number":24,"context_line":"whitelist_externals \u003d rm"}],"source_content_type":"text/x-properties","patch_set":9,"id":"9f560f44_5bcc2e33","line":21,"in_reply_to":"9f560f44_fb7a62ed","updated":"2020-10-12 12:23:34.000000000","message":"Not gating pre-commit defeats the whole purpose of using it as we discussed before.","commit_id":"1bbb5b10ecb099e28941687956384855cba37cd5"}]}