)]}'
{"pbr/util.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"a243f6163bf55ab6916b6841bdf4135e49ab41b7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    (\u0027install_requires\u0027, (\u0027metadata\u0027, \u0027requires_dist\u0027)),"},{"line_number":118,"context_line":"    (\u0027setup_requires\u0027, (\u0027metadata\u0027, \u0027setup_requires_dist\u0027)),"},{"line_number":119,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027,)),"},{"line_number":120,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027, \u0027requires_python\u0027)),"},{"line_number":121,"context_line":"    (\u0027provides\u0027, (\u0027metadata\u0027, \u0027provides_dist\u0027)),  # **"},{"line_number":122,"context_line":"    (\u0027provides_extras\u0027, (\u0027metadata\u0027,)),"},{"line_number":123,"context_line":"    (\u0027obsoletes\u0027, (\u0027metadata\u0027, \u0027obsoletes_dist\u0027)),  # **"}],"source_content_type":"text/x-python","patch_set":1,"id":"572adf0b_0b50b387","line":120,"updated":"2021-03-15 18:24:28.000000000","message":"Oh, yep, this goes back to why the original change was incorrect. We shouldn\u0027t have implemented this with the alias target as the \"key\" but should have used the alias itself and reversed the order. But the refactor to get there would be a bit more significant i suppose.","commit_id":"8f4f8239d9198e1d9b80d15cc24825cfd0dafce7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"54a0b56c347671a7517b77cfd0cbfca6928c7b2b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    (\u0027install_requires\u0027, (\u0027metadata\u0027, \u0027requires_dist\u0027)),"},{"line_number":118,"context_line":"    (\u0027setup_requires\u0027, (\u0027metadata\u0027, \u0027setup_requires_dist\u0027)),"},{"line_number":119,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027,)),"},{"line_number":120,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027, \u0027requires_python\u0027)),"},{"line_number":121,"context_line":"    (\u0027provides\u0027, (\u0027metadata\u0027, \u0027provides_dist\u0027)),  # **"},{"line_number":122,"context_line":"    (\u0027provides_extras\u0027, (\u0027metadata\u0027,)),"},{"line_number":123,"context_line":"    (\u0027obsoletes\u0027, (\u0027metadata\u0027, \u0027obsoletes_dist\u0027)),  # **"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbe711ec_0a017051","line":120,"updated":"2021-03-15 18:15:54.000000000","message":"The line before this will have created an entry already, which this will then replace, making these at the very least order-dependent, right? Rather, shouldn\u0027t the first one be removed and replaced by the new entry?","commit_id":"8f4f8239d9198e1d9b80d15cc24825cfd0dafce7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7f9d6fbb76a42114cf369de5386b2dab7f05a8cf","unresolved":true,"context_lines":[{"line_number":117,"context_line":"    (\u0027install_requires\u0027, (\u0027metadata\u0027, \u0027requires_dist\u0027)),"},{"line_number":118,"context_line":"    (\u0027setup_requires\u0027, (\u0027metadata\u0027, \u0027setup_requires_dist\u0027)),"},{"line_number":119,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027,)),"},{"line_number":120,"context_line":"    (\u0027python_requires\u0027, (\u0027metadata\u0027, \u0027requires_python\u0027)),"},{"line_number":121,"context_line":"    (\u0027provides\u0027, (\u0027metadata\u0027, \u0027provides_dist\u0027)),  # **"},{"line_number":122,"context_line":"    (\u0027provides_extras\u0027, (\u0027metadata\u0027,)),"},{"line_number":123,"context_line":"    (\u0027obsoletes\u0027, (\u0027metadata\u0027, \u0027obsoletes_dist\u0027)),  # **"}],"source_content_type":"text/x-python","patch_set":1,"id":"aed04780_83eb9fd4","line":120,"in_reply_to":"bbe711ec_0a017051","updated":"2021-03-15 18:20:20.000000000","message":"I read through the code that loops through this list and I believe this is mostly correct. Basically what it does is for every entry in this list it checks the ini setup.cfg for the data and handles it properly if found.\n\nFor (\u0027python_requires\u0027, (\u0027metadata\u0027,)) it will look for:\n\n  [metadata]\n  python_requires \u003d stuff\n\nIn the setup.cfg file and pass it along properly.\n\nFor (\u0027python_requires\u0027, (\u0027metadata\u0027, \u0027requires_python\u0027)) it will look for:\n\n  [metadata]\n  requires_python \u003d stuff\n\nIn the setup.cfg file, rewrite the requires_python content to python_requires and then use that value for setup.py.\n\nThis means that if you have both requires_python and python_requires in setup.cfg then requires_python will win. I guess we might prefer python_requires to win but one of them does need to win.","commit_id":"8f4f8239d9198e1d9b80d15cc24825cfd0dafce7"}]}