)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee129ede734e4792d482ec310067780a5f37f1fb","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Into pyproject.toml - and the pep517 interface will be used."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This doesn\u0027t really change anything else - it just makes us us this. So"},{"line_number":20,"context_line":"by itself this commit isn\u0027t SUPER helpful. But maybe let\u0027s take baby steps"},{"line_number":21,"context_line":"with something this prone to strife, yeah?"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa91455a_4401e510","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":62},"updated":"2021-06-24 14:05:29.000000000","message":"use ?","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee129ede734e4792d482ec310067780a5f37f1fb","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Into pyproject.toml - and the pep517 interface will be used."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This doesn\u0027t really change anything else - it just makes us us this. So"},{"line_number":20,"context_line":"by itself this commit isn\u0027t SUPER helpful. But maybe let\u0027s take baby steps"},{"line_number":21,"context_line":"with something this prone to strife, yeah?"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"After this we can start teasing some things apart and doing our"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"333d58c1_88e89477","line":20,"updated":"2021-06-24 14:05:29.000000000","message":"nit: can you wrap at ~72 chars?","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f60976ea498ee7ad060594ef323fa6537b61e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e702b33_91a77bf4","updated":"2021-10-26 19:55:46.000000000","message":"WIP until the testing in the child change works and we can squash the two changes together.","commit_id":"46f8db0aa925f1bb0d1b6c7b8c9b89eb960cea6c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"419e010db4eb6b5df8af471f2a273d8eeea647d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f76c70c_3f6ad380","updated":"2021-10-27 07:15:01.000000000","message":"Could be worth to discuss this point with the release team too so I adding the release team members to the reviewers.","commit_id":"e909de06f7197cce5c6fa6f5ad454feeda2e4c92"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f268b3f6833e05b758bde7ae39061875e7ee43dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e544961_e686bbd3","updated":"2021-11-01 09:37:31.000000000","message":"LGTM. No issues with includes the pyproject template file, even if we don\u0027t use it yet. Can you add a release note to this? Once we have that, I think we\u0027re good to go","commit_id":"7ad923a788de6537130955c1feb83e7e9634fd40"}],"pbr/build.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee129ede734e4792d482ec310067780a5f37f1fb","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\"pep-517 support"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Add:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      [build-system]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa10d0f6_0d609f12","line":17,"updated":"2021-06-24 14:05:29.000000000","message":"nit: extra newline","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee129ede734e4792d482ec310067780a5f37f1fb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"\"\"\"pep-517 support"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Add:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"      [build-system]"},{"line_number":21,"context_line":"      requires \u003d [\"pbr\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b5bb2fc_a5e86334","line":18,"updated":"2021-06-24 14:05:29.000000000","message":"nit:\n\n  Add::\n\n(so it\u0027ll render as rst)","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee129ede734e4792d482ec310067780a5f37f1fb","unresolved":true,"context_lines":[{"line_number":24,"context_line":"to pyproject.toml to use this"},{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from setuptools import build_meta"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"__all__ \u003d ["},{"line_number":30,"context_line":"    \u0027get_requires_for_build_sdist\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce23ebd5_435c2408","line":27,"updated":"2021-06-24 14:05:29.000000000","message":"This module is present since v36.6.0 [1]. That\u0027s pretty ancient (October 2017) but as far as I can tell, we don\u0027t set a minimum version of setuptools. I can\u0027t see how it would be on the critical code path and users with older setuptools can in theory simply ignore this module, so I _think_ it\u0027s okay, but I\u0027m raising here just in case.\n\n[1] https://github.com/pypa/setuptools/commit/5a0f4b9784a35e514f53ea08adb29d999f511cac","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d2ce406077dca567509ccc020d528ba1269358db","unresolved":true,"context_lines":[{"line_number":24,"context_line":"to pyproject.toml to use this"},{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from setuptools import build_meta"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"__all__ \u003d ["},{"line_number":30,"context_line":"    \u0027get_requires_for_build_sdist\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1849a944_7f81836a","line":27,"in_reply_to":"ce23ebd5_435c2408","updated":"2021-06-24 15:28:33.000000000","message":"Yeah - I think for other reasons we require newer setuptools. But you\u0027re right - if someone adds a pyproject.toml to their project AND wants to use older setuptools they\u0027re effectively crazy. :)","commit_id":"a2ac416a181c2528187149a43d2c4bb1cbb03b15"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b9133a18e7c3ceea86676d6fe56c0262b36857a8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Add::"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"      [build-system]"},{"line_number":20,"context_line":"      requires \u003d [\"pbr\"]"},{"line_number":21,"context_line":"      build-backend \u003d \"pbr.build\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"to pyproject.toml to use this"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ec0bb66_2e4cd79c","line":20,"updated":"2021-10-27 15:27:47.000000000","message":"I think this requires line needs to be updated to include setuptools and wheel. I\u0027ll hold off on that update until there has been more change for feedback to avoid excessive patchsets.","commit_id":"e909de06f7197cce5c6fa6f5ad454feeda2e4c92"}],"pbr/tests/test_packaging.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0f9cdb0049c785578aa2e7d12bca8007110b1e7b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":"        self._reason \u003d reason"},{"line_number":174,"context_line":"        if modules \u003d\u003d ():"},{"line_number":175,"context_line":"            pbr \u003d PBR_ROOT"},{"line_number":176,"context_line":"            modules \u003d [\u0027pip\u0027, \u0027wheel\u0027, \u0027build\u0027, pbr]"},{"line_number":177,"context_line":"        self.modules \u003d modules"},{"line_number":178,"context_line":"        if pip_cmd is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fbcc674_28ba8940","line":175,"updated":"2021-11-03 16:51:31.000000000","message":"It might be good to split some of these general test framework refactors into a parent change so we can be sure we\u0027re not altering PBR\u0027s existing behaviors.","commit_id":"3384725d10c7828a9b175e449bb978e2d933e514"}],"pyproject.toml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a6eb083266741b6e2920a92c9b01d7429a3e2bf9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[build-system]"},{"line_number":2,"context_line":"requires \u003d [\"setuptools\u003e\u003d36.6.0\", \"wheel\"]"},{"line_number":3,"context_line":"build-backend \u003d \"pbr.build\""},{"line_number":4,"context_line":"backend-path \u003d [\".\"]"}],"source_content_type":"text/x-toml","patch_set":3,"id":"d4ff144f_aaf12b1a","line":4,"updated":"2021-10-26 23:06:09.000000000","message":"We should consider if PBR wants to dogfood this from the start. By adding this file we\u0027ll cause pip to go through the pyproject.toml interface for PBR itself as well. We might want to do a release with the new pbr.build tooling and have other packages consume it that way first. Then when we are happy with the results switch PBR to dogfood.","commit_id":"e909de06f7197cce5c6fa6f5ad454feeda2e4c92"}],"releasenotes/notes/pep517-support-89189ce0bab15845.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0f9cdb0049c785578aa2e7d12bca8007110b1e7b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PBR now includes a PEP 517 build-backend and can be used in"},{"line_number":5,"context_line":"    pyproject.toml build-system configuration. Setuptools continues"},{"line_number":6,"context_line":"    to be the backend with PBR acting as a driver via PEP 517"},{"line_number":7,"context_line":"    entrypoints."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"286794d8_fab7ee3e","line":6,"updated":"2021-11-03 16:51:31.000000000","message":"Seems like we\u0027re overloading the meaning of \"backend\" here, maybe instead \"Setuptools continues to be the underlying mechanism with PBR acting as a driver...\"","commit_id":"3384725d10c7828a9b175e449bb978e2d933e514"}]}