)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Bar hochman \u003cilnest.bar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-11 08:51:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: check for the installed version of importlib_metadata and use it only if pbr supports it."},{"line_number":8,"context_line":"bug-report: https://bugs.launchpad.net/pbr/+bug/1972975"},{"line_number":9,"context_line":"Change-Id: If67caac8d7ee7d5f22d0c6d262582b432d3370d1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a071517_b751cc80","line":7,"updated":"2022-05-12 11:21:00.000000000","message":"nit: Keep subject lines under 50 characters (and the body under 72 characters)","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-11 08:51:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: check for the installed version of importlib_metadata and use it only if pbr supports it."},{"line_number":8,"context_line":"bug-report: https://bugs.launchpad.net/pbr/+bug/1972975"},{"line_number":9,"context_line":"Change-Id: If67caac8d7ee7d5f22d0c6d262582b432d3370d1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d0ed153d_8a496323","line":8,"updated":"2022-05-12 11:21:00.000000000","message":"nit:\n\n  Closes-Bug: #1972975","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34828,"name":"Jochman","display_name":"Jochman","email":"ilnest.bar@gmail.com","username":"jochman"},"change_message_id":"7a2a439a916d0fda2e5994c79aa54576266d7d7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3bbdaca_0c883ea0","updated":"2022-05-10 08:25:02.000000000","message":"Hey, can you please review my change?","commit_id":"ddafac658174842530209c12adc76334301fda4f"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"63b8157b22ac3fbf4e69f222e2209633ea31e954","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8e5f3ec_fd32bca7","updated":"2022-05-10 11:19:04.000000000","message":"Ok. This is is better, as it\u0027s isolated from unrelated changes.\nStill couple of things should be done, first you should link it to a bug report if it is a fix.\nMoreover, the commit message should contain an explanation of what is the patch about.\n\nImagine that at some point, someone will open git log, and see the message. The goal should be to have message verbose enough for them to catch on.\n\nI\u0027m adding pbr cores to the review. ","commit_id":"ddafac658174842530209c12adc76334301fda4f"},{"author":{"_account_id":34828,"name":"Jochman","display_name":"Jochman","email":"ilnest.bar@gmail.com","username":"jochman"},"change_message_id":"883ecbf08e39158277b82fac2db3ba3f9ad97b99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9a1ed97_89e09409","in_reply_to":"f8e5f3ec_fd32bca7","updated":"2022-05-12 10:50:11.000000000","message":"I\u0027ve resolved the issue. Thank you for the review.","commit_id":"ddafac658174842530209c12adc76334301fda4f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b90807a3_ce67e607","updated":"2022-05-12 11:21:00.000000000","message":"I still don\u0027t understand what the problem is here. Could you explain the exact issue you\u0027re seeing in a little more detail?","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"513c2f739989acb0a223b628c698e345793f4ede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d2ffba9_1ec67fb2","updated":"2022-08-24 09:39:18.000000000","message":"What is the status here please?","commit_id":"3dc0125f5bb94f6c78af462b369ae4a8afe676de"}],"pbr/version.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    import importlib_metadata"},{"line_number":27,"context_line":"    from packaging.version import Version"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        metadata_version \u003d Version("}],"source_content_type":"text/x-python","patch_set":2,"id":"552a0651_78c09092","line":27,"updated":"2022-05-12 11:21:00.000000000","message":"Doesn\u0027t this mean we\u0027re now depending on the \u0027packaging\u0027 dependency? This isn\u0027t guaranteed to be present on older version afaik","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1732c3cf3ea95d21d6ac7f486f9e2f4a9fd5ed2a","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    import importlib_metadata"},{"line_number":27,"context_line":"    from packaging.version import Version"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        metadata_version \u003d Version("}],"source_content_type":"text/x-python","patch_set":2,"id":"1214205e_b816a63c","line":27,"in_reply_to":"54386fdc_e6c5ad1e","updated":"2022-05-13 10:03:57.000000000","message":"Right, but previously if importlib_metadata was the *correct* version then this would always pass. This will now potentially fail even if we have the correct version of \u0027importlib_metadata\u0027 simply because \u0027packaging\u0027 is missing. That sounds like a regression.","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":34828,"name":"Jochman","display_name":"Jochman","email":"ilnest.bar@gmail.com","username":"jochman"},"change_message_id":"a8c7b653ad707dbd3a89770639364a0b7f9bd58e","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    import importlib_metadata"},{"line_number":27,"context_line":"    from packaging.version import Version"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        metadata_version \u003d Version("}],"source_content_type":"text/x-python","patch_set":2,"id":"54386fdc_e6c5ad1e","line":27,"in_reply_to":"552a0651_78c09092","updated":"2022-05-13 08:14:29.000000000","message":"We are catching this error and just ignoring importlib_metadata if it fails.","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        metadata_version \u003d Version("},{"line_number":31,"context_line":"            importlib_metadata.version(\u0027importlib_metadata\u0027)"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        if metadata_version \u003c Version(\u00271.4\u0027):"},{"line_number":34,"context_line":"            raise ValueError("},{"line_number":35,"context_line":"                \u0027found earlier importlib_metadata version: {}\u0027.format("},{"line_number":36,"context_line":"                    importlib_metadata.version"}],"source_content_type":"text/x-python","patch_set":2,"id":"1759d7b8_d30f0e2d","line":33,"updated":"2022-05-12 11:21:00.000000000","message":"Why is this an issue? What\u0027s wrong with e.g. v1.3.0? Could you provide a stacktrace in the bug report?","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":34828,"name":"Jochman","display_name":"Jochman","email":"ilnest.bar@gmail.com","username":"jochman"},"change_message_id":"a8c7b653ad707dbd3a89770639364a0b7f9bd58e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        metadata_version \u003d Version("},{"line_number":31,"context_line":"            importlib_metadata.version(\u0027importlib_metadata\u0027)"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        if metadata_version \u003c Version(\u00271.4\u0027):"},{"line_number":34,"context_line":"            raise ValueError("},{"line_number":35,"context_line":"                \u0027found earlier importlib_metadata version: {}\u0027.format("},{"line_number":36,"context_line":"                    importlib_metadata.version"}],"source_content_type":"text/x-python","patch_set":2,"id":"b15cc892_771a8e35","line":33,"in_reply_to":"1759d7b8_d30f0e2d","updated":"2022-05-13 08:14:29.000000000","message":"When using the first supported version https://pypi.org/project/importlib-metadata/","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1732c3cf3ea95d21d6ac7f486f9e2f4a9fd5ed2a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        metadata_version \u003d Version("},{"line_number":31,"context_line":"            importlib_metadata.version(\u0027importlib_metadata\u0027)"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        if metadata_version \u003c Version(\u00271.4\u0027):"},{"line_number":34,"context_line":"            raise ValueError("},{"line_number":35,"context_line":"                \u0027found earlier importlib_metadata version: {}\u0027.format("},{"line_number":36,"context_line":"                    importlib_metadata.version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff9f85ac_d20e4baf","line":33,"in_reply_to":"b15cc892_771a8e35","updated":"2022-05-13 10:03:57.000000000","message":"Can you please provide a stacktrace or an example of the error you are seeing? I\u0027m not saying you\u0027re wrong, but I would like to see the kind of errors this can cause. importlib-metadata 1.3.0 is over 2.5 years old so this seems a really unlikely corner case.","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            )"},{"line_number":39,"context_line":"    except importlib_metadata.PackageNotFoundError:"},{"line_number":40,"context_line":"        raise ValueError("},{"line_number":41,"context_line":"            \u0027could not find importlib_metadata installed in the disturbution\u0027"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"    use_importlib \u003d True"},{"line_number":44,"context_line":"except (ImportError, ValueError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6f284f_e854f584","line":41,"range":{"start_line":41,"start_character":64,"end_line":41,"end_character":76},"updated":"2022-05-12 11:21:00.000000000","message":"distribution","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"}],"releasenotes/source/unreleased.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbc18ebf14f64fa8c48a3f0b9746c81142a5e879","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. release-notes::"},{"line_number":6,"context_line":"Fixed a bug where uncompatible version of importlib_metadata is installed and used instead of unusing it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5c153ec3_7b25ce02","line":6,"updated":"2022-05-12 11:21:00.000000000","message":"This isn\u0027t how you create release notes. You need to use \u0027reno\u0027. For example:\n\n  pip install --user reno\n  reno new bug-1972975\n  # edit the created release note in \u0027./releasenotes/notes\u0027","commit_id":"b3a3f8f4108b6d71e71e102fef889a043b262a9b"}]}