)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"66e834495912ba3e20c8d9cb902082cb7647c8db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds tox -e genconfic as an option in pbr so we can generate"},{"line_number":10,"context_line":"the removed sample config files in sdist so that they can be included in"},{"line_number":11,"context_line":"the release tarball."},{"line_number":12,"context_line":"The sample file was removed in I2a72a005208a2c86d69ac461d72e54c53bd395cf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1301519"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F9eoE%3D","line":12,"updated":"2014-04-04 08:34:22.000000000","message":"It might be worth noting that this is only true for Nova","commit_id":"35c0844d3356f1a7bdf255f0a93d56f6bfab56c3"}],"pbr/packaging.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"93bfbda144983d075eec4e8d264de02a498c59c7","unresolved":false,"context_lines":[{"line_number":792,"context_line":"    except ImportError:"},{"line_number":793,"context_line":"        return"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    sample_config_file \u003d (\u0027etc/%(name)s/%(name)s.conf.sample\u0027 %"},{"line_number":796,"context_line":"                              {\u0027name\u0027: project_name})"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    if not os.path.exists(sample_config_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9esc%3D","line":795,"updated":"2014-04-04 08:30:31.000000000","message":"This is probably OK, here but can\u0027t you use os.path tools to build this","commit_id":"35c0844d3356f1a7bdf255f0a93d56f6bfab56c3"},{"author":{"_account_id":8910,"name":"Vladan Popovic","email":"vpopovic@redhat.com","username":"vladan"},"change_message_id":"12d0a251548dbdbfeaee570967c541b92effef98","unresolved":false,"context_lines":[{"line_number":792,"context_line":"    except ImportError:"},{"line_number":793,"context_line":"        return"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    sample_config_file \u003d (\u0027etc/%(name)s/%(name)s.conf.sample\u0027 %"},{"line_number":796,"context_line":"                              {\u0027name\u0027: project_name})"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    if not os.path.exists(sample_config_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9ems%3D","line":795,"in_reply_to":"AAAAWH%2F9esc%3D","updated":"2014-04-04 08:37:55.000000000","message":"right","commit_id":"35c0844d3356f1a7bdf255f0a93d56f6bfab56c3"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"93bfbda144983d075eec4e8d264de02a498c59c7","unresolved":false,"context_lines":[{"line_number":800,"context_line":"            tox.cmdline(args\u003d[\u0027-e\u0027, \u0027genconfig\u0027])"},{"line_number":801,"context_line":"            return sample_config_file"},{"line_number":802,"context_line":"        except:"},{"line_number":803,"context_line":"            # die silently for projects that don\u0027t have a config sample file,"},{"line_number":804,"context_line":"            # or that don\u0027t include the generation script"},{"line_number":805,"context_line":"            return"},{"line_number":806,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9ezQ%3D","line":803,"updated":"2014-04-04 08:30:31.000000000","message":"That DO have... not don\u0027t have here, tight?","commit_id":"35c0844d3356f1a7bdf255f0a93d56f6bfab56c3"},{"author":{"_account_id":8910,"name":"Vladan Popovic","email":"vpopovic@redhat.com","username":"vladan"},"change_message_id":"12d0a251548dbdbfeaee570967c541b92effef98","unresolved":false,"context_lines":[{"line_number":800,"context_line":"            tox.cmdline(args\u003d[\u0027-e\u0027, \u0027genconfig\u0027])"},{"line_number":801,"context_line":"            return sample_config_file"},{"line_number":802,"context_line":"        except:"},{"line_number":803,"context_line":"            # die silently for projects that don\u0027t have a config sample file,"},{"line_number":804,"context_line":"            # or that don\u0027t include the generation script"},{"line_number":805,"context_line":"            return"},{"line_number":806,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9emw%3D","line":803,"in_reply_to":"AAAAWH%2F9ezQ%3D","updated":"2014-04-04 08:37:55.000000000","message":"I meant projects don\u0027t include a sample config file (like glance) but you\u0027re right, this needs to be more clear. The projects that do have a sample config will be skipped on line 798.","commit_id":"35c0844d3356f1a7bdf255f0a93d56f6bfab56c3"},{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"518823c695fe96c5091b89494a94f3f17bbdc36d","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        try:"},{"line_number":803,"context_line":"            tox.cmdline(args\u003d[\u0027-e\u0027, \u0027genconfig\u0027])"},{"line_number":804,"context_line":"            return sample_config_file"},{"line_number":805,"context_line":"        except Exception:"},{"line_number":806,"context_line":"            # die silently for projects that don\u0027t include a sample config"},{"line_number":807,"context_line":"            # file (e.g. glance), or that don\u0027t have the generation script"},{"line_number":808,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2F%2BGo%3D","line":805,"updated":"2014-04-16 08:24:51.000000000","message":"tox will raise a SystemExit here if the command is not present in the project.\n\nSee the error that prevents pbr from installing in the devstack environment:\n\nhttp://logs.openstack.org/07/85207/3/check/check-grenade-dsvm/237862e/logs/old/devstacklog.txt.gz#_2014-04-09_08_42_12_465\n\nand the code in tox that catches the LookupError and raises the SystemExit:\n\nhttps://bitbucket.org/hpk42/tox/src/0c390972b576b50dc0e78bd5cbb8e6a164f15f8b/tox/_cmdline.py?at\u003ddefault#cl-259","commit_id":"46f657a37a9dbdba2f3ef39e348a6ec3c3c279c3"}]}