)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"687300618549edf699cc24b041cdc248abc78a63","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add python 3.12 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. correctly add the setuptools dependency"},{"line_number":10,"context_line":"in test-requirements.txt"},{"line_number":11,"context_line":"2. move all usages from distutils commands"},{"line_number":12,"context_line":"to the appropriate setuptools equivalent, according to"},{"line_number":13,"context_line":"these sources:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ec985168_7aeb0910","line":10,"updated":"2024-07-18 16:45:27.000000000","message":"It would be good to specify why adding it is correct. This is due to python3.12 no longer bundling setuptools so we need to explicitly add it right?","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ffae1b4384d5bc3cc82f2e233b594888f76a2a9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add python 3.12 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. correctly add the setuptools dependency"},{"line_number":10,"context_line":"in test-requirements.txt"},{"line_number":11,"context_line":"2. move all usages from distutils commands"},{"line_number":12,"context_line":"to the appropriate setuptools equivalent, according to"},{"line_number":13,"context_line":"these sources:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"daf05e63_ad2ca8dc","line":10,"in_reply_to":"31a5f570_7f186536","updated":"2024-07-29 08:42:20.000000000","message":"Yes, requirements.txt would be more correct, however I never contributed to pbr in the past, and there is currently no requirements.txt so I was not sure if this would be a welcome change to add this file.\n\nI can of course rework it, if we all agree on it.\n\nThanks for the feedback.","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e904cfea89675b96816063e4b277ff97e562f1b5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add python 3.12 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. correctly add the setuptools dependency"},{"line_number":10,"context_line":"in test-requirements.txt"},{"line_number":11,"context_line":"2. move all usages from distutils commands"},{"line_number":12,"context_line":"to the appropriate setuptools equivalent, according to"},{"line_number":13,"context_line":"these sources:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba644505_b9c57924","line":10,"in_reply_to":"daf05e63_ad2ca8dc","updated":"2024-11-18 21:03:06.000000000","message":"PBR intentionally avoids external dependencies. I think the reason for this is that PBR is a setup requires and I\u0027m not sure if those are handles recursively? In any case the whole pyproject.toml system negates the need for figuring that out we just have to list setuptools and pbr there.","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2a4f8919d999e05ce5909b1647201109ef4510e0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add python 3.12 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. correctly add the setuptools dependency"},{"line_number":10,"context_line":"in test-requirements.txt"},{"line_number":11,"context_line":"2. move all usages from distutils commands"},{"line_number":12,"context_line":"to the appropriate setuptools equivalent, according to"},{"line_number":13,"context_line":"these sources:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31a5f570_7f186536","line":10,"in_reply_to":"ec985168_7aeb0910","updated":"2024-07-18 18:53:02.000000000","message":"In light of that, shouldn\u0027t it get added to `requirements.txt` rather than `test-requirements.txt`? Even with this patch, installing in a fresh py312 venv leaves me with a busted install:\n```\n$ pbr -h\nTraceback (most recent call last):\n  File \"/home/tburke/_/bin/pbr\", line 5, in \u003cmodule\u003e\n    from pbr.cmd.main import main\n  File \"/home/tburke/_/lib/python3.12/site-packages/pbr/cmd/main.py\", line 20, in \u003cmodule\u003e\n    import pkg_resources\nModuleNotFoundError: No module named \u0027pkg_resources\u0027\n```","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"687300618549edf699cc24b041cdc248abc78a63","unresolved":true,"context_lines":[{"line_number":17,"context_line":"3. move logging to python std logging lib"},{"line_number":18,"context_line":"4. replace distutils.command.install in packaging.py with the setuptools"},{"line_number":19,"context_line":"equivalent, it\u0027s only used to run a command and should work(TM)"},{"line_number":20,"context_line":"5. replace usage of distutils.cmd with setuptools Command"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3f4e9f95d10dbbba8499ac4354ff2bf402befd12"},{"line_number":23,"context_line":"Signed-off-by: Sven Kieske \u003ckieske@osism.tech\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31c16887_9c980311","line":20,"updated":"2024-07-18 16:45:27.000000000","message":"These last three changes are due to similar reasons to item 2? Basically we\u0027re updating from distutils paths to setuptools for future proofing?","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ffae1b4384d5bc3cc82f2e233b594888f76a2a9","unresolved":true,"context_lines":[{"line_number":17,"context_line":"3. move logging to python std logging lib"},{"line_number":18,"context_line":"4. replace distutils.command.install in packaging.py with the setuptools"},{"line_number":19,"context_line":"equivalent, it\u0027s only used to run a command and should work(TM)"},{"line_number":20,"context_line":"5. replace usage of distutils.cmd with setuptools Command"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3f4e9f95d10dbbba8499ac4354ff2bf402befd12"},{"line_number":23,"context_line":"Signed-off-by: Sven Kieske \u003ckieske@osism.tech\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d0bbdd4d_e2133b3d","line":20,"in_reply_to":"31c16887_9c980311","updated":"2024-07-29 08:42:20.000000000","message":"yes, that\u0027s correct.","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Artem Goncharov \u003cartem.goncharov@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-22 09:12:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add python 3.12 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. correctly add the setuptools dependency"},{"line_number":10,"context_line":"in test-requirements.txt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dea6f097_7d280545","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"updated":"2024-12-17 18:55:27.000000000","message":"This commit message title creates too much confusion and I think ti should be changed. PBR works fine with python3.12. You just have to preinstall setuptools one way or another. Can we update the commit message to try and avoid perpetuating the confusion?","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0abb43d869c2d9a006046d019e5b01bdfad6f4eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf9fe623_1bc01802","updated":"2024-11-18 08:48:16.000000000","message":"recheck outdated logs","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ffae1b4384d5bc3cc82f2e233b594888f76a2a9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d39940b5_391b6b5b","updated":"2024-07-29 08:42:20.000000000","message":"thanks for the feedback, if we agree to add a requirements.txt file I can make the necessary changes to also support older python versions (Thanks Clark for the hint)!\n\nShould I only add a barebones requirements.txt with setuptools in it, or should some requirements move over from the `test-requirements.txt`?","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba68b3ed_749b20a7","updated":"2024-12-17 18:55:27.000000000","message":"I think it might be a good idea to break this change up into a couple of more easily bisectable and reviewable changes.\n\nThe first one I would do is add setuptools as a doc/requirements.txt and test-requirements.txt dependency so that doc builds and unittest run on python3.12 for pbr itself.\n\nNext I would replace distutils with setuptools equivalents to avoid the old deprecated code paths that are now vendored within setuptools.\n\nFinally I would have a change that figures out adding setuptools as a dependency to PBR so that using PBR on python3.12 or newer just works.\n\nI would do things in this order because I expect that the last change is the most likely one to have unexpected external interactions. Splitting things up also helps make it a bit more clear what works and what doesn\u0027t over time etc. As si there is a lot of confusion by bundling this all up into one change.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fb6f3f910c42f506a4241fe1433928f882f1c472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ea2ef625_bec6b455","updated":"2024-11-25 21:48:49.000000000","message":"So AIUI; the reason we\u0027ve worked to keep python 2.7 support in PBR is less because some software may need it (I\u0027ll note: there are many non-c-python runners that are still supported with a 2.7 API, though) -- and more because installer tools can\u0027t be versioned with a requirements.txt -- so the first release we make of pbr that doesn\u0027t support python 2.7 breaks *any attempt* to install *even an older* release of something on python 2.7.\n\nI do not have strong feelings on this policy, but thought it was worth explaining before we went down a rabbithole talking about something that may well be irrelevant.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c288cd289f973ba7e2d664c791c252d1a51d7772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"206c5444_a395fead","updated":"2024-11-26 10:39:20.000000000","message":"looking at the unit test failures for py27 and py35, these seem to be minor issues to me, nothing that would necessarily require dropping support completely.\n\nthe more relevant issue seem to be the integration tests, which would need fixing anyway. maybe splitting up these 7 changes into smaller patches would help with getting the CI to pass for each of them, I don\u0027t see that they need all to be combined into a single patch","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6a8de3b9f4702ef0a01b7a57715f59bfd1e8f7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eb05dc9b_5dc2df08","updated":"2024-11-25 08:57:22.000000000","message":"naive question: why is this still tested against python 2.7? python 2.7 is EOL for ages. Does pbr really still \"support\" python 2.7 on the master branch? Can that test maybe get removed?\n\nI\u0027m probably missing something, but I would be interested to learn why python 2.7 support is necessary here, thanks.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd1ded76_72d59408","in_reply_to":"1d7acb95_4713b9da","updated":"2024-12-17 18:55:27.000000000","message":"JayF is correct with:\n\n\u003e because installer tools can\u0027t be versioned with a requirements.txt -- so the first release we make of pbr that doesn\u0027t support python 2.7 breaks any attempt to install even an older release of something on python 2.7.\n\nTo install a python project under python2.7 you configure setuptools to use PBR as a setup_requires. Setup_requires are dependencies of the build/install process itself and not the runtime of the installed software. These dependencies are installed via easy_install (the pre pip installer tool) which does not understand python requirements in the pypi index and it doesn\u0027t do any version resolution. Instead it will do its best to install the very latest PBR version.\n\nWhat this means is that as soon as PBR makes a release without python2.7 support we\u0027re effectively going to break every python2.7 install that depends on PBR. Since swift in particular has recently released with python2.7 we would potentially be breaking swift users.\n\nNow there are options available to us. We could make PBR2 (or maybe PBR3 is more appropraite) and create a new package that doesn\u0027t support python2 and leave that to die on the pypi vine. But historically it hasn\u0027t been too terrible to continue to support python2.7 in PBR so my inclination would be to keep it until we feel sufficient time has passed since the last release of something with python2 support to break them.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ee90bc4_e2b3caa8","in_reply_to":"206c5444_a395fead","updated":"2024-12-17 18:55:27.000000000","message":"We\u0027ve been fine with dropping integration testing for older pythons and just rely on unittesting to ensure we don\u0027t break them too badly. So far that seems to have worked fine.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3333c6764859f6fd6c1a97391065ba5762bffe91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7ea112f8_89a29882","in_reply_to":"5718826a_9da8e61d","updated":"2024-11-25 10:01:27.000000000","message":"That\u0027s funny, because swift e.g. relies on oslo.config \u003e\u003d 4.0.0 which actually did support python 2.7 back in the pike days (way before my openstack time).\nThen again, I don\u0027t think there is any supported olso.config version around, which does support python 2.7, is there?\n\nThe oldest branch for oslo.config I can find is unmaintained/victoria, which does not support python 2:\n\nhttps://opendev.org/openstack/oslo.config/src/branch/unmaintained/victoria/setup.cfg\n\nSo in the event of any bugs happening somewhere there I doubt they would get fixed?\nSo I don\u0027t really see what is the point in keeping this, but maybe someone can explain this to me?\n\nIt was a community goal to remove python 2.7 with swift mentioned as an exception:\n\nhttps://governance.openstack.org/tc/goals/completed/ussuri/drop-py27.html\n\nswift needed to fix some py3 tests, but I take it this has been done?\nIt\u0027s also stated that they wanted \"to support xenial\" which is out of standard support since April 2021, according to https://ubuntu.com/about/release-cycle#ubuntu\nwhich means you need an ubuntu pro licence to receive support.\n\nSo I\u0027m wondering if the world maybe can move on? :)","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bd7cd7371cd2d7f48e740e958daaee2edc26626e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d7acb95_4713b9da","in_reply_to":"7ea112f8_89a29882","updated":"2024-11-26 02:52:24.000000000","message":"When we dropped the python 2.7 we discussed and agree for swift to continue support 2.7[1] but that need to be work/install with the old olso or so (as newer oslo does not support py2.7). I remember that was the idea to support py2.7 for some more releases but it has been  more than 10 releases (~ 4 years).\n\nI agree with Sven that we should drop py2.7 from swift and from pbr.\n\nAdding Tim (swift PTL) if he has any strong opinion to continue supporting 2.7 \n\n[1] https://governance.openstack.org/tc/goals/completed/ussuri/drop-py27.html#projects-keeping-py2-7-support","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0409e3ea3a40b0ea3ba3cac24bdaa841fa93e93c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bdbc3462_4f1b3e58","in_reply_to":"ba68b3ed_749b20a7","updated":"2024-12-19 00:45:58.000000000","message":"\u003e I think it might be a good idea to break this change up into a couple of more easily bisectable and reviewable changes.\n\u003e \n\u003e The first one I would do is add setuptools as a doc/requirements.txt and test-requirements.txt dependency so that doc builds and unittest run on python3.12 for pbr itself.\n\u003e \n\nI\u0027ve started trying to put this together in https://review.opendev.org/c/openstack/pbr/+/938030. Turns out there are a few more CI specific things that need updating so having a change dedicated to that makes even more sense to me now.\n\nBasically lets get the existing jobs running then worry about optimizing and removing deprecated paths.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a001505880a5507ac9e515b070367f52615219ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4acc3305_c691847d","in_reply_to":"bd1ded76_72d59408","updated":"2024-12-19 21:37:54.000000000","message":"\u003e Then again, I don\u0027t think there is any supported olso.config version around, which does support python 2.7, is there?\n\nYeah, trying to run anything on old, unsupported versions of Python invariably leads to being stuck on old, unsupported versions of *other* software.\n\nFWIW, Swift\u0027s position has always been, \"It sucks that you\u0027re stuck on old Python -- please, make a plan and upgrade as soon as you can -- about the only consolation we can offer is that at least _we_ won\u0027t be one of the packages you have to keep stuck in time.\"\n\nI think it\u0027s one of the reasons our stable branches see so little love -- our API boundary is well-enough defined and our coupling with other projects sufficiently loose that I\u0027m perfectly comfortable recommending that someone with a deployment from victoria (say) upgrade swift (and just swift) directly to master.\n\n\u003e Since swift in particular has recently released with python2.7 we would potentially be breaking swift users.\n\nNo deployers should be running py2 with modern Swift at this point. The last known one had an ability to flip back and forth between py2 and py3 -- we continued to maintain the handful of py2 gate jobs in case they needed to roll back. However, even they have gone py3-only. I expect to merge https://review.opendev.org/c/openstack/swift/+/853590 any day now.\n\nI don\u0027t think it\u0027ll even call for a release note; we [already declared that py2 would no longer be supported](https://opendev.org/openstack/swift/src/commit/ea06ed44940afb5352bc715d62dba1c742e2cd5e/CHANGELOG#L604). Since then, our expectation has been that deployers needing to run on py2 are on their own for getting the code installed, so it\u0027s on them to pin PBR in their build environment.\n\nSorry, I don\u0027t think I\u0027d appreciated how Swift continuing to test with py2 prevented PBR from moving on -- my assumption had been that it would be more similar to other dependencies. That easy_install business is unfortunate. Are there any similar gotchas I should be aware of for python\u003e3,\u003c\u003d3.8?","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"ccdb3ef30741f77765e51f49490e44bbbe6cc6a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5718826a_9da8e61d","in_reply_to":"eb05dc9b_5dc2df08","updated":"2024-11-25 08:59:55.000000000","message":"I would assume https://opendev.org/openstack/swift/src/branch/master/setup.cfg is the reason.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"}],"pbr/packaging.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e904cfea89675b96816063e4b277ff97e562f1b5","unresolved":true,"context_lines":[{"line_number":55,"context_line":"from pbr import testr_command"},{"line_number":56,"context_line":"from pbr import version"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"REQUIREMENTS_FILES \u003d (\u0027requirements.txt\u0027, \u0027tools/pip-requires\u0027)"},{"line_number":61,"context_line":"PY_REQUIREMENTS_FILES \u003d [x % sys.version_info[0] for x in ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ab8ea6f4_96df4710","line":58,"updated":"2024-11-18 21:03:06.000000000","message":"Based on the testing output lacking messages like those generated by `log.info(\"[pbr] Extracting deb version\")` I\u0027m guessing that this log setup isn\u0027t sufficient? Maybe the level is too low?","commit_id":"a3bddb03b5fe13598af5b0e52287a3ba4a63c131"}],"setup.cfg":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c288cd289f973ba7e2d664c791c252d1a51d7772","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    Programming Language :: Python :: 3.8"},{"line_number":29,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":30,"context_line":"    Programming Language :: Python :: 3.10"},{"line_number":31,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[options]"},{"line_number":34,"context_line":"python_requires \u003d \u003e\u003d2.6"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"54c287ff_f8b0d8d8","line":31,"updated":"2024-11-26 10:39:20.000000000","message":"nit: add 3.12 here, too?","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c288cd289f973ba7e2d664c791c252d1a51d7772","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[options]"},{"line_number":34,"context_line":"python_requires \u003d \u003e\u003d2.6"},{"line_number":35,"context_line":"install_requires \u003d"},{"line_number":36,"context_line":"    setuptools"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"abc0852b_41085240","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":23},"updated":"2024-11-26 10:39:20.000000000","message":"should this be 2.7?","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a001505880a5507ac9e515b070367f52615219ba","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[options]"},{"line_number":34,"context_line":"python_requires \u003d \u003e\u003d2.6"},{"line_number":35,"context_line":"install_requires \u003d"},{"line_number":36,"context_line":"    setuptools"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"26261ef5_c0279bf9","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":23},"in_reply_to":"89a33e6b_5002cff3","updated":"2024-12-19 21:37:54.000000000","message":"I think it\u0027s still worth having an accurate `python_requires`. `pip` respects it back to 9.0.0, well before py2 support was dropped in 21.0, for example. Looking at some old notes of mine, Ubuntu bionic, CentOS 7, and CentOS 8 Stream were all on that 9.0.x train; that\u0027s a decent set of old-but-not-*so*-old distros that would see some benefit. Certainly we\u0027d want it to be accurate if/when we drop old py3 versions.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[options]"},{"line_number":34,"context_line":"python_requires \u003d \u003e\u003d2.6"},{"line_number":35,"context_line":"install_requires \u003d"},{"line_number":36,"context_line":"    setuptools"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"89a33e6b_5002cff3","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":23},"in_reply_to":"abc0852b_41085240","updated":"2024-12-17 18:55:27.000000000","message":"At this point I think it can be 2.7. However, it doesn\u0027t really matter because the tools that understand python_requires are all much newer than either version of python. So this is effectively ignored where you would want it to be used.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26b4fd130c877c5b2a160e6fe60f045051f2a425","unresolved":true,"context_lines":[{"line_number":33,"context_line":"[options]"},{"line_number":34,"context_line":"python_requires \u003d \u003e\u003d2.6"},{"line_number":35,"context_line":"install_requires \u003d"},{"line_number":36,"context_line":"    setuptools"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[files]"},{"line_number":39,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"9a6303dd_1c0e7149","line":36,"updated":"2024-12-17 18:55:27.000000000","message":"Do we know how this interacts with using pyproject.toml [build-system]\\nrequires? For example will this override and install latest setuptoosl if you have pinned to an older version?","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"}],"test-requirements.txt":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"687300618549edf699cc24b041cdc248abc78a63","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools\u003e\u003d64.0.0 # MIT"},{"line_number":6,"context_line":"wheel\u003e\u003d0.32.0 # MIT"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"hacking\u003e\u003d1.1.0,\u003c4.0.0;python_version\u003e\u003d\u00273.6\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"273cd99a_83eb09a6","line":5,"updated":"2024-07-18 16:45:27.000000000","message":"Setuptools 64 is python 3.7 only or newer. This is why CI is failing. We can\u0027t stop supporting older python versions due to the amount of software out there still relying on pbr on those platforms. You can add setuptools here you just need to avoid using the version limits. Then pip will install a setuptools versions appropriate for the current platform.","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ffae1b4384d5bc3cc82f2e233b594888f76a2a9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools\u003e\u003d64.0.0 # MIT"},{"line_number":6,"context_line":"wheel\u003e\u003d0.32.0 # MIT"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"hacking\u003e\u003d1.1.0,\u003c4.0.0;python_version\u003e\u003d\u00273.6\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"503e7609_a2ee12d0","line":5,"in_reply_to":"273cd99a_83eb09a6","updated":"2024-07-29 08:42:20.000000000","message":"thanks for the hint, I was not aware of which older versions are needed for older python versions.","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e904cfea89675b96816063e4b277ff97e562f1b5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools\u003e\u003d64.0.0 # MIT"},{"line_number":6,"context_line":"wheel\u003e\u003d0.32.0 # MIT"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"hacking\u003e\u003d1.1.0,\u003c4.0.0;python_version\u003e\u003d\u00273.6\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"de04ceda_63386069","line":5,"in_reply_to":"503e7609_a2ee12d0","updated":"2024-11-18 21:03:06.000000000","message":"Done","commit_id":"8208a38e062fb4b28459aee16feffdcbd904a509"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a001505880a5507ac9e515b070367f52615219ba","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools # MIT"},{"line_number":6,"context_line":"wheel\u003e\u003d0.32.0 # MIT"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"hacking\u003e\u003d1.1.0,\u003c4.0.0;python_version\u003e\u003d\u00273.6\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":8,"id":"a23b1aa2_4bc2da53","line":5,"updated":"2024-12-19 21:37:54.000000000","message":"Do we not install pbr to run tests? I would have thought the `install_requires` in `setup.cfg` would have been sufficient.","commit_id":"f0f06e605bbd2b7355243f1fa846cf8b13e51481"}]}