)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ef7e4bc5a74c3b01a78b25bd5a477f22d2d75afe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc8c196a_c45443be","updated":"2025-07-03 14:20:17.000000000","message":"Auto-formatting can be contentious, so I\u0027ll just note that (a) this makes my life signficantly easier as I shuffle things about, (b) we can and will ignore this from git-blame using a git-blame-ignore-revs file, as soon as this merges, and (c) we don\u0027t backport stuff in pbr often and if we did we could backport this patch also","commit_id":"40c797e3681645f44aff7954b7f5604f734cf22a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43f17be1cc18dfa38bfd16ceccb2572141a7d285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df644ce7_4b2dcd27","updated":"2025-07-04 20:50:17.000000000","message":"I verified that applying black locally with the parameters from pyproject.toml gives the same result, so the change looks fine to me. we\u0027re using black in downstream repos, too, so I think it is a reasonable choice. getting work done in the code base is much more important than discussing stylistic details\n\nminor comment below, but not a blocker and likely also not worth rebasing the whole stack once again at this point","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"f4ecc4185d92688be16eff2625320c3689a87f61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a74a0077_12cbb56f","updated":"2025-07-07 19:16:19.000000000","message":"This is mostly great. But let\u0027s clean up a quoting silly. Probably as a followup would be fine.","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"}],"pbr/sphinxext.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"f4ecc4185d92688be16eff2625320c3689a87f61","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        path \u003d _find_setup_cfg(srcdir)"},{"line_number":66,"context_line":"        if not path or not parser.read(path):"},{"line_number":67,"context_line":"            logger.info("},{"line_number":68,"context_line":"                \u0027Could not find a setup.cfg to extract project name \u0027 \u0027from\u0027"},{"line_number":69,"context_line":"            )"},{"line_number":70,"context_line":"            return None"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"41d0d56a_25e64bde","line":68,"updated":"2025-07-07 19:16:19.000000000","message":"If we\u0027re going to collapse this onto a single line - we can collapse \u0027 \u0027from\u0027 to just from\u0027","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"526efed4a4cd319ec6db630fcd4e24743894e277","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        path \u003d _find_setup_cfg(srcdir)"},{"line_number":66,"context_line":"        if not path or not parser.read(path):"},{"line_number":67,"context_line":"            logger.info("},{"line_number":68,"context_line":"                \u0027Could not find a setup.cfg to extract project name \u0027 \u0027from\u0027"},{"line_number":69,"context_line":"            )"},{"line_number":70,"context_line":"            return None"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e8da8ebb_02a9000d","line":68,"in_reply_to":"41d0d56a_25e64bde","updated":"2025-07-08 16:32:54.000000000","message":"yeah, that\u0027s an issue that black has and ruff doesn\u0027t. easily fixed in a follow-up.","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd1b65384fc8f56d67b2e07878308d14dabc2883","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        path \u003d _find_setup_cfg(srcdir)"},{"line_number":66,"context_line":"        if not path or not parser.read(path):"},{"line_number":67,"context_line":"            logger.info("},{"line_number":68,"context_line":"                \u0027Could not find a setup.cfg to extract project name \u0027 \u0027from\u0027"},{"line_number":69,"context_line":"            )"},{"line_number":70,"context_line":"            return None"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6ecd33ef_4561256c","line":68,"in_reply_to":"e8da8ebb_02a9000d","updated":"2025-07-09 12:59:35.000000000","message":"Done (in follow-up)","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"}],"tox.ini":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43f17be1cc18dfa38bfd16ceccb2572141a7d285","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[flake8]"},{"line_number":73,"context_line":"# E203 (conflicts with black)"},{"line_number":74,"context_line":"# E501 (conflicts with black)"},{"line_number":75,"context_line":"# W503 (you have to choose this or W504)"},{"line_number":76,"context_line":"# H216 (we use mock for python2.7 compatibility)"},{"line_number":77,"context_line":"ignore \u003d E203,E501,W503,H216"},{"line_number":78,"context_line":"exclude \u003d .venv,.tox,dist,doc,*.egg,build"}],"source_content_type":"text/x-properties","patch_set":2,"id":"800dc45e_6d3a5a66","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":40},"updated":"2025-07-04 20:50:17.000000000","message":"W503 also conflicts with black, so this isn\u0027t a free choice, I\u0027d rather word this in one, like:\n```suggestion\n# E203,E501,W503 (conflicts with black)\n```","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd1b65384fc8f56d67b2e07878308d14dabc2883","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[flake8]"},{"line_number":73,"context_line":"# E203 (conflicts with black)"},{"line_number":74,"context_line":"# E501 (conflicts with black)"},{"line_number":75,"context_line":"# W503 (you have to choose this or W504)"},{"line_number":76,"context_line":"# H216 (we use mock for python2.7 compatibility)"},{"line_number":77,"context_line":"ignore \u003d E203,E501,W503,H216"},{"line_number":78,"context_line":"exclude \u003d .venv,.tox,dist,doc,*.egg,build"}],"source_content_type":"text/x-properties","patch_set":2,"id":"52e60eb2_d77e8130","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":40},"in_reply_to":"800dc45e_6d3a5a66","updated":"2025-07-09 12:59:35.000000000","message":"Done (in follow-up)","commit_id":"28988fda7564b2939e844fc3fbadb052e03a2106"}]}
