)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"05048f81d6960fb894cb23ef65cdc0f98bf5bcca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"will remove the framework needed for these commands entirely from their"},{"line_number":12,"context_line":"vendored version of distutils. Prepare for this future by moving them"},{"line_number":13,"context_line":"into the \u0027_compat\u0027 module, where we will have the ability to keep using"},{"line_number":14,"context_line":"them for older Python/setuptools versions while using newer (PEP-417)"},{"line_number":15,"context_line":"mechanisms elsewhere. There should be zero impact at runtime for now."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"More tests need to be moved around. This will be done separately."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fc1ea1cd_d91be287","line":14,"range":{"start_line":14,"start_character":65,"end_line":14,"end_character":68},"updated":"2025-07-09 17:59:35.000000000","message":"517","commit_id":"d07df2ca72798c7d64be109d61ae7d68ad3c525a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"58ae920f0832a9a06d9b7f15db75b0a6ad3e7251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf792e9c_cc8cd56b","updated":"2025-07-08 22:42:12.000000000","message":"Not +2\u0027ing because I haven\u0027t been able to give this change a proper review. But I want to post my inline comment. I feel like this change is important to the expected future shape of pbr and its late enough in the day and deep enough in this review stack that I worry I can\u0027t give it the attention it deserves yet.","commit_id":"1298b81b9a027c98e8760cb140a58bbf997a5f08"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"22c84a35f91bcdd7b889096ea5bbd4613eb0e590","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cca20f9f_d40a17b6","updated":"2025-08-01 15:52:06.000000000","message":"Using running vimdiff locally against the pbr/_compat/commands.py diff and the pbr/packaging.py diff for this change (diff of diffs) I can see that the code simply moves from one location to another without any substantive changes. Then the rest of the change is largely about referring to things in the new location.","commit_id":"589076ba35e60ba9cb5b756c3201a8c47f85b5c0"}],"pbr/_compat/commands.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"58ae920f0832a9a06d9b7f15db75b0a6ad3e7251","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from setuptools.command import egg_info"},{"line_number":28,"context_line":"from setuptools.command import install"},{"line_number":29,"context_line":"from setuptools.command import install_scripts"},{"line_number":30,"context_line":"from setuptools.command import sdist"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from pbr import extra_files"},{"line_number":33,"context_line":"from pbr import git"}],"source_content_type":"text/x-python","patch_set":5,"id":"c48477ed_4c6128e3","line":30,"updated":"2025-07-08 22:42:12.000000000","message":"The commit message indicates that these commands at distutils commands but here they are served by setuptools. I wouldn\u0027t be surprised if setuptools is just proxying the commands to distutils though. That said its setuptools that is slowly removing their functionality to force you to use pep517 and tools like build or whatever.\n\nI bring this up because this is the first change in the refactoring stack where there isn\u0027t clear indication of what the expected final state is going to be. I don\u0027t think that is necessarily a problem of the code though, but may be worth trying to capture that in the commit message a bit more if new patchsets happen?","commit_id":"1298b81b9a027c98e8760cb140a58bbf997a5f08"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4e2760e0f041446e41534314e787f7b12c9bf40f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from setuptools.command import egg_info"},{"line_number":28,"context_line":"from setuptools.command import install"},{"line_number":29,"context_line":"from setuptools.command import install_scripts"},{"line_number":30,"context_line":"from setuptools.command import sdist"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from pbr import extra_files"},{"line_number":33,"context_line":"from pbr import git"}],"source_content_type":"text/x-python","patch_set":5,"id":"e954d563_d1820e9d","line":30,"in_reply_to":"c48477ed_4c6128e3","updated":"2025-07-09 12:18:37.000000000","message":"Makes sense. fwiw, the end state here is that the distutils commands continue to exist, but nothing outside `_compat` will call the code and it will eventually be ignored once setuptools removes support for distutils keywords and commands. We will have a pyproject.toml extension (`[tool.pbr]`) that most/all projects should move across to.","commit_id":"1298b81b9a027c98e8760cb140a58bbf997a5f08"}]}