)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a02d4f9e7d8e2060293ba4b083520fb7fefc9a5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68a559b2_36d3d826","updated":"2025-10-23 17:55:06.000000000","message":"-1 for the unnecessary diff within the change. I think that will make maintaining vendored code more difficult over time.","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"261f35053829909460297b68d9eb60c72389f829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b93fa50_0c63d1c2","updated":"2025-10-28 18:12:31.000000000","message":"recheck test jobs shoudl be fixed now","commit_id":"e42e0ae2bf91f8a2d9d03ac79778464af5a2f037"}],"pbr/_compat/easy_install.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"253cc37bf8c420c8b85940587649646c66d10e06","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        return sys.platform !\u003d \u0027win32\u0027 or find_executable(clean_header)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @classmethod"},{"line_number":449,"context_line":"    def get_args(cls, dist, header\u003dNone):"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        Yield write_script() argument tuples for a distribution\u0027s"},{"line_number":452,"context_line":"        console_scripts and gui_scripts entry points."}],"source_content_type":"text/x-python","patch_set":2,"id":"71f491ef_4f106403","line":449,"updated":"2025-09-10 09:28:33.000000000","message":"I did not understand why the `WindowScriptWriter` class deserve a specific `get_args` class method. Especially since this patch modify the original implementation of the `get_args` class method of the `ScriptWriter` class and this override correspond to the original code.\n\nEither the commit message should to be more explicit about the nature of these changes, or the docstring should explain why this is required.","commit_id":"97f6055f2d5b7872c4b2731d76ab8676184d180d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32f5403aa892d3c7033ca4a5b35b9b8d33a02d45","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return sys.platform !\u003d \u0027win32\u0027 or find_executable(clean_header)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @classmethod"},{"line_number":449,"context_line":"    def get_args(cls, dist, header\u003dNone):"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        Yield write_script() argument tuples for a distribution\u0027s"},{"line_number":452,"context_line":"        console_scripts and gui_scripts entry points."}],"source_content_type":"text/x-python","patch_set":2,"id":"31ec9964_dcfc3378","line":449,"in_reply_to":"002d2ae3_b65c6d93","updated":"2025-10-23 10:37:46.000000000","message":"Done","commit_id":"97f6055f2d5b7872c4b2731d76ab8676184d180d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94af0e43e4f850415b5fb2b1287acaa1d3e774d1","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        return sys.platform !\u003d \u0027win32\u0027 or find_executable(clean_header)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @classmethod"},{"line_number":449,"context_line":"    def get_args(cls, dist, header\u003dNone):"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        Yield write_script() argument tuples for a distribution\u0027s"},{"line_number":452,"context_line":"        console_scripts and gui_scripts entry points."}],"source_content_type":"text/x-python","patch_set":2,"id":"002d2ae3_b65c6d93","line":449,"in_reply_to":"71f491ef_4f106403","updated":"2025-09-10 09:54:26.000000000","message":"I don\u0027t either, I\u0027m afraid. I\u0027m just keeping this *exactly* as it was before. My **guess** is that `wsgi_scripts` doesn\u0027t make sense on Windows, so we\u0027re skipping that, but this code is ancient and predates my work on OpenStack.","commit_id":"97f6055f2d5b7872c4b2731d76ab8676184d180d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a02d4f9e7d8e2060293ba4b083520fb7fefc9a5a","unresolved":true,"context_lines":[{"line_number":184,"context_line":"    split_args \u003d dict(posix\u003dFalse)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"_wsgi_text \u003d \"\"\"#PBR Generated from %(group)r"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"import threading"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"36c5db53_7bdfd9fc","line":187,"updated":"2025-10-23 17:55:06.000000000","message":"May be worth annotating this content that originates from PBR as not being from the upstream vendored code?","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fd04948d6695fe5b0f7194233db177946571adb","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    split_args \u003d dict(posix\u003dFalse)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"_wsgi_text \u003d \"\"\"#PBR Generated from %(group)r"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"import threading"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fce2f3ad_2f3e17da","line":187,"in_reply_to":"36c5db53_7bdfd9fc","updated":"2025-10-24 10:22:41.000000000","message":"Done","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a02d4f9e7d8e2060293ba4b083520fb7fefc9a5a","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    gui apps."},{"line_number":290,"context_line":"    \"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    command_spec_class \u003d CommandSpec"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @classmethod"},{"line_number":295,"context_line":"    def get_script_args(cls, dist, executable\u003dNone, wininst\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"6dfad7b9_64d6771b","line":292,"updated":"2025-10-23 17:55:06.000000000","message":"Since this is vendored code I don\u0027t think we should be reordering the methods and attributes in this class. It will just make the understanding of the origin of the code and how it differs from upstream more difficult.","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"73f2598acec2fa6fad312e8e234dd244b7b136c9","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    gui apps."},{"line_number":290,"context_line":"    \"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    command_spec_class \u003d CommandSpec"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @classmethod"},{"line_number":295,"context_line":"    def get_script_args(cls, dist, executable\u003dNone, wininst\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce93c8c5_c9790dd1","line":292,"in_reply_to":"6dfad7b9_64d6771b","updated":"2025-10-24 10:13:41.000000000","message":"I don\u0027t believe I\u0027ve reordered anything? The order of methods are the same:\n\n- `get_script_args`\n- `get_script_header`\n- `get_args`\n- `_ensure_safe_name`\n- `best`\n- `_get_script_args`\n- `get_header`\n\nWhat I\u0027ve done is changed the contents on the methods, since I\u0027m inlining our overridden versions. I\u0027ve also added the original `get_args` definition to `WindowsScriptWriter` since we didn\u0027t override that.\n\nThis is just git deciding these things have been moved, rather than updated and new methods added to `WindowsScriptWriter`. Let me try reworking this to see if I can make the diff easier to spot.","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fd04948d6695fe5b0f7194233db177946571adb","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    gui apps."},{"line_number":290,"context_line":"    \"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    command_spec_class \u003d CommandSpec"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @classmethod"},{"line_number":295,"context_line":"    def get_script_args(cls, dist, executable\u003dNone, wininst\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fafcc635_757483f9","line":292,"in_reply_to":"ce93c8c5_c9790dd1","updated":"2025-10-24 10:22:41.000000000","message":"Done","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a02d4f9e7d8e2060293ba4b083520fb7fefc9a5a","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        return sys.platform !\u003d \u0027win32\u0027 or find_executable(clean_header)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @classmethod"},{"line_number":449,"context_line":"    def get_args(cls, dist, header\u003dNone):"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        Yield write_script() argument tuples for a distribution\u0027s"},{"line_number":452,"context_line":"        console_scripts and gui_scripts entry points."}],"source_content_type":"text/x-python","patch_set":3,"id":"711dfebe_0d5b1ad9","line":449,"updated":"2025-10-23 17:55:06.000000000","message":"See above.","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fd04948d6695fe5b0f7194233db177946571adb","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return sys.platform !\u003d \u0027win32\u0027 or find_executable(clean_header)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @classmethod"},{"line_number":449,"context_line":"    def get_args(cls, dist, header\u003dNone):"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        Yield write_script() argument tuples for a distribution\u0027s"},{"line_number":452,"context_line":"        console_scripts and gui_scripts entry points."}],"source_content_type":"text/x-python","patch_set":3,"id":"a39929e2_34dc4592","line":449,"in_reply_to":"711dfebe_0d5b1ad9","updated":"2025-10-24 10:22:41.000000000","message":"Ah, so yeah, this should have been above `best`. Will fix.","commit_id":"f3e7b026888c919f57d99b093e8914311d6b0b35"}]}