)]}'
{"placement/db/sqlalchemy/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d18daf0214734ce476eed30111c83024338204a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f79a3b5_afca149e","updated":"2018-09-03 12:49:51.000000000","message":"I think this renames makes the code more complicated to trace back to its origins. I know that this is automatic and scripted but somehow this change in this file feels unnnecessary.","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f79a3b5_80e02999","in_reply_to":"3f79a3b5_afca149e","updated":"2018-09-04 21:31:21.000000000","message":"Yeah, I agree this is another commit that would have felt more appropriate at a different place in the series, after more of the nova-isms had been cleaned out. But I get the strategy, which is \"do a bunch of stuff automatically and then go clean up by hand afterward\". As long as the end result is copacetic - and we have the whole series by which we can validate that - I guess weirdnesses like this on the individual steps are to be expected/accepted.","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"}],"placement/db/sqlalchemy/api_migrations/migrate_repo/versions/030_require_cell_setup.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d18daf0214734ce476eed30111c83024338204a5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from placement import exception"},{"line_number":17,"context_line":"from nova.i18n import _"},{"line_number":18,"context_line":"from placement import objects"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_cfcd10b8","line":18,"updated":"2018-09-03 12:49:51.000000000","message":"nova.objects are not the same as placement.objects so it feels to me it complicate things.","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from placement import exception"},{"line_number":17,"context_line":"from nova.i18n import _"},{"line_number":18,"context_line":"from placement import objects"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_33372db3","line":18,"in_reply_to":"3f79a3b5_cfcd10b8","updated":"2018-09-04 21:31:21.000000000","message":"IMO this whole file needs to go away. In what way could it ever make sense in a placement context?","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"}],"placement/db/sqlalchemy/migration.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from placement import db_api as placement_db"},{"line_number":28,"context_line":"from nova.db.sqlalchemy import api as db_session"},{"line_number":29,"context_line":"from placement import exception"},{"line_number":30,"context_line":"from nova.i18n import _"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"INIT_VERSION \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f35535c3","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":31},"updated":"2018-09-04 21:31:21.000000000","message":"This doesn\u0027t make any sense without replacing NovaException on L55 and L87.","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"}],"placement/db/sqlalchemy/types.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_d3f599cc","updated":"2018-09-04 21:31:21.000000000","message":"nb: this file goes away later in the series.","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"}],"placement/db/sqlalchemy/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_93fba1bc","updated":"2018-09-04 21:31:21.000000000","message":"ditto.","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"}],"placement/test.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d18daf0214734ce476eed30111c83024338204a5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from placement import exception"},{"line_number":56,"context_line":"from nova.network import manager as network_manager"},{"line_number":57,"context_line":"from nova.network.security_group import openstack_driver"},{"line_number":58,"context_line":"from placement import objects"},{"line_number":59,"context_line":"from nova.objects import base as objects_base"},{"line_number":60,"context_line":"from nova.tests import fixtures as nova_fixtures"},{"line_number":61,"context_line":"from nova.tests.unit import conf_fixture"},{"line_number":62,"context_line":"from nova.tests.unit import policy_fixture"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2f5364e4","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":45},"updated":"2018-09-03 12:49:51.000000000","message":"This two lines are inconsistent. The original nova.objects has a relationship with nova.objects.base but we only renamed one of the imports here so we now hide that relationship.","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"}],"placement/tests/fixtures.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d18daf0214734ce476eed30111c83024338204a5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from nova.db.sqlalchemy import api as session"},{"line_number":50,"context_line":"from placement import exception"},{"line_number":51,"context_line":"from nova.network import model as network_model"},{"line_number":52,"context_line":"from placement import objects"},{"line_number":53,"context_line":"from nova.objects import base as obj_base"},{"line_number":54,"context_line":"from nova.objects import service as service_obj"},{"line_number":55,"context_line":"from placement import quota as nova_quota"},{"line_number":56,"context_line":"from placement import rpc"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4f4ee038","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":41},"updated":"2018-09-03 12:49:51.000000000","message":"ditto","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[{"line_number":52,"context_line":"from placement import objects"},{"line_number":53,"context_line":"from nova.objects import base as obj_base"},{"line_number":54,"context_line":"from nova.objects import service as service_obj"},{"line_number":55,"context_line":"from placement import quota as nova_quota"},{"line_number":56,"context_line":"from placement import rpc"},{"line_number":57,"context_line":"from placement import service"},{"line_number":58,"context_line":"from nova.tests.functional.api import client"},{"line_number":59,"context_line":"from nova.tests.functional.fixtures import placement"},{"line_number":60,"context_line":"from nova.tests import uuidsentinel"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_33bc0ddb","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":29},"updated":"2018-09-04 21:31:21.000000000","message":"bogus","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"}],"placement/tests/unit/__init__.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d18daf0214734ce476eed30111c83024338204a5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   :platform: Unix"},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from placement import objects"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(comstud): Make sure we have all of the objects loaded. We do this"},{"line_number":28,"context_line":"# at module import time, because we may be using mock decorators in our"},{"line_number":29,"context_line":"# tests that run at import time."},{"line_number":30,"context_line":"objects.register_all()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_af58d4f9","line":30,"range":{"start_line":25,"start_character":0,"end_line":30,"end_character":22},"updated":"2018-09-03 12:49:51.000000000","message":"We didn\u0027t have this behavior in the original placement side. So this change unnecessarily introduce new behavior. I think we should avoid introducing new behavior until we have passing tests.","commit_id":"9b50cf8639c815d165379947bc50a10bd97b44e6"}],"placement/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_d39fd94d","updated":"2018-09-04 21:31:21.000000000","message":"the vast majority of this file goes away later.","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from six.moves import reload_module"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"import nova.conf"},{"line_number":54,"context_line":"from placement import debugger"},{"line_number":55,"context_line":"from placement import exception"},{"line_number":56,"context_line":"from nova.i18n import _, _LE, _LI, _LW"},{"line_number":57,"context_line":"import nova.network"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b37d7d1d","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":30},"updated":"2018-09-04 21:31:21.000000000","message":"bogus","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cb392729e263c0fbfc59f05b4c26215b68e43ac","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from placement import exception"},{"line_number":56,"context_line":"from nova.i18n import _, _LE, _LI, _LW"},{"line_number":57,"context_line":"import nova.network"},{"line_number":58,"context_line":"from placement import safe_utils"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"profiler \u003d importutils.try_import(\u0027osprofiler.profiler\u0027)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_538f4929","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":32},"updated":"2018-09-04 21:31:21.000000000","message":"bogus","commit_id":"467c253349cf28fcb3ec2787efdf695b0bc163c6"}]}