)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Inspect and correct tox.ini, .stestr.conf and setup.cfg"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Begin the process of getting placement tests running, by getting the"},{"line_number":10,"context_line":"test harness opertional."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before we can expect the tests to be able to run the configuration for"},{"line_number":13,"context_line":"the placement package and its test harness needs to be adjusted for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_91707942","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":23},"updated":"2018-09-04 23:25:08.000000000","message":"operational","commit_id":"eaeeea1cfe43f93903a373faf107d19526fae1d4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Begin the process of getting placement tests running, by getting the"},{"line_number":10,"context_line":"test harness opertional."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before we can expect the tests to be able to run the configuration for"},{"line_number":13,"context_line":"the placement package and its test harness needs to be adjusted for"},{"line_number":14,"context_line":"\"nova\" -\u003e \"placement\". These changes are made by inspection and based"},{"line_number":15,"context_line":"on previous iterations of doing these kinds of cleanups, it won\u0027t be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_51942137","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":48},"updated":"2018-09-04 23:25:08.000000000","message":"A comma here would be lovely","commit_id":"eaeeea1cfe43f93903a373faf107d19526fae1d4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"test harness opertional."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before we can expect the tests to be able to run the configuration for"},{"line_number":13,"context_line":"the placement package and its test harness needs to be adjusted for"},{"line_number":14,"context_line":"\"nova\" -\u003e \"placement\". These changes are made by inspection and based"},{"line_number":15,"context_line":"on previous iterations of doing these kinds of cleanups, it won\u0027t be"},{"line_number":16,"context_line":"until later in this stack of change that actually passing tests will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_f1944d38","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":48},"updated":"2018-09-04 23:25:08.000000000","message":"need","commit_id":"eaeeea1cfe43f93903a373faf107d19526fae1d4"}],"setup.cfg":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    README.rst"},{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author-email \u003d openstack-dev@lists.openstack.org"},{"line_number":8,"context_line":"home-page \u003d https://docs.openstack.org/placement/latest/"},{"line_number":9,"context_line":"classifier \u003d"},{"line_number":10,"context_line":"    Environment :: OpenStack"},{"line_number":11,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"3f79a3b5_71c11d2f","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":56},"updated":"2018-09-04 23:25:08.000000000","message":"ENOENT (for now). That\u0027s okay by me, I guess, but makes me wonder if it\u0027s worth pre-fixing this elsewhere (e.g. [1], [2]) as well.\n\n[1] https://review.openstack.org/#/c/599864/1/doc/source/contributor/placement.rst@21\n[2] https://review.openstack.org/#/c/599864/1/doc/source/contributor/placement.rst@139","commit_id":"eaeeea1cfe43f93903a373faf107d19526fae1d4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b18c32aa82b3032e4ef2f4149a4e7ecc096780c2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    README.rst"},{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author-email \u003d openstack-dev@lists.openstack.org"},{"line_number":8,"context_line":"home-page \u003d https://docs.openstack.org/placement/latest/"},{"line_number":9,"context_line":"classifier \u003d"},{"line_number":10,"context_line":"    Environment :: OpenStack"},{"line_number":11,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"3f79a3b5_3c6855f2","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":56},"in_reply_to":"3f79a3b5_71c11d2f","updated":"2018-09-05 09:17:28.000000000","message":"It will come into being once we have working docs jobs.","commit_id":"eaeeea1cfe43f93903a373faf107d19526fae1d4"}],"tox.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":61,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":62,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":63,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":64,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:fast8]"},{"line_number":67,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_d1cd915d","side":"PARENT","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":118},"updated":"2018-09-04 23:25:08.000000000","message":"Why not?","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"72be0757d8fd6355be15616669a05e989c701fb6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":61,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":62,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":63,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":64,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:fast8]"},{"line_number":67,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_a8bdfcb1","side":"PARENT","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":118},"in_reply_to":"3f79a3b5_080af0cf","updated":"2018-09-05 14:42:07.000000000","message":"Those json files in nova are for api-samples and notification-samples, which I hope we never need to do in placement.\n\n\"futureproofing\" at this stage sounds like yagni to me","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b18c32aa82b3032e4ef2f4149a4e7ecc096780c2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":61,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":62,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":63,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":64,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:fast8]"},{"line_number":67,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_dc7841c2","side":"PARENT","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":118},"in_reply_to":"3f79a3b5_d1cd915d","updated":"2018-09-05 09:17:28.000000000","message":"Because we don\u0027t have any json files in doc/","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6f6355a94f3ce02b75c9e29c05014512e0635d4e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":61,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":62,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":63,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":64,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:fast8]"},{"line_number":67,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_080af0cf","side":"PARENT","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":118},"in_reply_to":"3f79a3b5_dc7841c2","updated":"2018-09-05 14:36:28.000000000","message":"hm, but will we never? (samples and such)\nseems like a not-unreasonable futureproofing.\n\nbut meh","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4f6f9330a23014bf9d8a5609c0ecf8684490da0f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":170,"context_line":"commands \u003d"},{"line_number":171,"context_line":"  rm -rf doc/build"},{"line_number":172,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":173,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":174,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":175,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":176,"context_line":"  sphinx-build -W -b html doc/source doc/build/html"},{"line_number":177,"context_line":"  # Test the redirects. This must run after the main docs build"},{"line_number":178,"context_line":"  whereto doc/build/html/.htaccess doc/test/redirect-tests.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_1101c96a","side":"PARENT","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":118},"updated":"2018-09-04 23:25:08.000000000","message":"ditto","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b18c32aa82b3032e4ef2f4149a4e7ecc096780c2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":170,"context_line":"commands \u003d"},{"line_number":171,"context_line":"  rm -rf doc/build"},{"line_number":172,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":173,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""},{"line_number":174,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":175,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":176,"context_line":"  sphinx-build -W -b html doc/source doc/build/html"},{"line_number":177,"context_line":"  # Test the redirects. This must run after the main docs build"},{"line_number":178,"context_line":"  whereto doc/build/html/.htaccess doc/test/redirect-tests.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3f79a3b5_7c4b2d86","side":"PARENT","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":118},"in_reply_to":"3f79a3b5_1101c96a","updated":"2018-09-05 09:17:28.000000000","message":"ditto","commit_id":"3100eb64ae198cabcf417f6e6dd785926392895e"}]}