)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03651e68a0a7534113ff7faece196de7a667b199","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Only creating the \u0027placement\u0027 database in the database fixture and"},{"line_number":12,"context_line":"  referring only to its engine"},{"line_number":13,"context_line":"* Disabling the 014_keypairs database migration which refers to"},{"line_number":14,"context_line":"  information in nova objects. Since keypairs are not used by the"},{"line_number":15,"context_line":"  placement database, we can ignore it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9b98ef9b619d43e7f6c692d08e9e901107cdfdb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_9deab971","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":39},"updated":"2018-09-05 18:39:21.000000000","message":"What does this have to do with the database fixture?","commit_id":"5fec97d9fb5a0291d48ab0e69ae70241319a772e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a34f487bd69bc5d3a7861944425409d14eac73","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Only creating the \u0027placement\u0027 database in the database fixture and"},{"line_number":12,"context_line":"  referring only to its engine"},{"line_number":13,"context_line":"* Disabling the 014_keypairs database migration which refers to"},{"line_number":14,"context_line":"  information in nova objects. Since keypairs are not used by the"},{"line_number":15,"context_line":"  placement database, we can ignore it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9b98ef9b619d43e7f6c692d08e9e901107cdfdb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_bd19b588","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":39},"in_reply_to":"3f79a3b5_9deab971","updated":"2018-09-05 18:46:28.000000000","message":"OK I think I get it now - the DatabaseFixture was changed so that \u0027placement\u0027 is the only engine and thus will run the schema migration on setup of the fixture, which will run the keypairs migration which will blow up with an ImportError because it has the nova.objects.keypairs code which isn\u0027t in this repo.","commit_id":"5fec97d9fb5a0291d48ab0e69ae70241319a772e"}],"placement/tests/fixtures.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"322154a29ecc0c00c77df24733edd5aacb6f9510","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def __init__(self, database\u003d\u0027placement\u0027, connection\u003dNone):"},{"line_number":537,"context_line":"        \"\"\"Create a database fixture."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        :param database: The type of database: \u0027placement\u0027"},{"line_number":540,"context_line":"        :param connection: The connection string to use"},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":"        super(Database, self).__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_df228ca3","line":539,"updated":"2018-09-04 13:38:09.000000000","message":"This param should be removed later on, as we only have one database.","commit_id":"5f6e0ef4a4590dbfb48d01f760570b561bbf031e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a34f487bd69bc5d3a7861944425409d14eac73","unresolved":false,"context_lines":[{"line_number":49,"context_line":"_TRUE_VALUES \u003d (\u0027True\u0027, \u0027true\u0027, \u00271\u0027, \u0027yes\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"},{"line_number":52,"context_line":"DB_SCHEMA \u003d {\u0027main\u0027: \"\", \u0027api\u0027: \"\", \u0027placement\u0027: \"\"}"},{"line_number":53,"context_line":"SESSION_CONFIGURED \u003d False"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dd1ef16e","line":52,"range":{"start_line":52,"start_character":13,"end_line":52,"end_character":35},"updated":"2018-09-05 18:46:28.000000000","message":"These can also go away.","commit_id":"5fec97d9fb5a0291d48ab0e69ae70241319a772e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a34f487bd69bc5d3a7861944425409d14eac73","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"class Database(fixtures.Fixture):"},{"line_number":536,"context_line":"    def __init__(self, database\u003d\u0027placement\u0027, connection\u003dNone):"},{"line_number":537,"context_line":"        \"\"\"Create a database fixture."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        :param database: The type of database: \u0027placement\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5d73c1e7","line":536,"range":{"start_line":536,"start_character":23,"end_line":536,"end_character":60},"updated":"2018-09-05 18:46:28.000000000","message":"Yeah these can both go away.","commit_id":"5fec97d9fb5a0291d48ab0e69ae70241319a772e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a34f487bd69bc5d3a7861944425409d14eac73","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        engine \u003d self.get_engine()"},{"line_number":569,"context_line":"        engine.dispose()"},{"line_number":570,"context_line":"        conn \u003d engine.connect()"},{"line_number":571,"context_line":"        conn.connection.executescript(DB_SCHEMA[self.database])"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def setUp(self):"},{"line_number":574,"context_line":"        super(Database, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9d3b99e8","line":571,"range":{"start_line":571,"start_character":8,"end_line":571,"end_character":63},"updated":"2018-09-05 18:46:28.000000000","message":"OK so on setup we\u0027re going to call this to run the migrations, which would hit the keypairs migration which imports nova.objects.keypairs which will blow up.","commit_id":"5fec97d9fb5a0291d48ab0e69ae70241319a772e"}]}