)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26122edb2f9bd46860b48cb1169a6c44b6591015","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to misleading results."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change adjusts the cover job in tox to use a test path of"},{"line_number":14,"context_line":"placement/tests, resulting in all the tests running."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is in preparation for turning on a check job for coverage."},{"line_number":17,"context_line":"See this email for more on that:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_bdb2f892","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":15},"updated":"2018-09-06 20:29:32.000000000","message":"I don\u0027t understand. What was it using before?\n\nIs this one of those things where tox magically-but-confusingly defaults to something (like $project/tests/unit) if you don\u0027t tell it otherwise?","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c5ad27832438dbab96e19b0999a9ac832213177","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to misleading results."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change adjusts the cover job in tox to use a test path of"},{"line_number":14,"context_line":"placement/tests, resulting in all the tests running."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is in preparation for turning on a check job for coverage."},{"line_number":17,"context_line":"See this email for more on that:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e508c0d9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":15},"in_reply_to":"3f79a3b5_05006b00","updated":"2018-09-07 20:27:51.000000000","message":"The .coveragerc is what\u0027s used for the cover job I believe:\n\nhttps://github.com/openstack/placement/blob/master/.coveragerc\n\nSo this change isn\u0027t actually fixing that, because the .coveragerc in placement is pointing at nova.","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0344ab2b22733e6ba1ea92d5b16019f299b06112","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to misleading results."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change adjusts the cover job in tox to use a test path of"},{"line_number":14,"context_line":"placement/tests, resulting in all the tests running."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is in preparation for turning on a check job for coverage."},{"line_number":17,"context_line":"See this email for more on that:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_05006b00","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":15},"in_reply_to":"3f79a3b5_bdb2f892","updated":"2018-09-07 07:32:42.000000000","message":"Not entirely clear is it but there is an .stestr.conf that has the defaults:\n\nhttps://git.openstack.org/cgit/openstack/placement/tree/.stestr.conf\n\nand by convention (as far as I can tell) the default has been the unit tests.","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78c4f5651c05e6a394d7fd4bf61a6d8395cc54b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"placement/tests, resulting in all the tests running."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In the process .coveragerc is updated to be placement oriented"},{"line_number":17,"context_line":"and make sure we do not ignore branches."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This is in preparation for turning on a check job for coverage."},{"line_number":20,"context_line":"See this email for more on that:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_cc5a7e1c","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":39},"updated":"2018-09-09 16:10:08.000000000","message":"errors?","commit_id":"1e05409d0e7bea3129767a6b7633926295aa5e78"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7f90bb7170c1c39a032df2990340469d16e6c1ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"placement/tests, resulting in all the tests running."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In the process .coveragerc is updated to be placement oriented"},{"line_number":17,"context_line":"and make sure we do not ignore branches."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This is in preparation for turning on a check job for coverage."},{"line_number":20,"context_line":"See this email for more on that:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_6cbc8adb","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":39},"in_reply_to":"3f79a3b5_cc5a7e1c","updated":"2018-09-09 16:37:56.000000000","message":"Well yes, I left that part out, but comments refers to: the default for the \u0027branch\u0027 arg is False. \n\nI can make that more clear if desired?","commit_id":"1e05409d0e7bea3129767a6b7633926295aa5e78"}],"tox.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26122edb2f9bd46860b48cb1169a6c44b6591015","unresolved":false,"context_lines":[{"line_number":122,"context_line":"commands \u003d"},{"line_number":123,"context_line":"  {[testenv]commands}"},{"line_number":124,"context_line":"  coverage erase"},{"line_number":125,"context_line":"  stestr --test-path\u003d./placement/tests --group_regex\u003dplacement\\.tests\\.functional\\.test_placement_api(?:\\.|_)([^_]+) run {posargs}"},{"line_number":126,"context_line":"  coverage combine"},{"line_number":127,"context_line":"  coverage html -d cover"},{"line_number":128,"context_line":"  coverage xml -o cover/coverage.xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_3d64a821","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":116},"updated":"2018-09-06 20:29:32.000000000","message":"would be nice if we could DRY this out so we could a) keep its comment with it (without having to copy that big block o text), and b) sanely maintain it in case it ever needs to change.","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d786090c7c46973b39643d4b3a5eff75fc83d381","unresolved":false,"context_lines":[{"line_number":122,"context_line":"commands \u003d"},{"line_number":123,"context_line":"  {[testenv]commands}"},{"line_number":124,"context_line":"  coverage erase"},{"line_number":125,"context_line":"  stestr --test-path\u003d./placement/tests --group_regex\u003dplacement\\.tests\\.functional\\.test_placement_api(?:\\.|_)([^_]+) run {posargs}"},{"line_number":126,"context_line":"  coverage combine"},{"line_number":127,"context_line":"  coverage html -d cover"},{"line_number":128,"context_line":"  coverage xml -o cover/coverage.xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_77b78386","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":116},"in_reply_to":"3f79a3b5_252c8797","updated":"2018-09-07 21:45:33.000000000","message":"Need to keep an eye on [1] which renames test_placement_api to test_api\n\n[1] https://review.openstack.org/#/c/600506/","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0344ab2b22733e6ba1ea92d5b16019f299b06112","unresolved":false,"context_lines":[{"line_number":122,"context_line":"commands \u003d"},{"line_number":123,"context_line":"  {[testenv]commands}"},{"line_number":124,"context_line":"  coverage erase"},{"line_number":125,"context_line":"  stestr --test-path\u003d./placement/tests --group_regex\u003dplacement\\.tests\\.functional\\.test_placement_api(?:\\.|_)([^_]+) run {posargs}"},{"line_number":126,"context_line":"  coverage combine"},{"line_number":127,"context_line":"  coverage html -d cover"},{"line_number":128,"context_line":"  coverage xml -o cover/coverage.xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_252c8797","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":116},"in_reply_to":"3f79a3b5_3d64a821","updated":"2018-09-07 07:32:42.000000000","message":"We  should perhaps try putting it in .stestr.conf.\n\nI think, but haven\u0027t confirmed this morning because still in my pjs, that for a group of tests where no tests match this regex, the concurrency spread will be random as expected.","commit_id":"749cb54cb6746efcfc4cda848b1d8dd1889ff676"}]}