)]}'
{"doc/source/conf.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9dcf0081276ec80907fe9d66cdc4492b2983b795","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"# keep this ordered to keep mriedem happy"},{"line_number":134,"context_line":"openstack_projects \u003d ["},{"line_number":135,"context_line":"    \u0027oslo.versionedobjects\u0027,"},{"line_number":136,"context_line":"    \u0027neutron\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_80842cd5","line":133,"range":{"start_line":133,"start_character":23,"end_line":133,"end_character":41},"updated":"2018-09-11 03:07:04.000000000","message":"super tiny and unrelated nit:\n\nmriedem is not happy. : (\n\n\n    \u0027neutron\u0027,\n    \u0027nova\u0027,\n    \u0027oslo.versionedobjects\u0027,\n    \u0027placement\u0027,\n    \u0027reno\u0027,","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"fac1399e549ba9b496755a0c696a20b590b1be18","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"# keep this ordered to keep mriedem happy"},{"line_number":134,"context_line":"openstack_projects \u003d ["},{"line_number":135,"context_line":"    \u0027oslo.versionedobjects\u0027,"},{"line_number":136,"context_line":"    \u0027neutron\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f2efebae","line":133,"range":{"start_line":133,"start_character":23,"end_line":133,"end_character":41},"in_reply_to":"3f79a3b5_80842cd5","updated":"2018-09-11 17:21:45.000000000","message":"That was changed in I5cbc3a3cceeaeaa7be5593658b6a03fa25fb69d0. Perhaps a separate followup should be made unless we want to risk mriedem sadness.","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8c1c707b5529724eb0d9cd1dd0b7dcd631c5906","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# openstackdocstheme options"},{"line_number":56,"context_line":"repository_name \u003d \u0027openstack/placement\u0027"},{"line_number":57,"context_line":"bug_project \u003d \u0027placement\u0027"},{"line_number":58,"context_line":"bug_tag \u003d \u0027docs\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"policy_generator_config_file \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6f92bc5a","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":24},"updated":"2018-09-15 17:26:28.000000000","message":"This is still nova","commit_id":"a45655efc9a18aa1ee33bd935790f279a71532f6"}],"doc/source/contributor/index.rst":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9dcf0081276ec80907fe9d66cdc4492b2983b795","unresolved":false,"context_lines":[{"line_number":137,"context_line":"history of the available microversions."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The rules around when a microversion is needed are the same as for the"},{"line_number":140,"context_line":":nova-doc:`compute API \u003c/contributor/microversions\u003e`. When adding a new"},{"line_number":141,"context_line":"microversion there are a few bits of required housekeeping that must be done in"},{"line_number":142,"context_line":"the code:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c0078481","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":50},"updated":"2018-09-11 03:07:04.000000000","message":"It\u0027s a wrong link, we need it change to:\ncontributor/microversions\n\nOtherwise we would get a 404 page:\nhttps://docs.openstack.org/nova/latest//contributor/microversions\n\nSee in:\nhttp://logs.openstack.org/57/600857/1/check/openstack-tox-docs/efc4870/html/contributor/","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"fac1399e549ba9b496755a0c696a20b590b1be18","unresolved":false,"context_lines":[{"line_number":137,"context_line":"history of the available microversions."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The rules around when a microversion is needed are the same as for the"},{"line_number":140,"context_line":":nova-doc:`compute API \u003c/contributor/microversions\u003e`. When adding a new"},{"line_number":141,"context_line":"microversion there are a few bits of required housekeeping that must be done in"},{"line_number":142,"context_line":"the code:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e19ab860","line":140,"range":{"start_line":140,"start_character":24,"end_line":140,"end_character":50},"in_reply_to":"3f79a3b5_c0078481","updated":"2018-09-11 17:21:45.000000000","message":"This should be addressed in a follow-up","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9dcf0081276ec80907fe9d66cdc4492b2983b795","unresolved":false,"context_lines":[{"line_number":282,"context_line":"done in the same way as other aspects of nova."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"When writing tests for handler code (that is, the code found in"},{"line_number":285,"context_line":"``placement/handlers``) a good rule of thumb is that if you feel like there"},{"line_number":286,"context_line":"needs to be a unit test for some of the code in the handler, that is a good"},{"line_number":287,"context_line":"sign that the piece of code should be extracted to a separate method. That"},{"line_number":288,"context_line":"method should be independent of the handler method itself (the one decorated by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_80366c51","line":285,"range":{"start_line":285,"start_character":0,"end_line":285,"end_character":22},"updated":"2018-09-11 03:07:04.000000000","message":"nit: This is a path, so we should use `placement/handlers`(italic) rather than ``placement/handlers``(bold)","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"fac1399e549ba9b496755a0c696a20b590b1be18","unresolved":false,"context_lines":[{"line_number":282,"context_line":"done in the same way as other aspects of nova."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"When writing tests for handler code (that is, the code found in"},{"line_number":285,"context_line":"``placement/handlers``) a good rule of thumb is that if you feel like there"},{"line_number":286,"context_line":"needs to be a unit test for some of the code in the handler, that is a good"},{"line_number":287,"context_line":"sign that the piece of code should be extracted to a separate method. That"},{"line_number":288,"context_line":"method should be independent of the handler method itself (the one decorated by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_72cd1b2f","line":285,"range":{"start_line":285,"start_character":0,"end_line":285,"end_character":22},"in_reply_to":"3f79a3b5_80366c51","updated":"2018-09-11 17:21:45.000000000","message":"To my eye, there is an inconsistent mix of this type of markup in this section of the doc. For this patch, the only scope is to update the pathing, not to change the way the document renders.","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9dcf0081276ec80907fe9d66cdc4492b2983b795","unresolved":false,"context_lines":[{"line_number":307,"context_line":"handle that appears to Python to be a socket."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"In the placement API the YAML files (aka \"gabbits\") can be found in"},{"line_number":310,"context_line":"``placement/tests/functional/gabbits``. Fixture definitions are in"},{"line_number":311,"context_line":"``placement/tests/functional/fixtures/gabbits.py``.  Tests are frequently"},{"line_number":312,"context_line":"grouped by handler name (e.g., ``resource-provider.yaml`` and"},{"line_number":313,"context_line":"``inventory.yaml``). This is not a requirement and as we increase the number of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_600a307a","line":310,"range":{"start_line":310,"start_character":0,"end_line":310,"end_character":38},"updated":"2018-09-11 03:07:04.000000000","message":"nit: path, ditto","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9dcf0081276ec80907fe9d66cdc4492b2983b795","unresolved":false,"context_lines":[{"line_number":373,"context_line":"It\u0027s also possible to use gabbi against a running placement service, for"},{"line_number":374,"context_line":"example in devstack. See `gabbi-run`_ to get started."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":".. TODO(edleafe): Remove this section?"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"Futures"},{"line_number":379,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c090e445","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":38},"updated":"2018-09-11 03:07:04.000000000","message":"+1, we can remove Futures section.","commit_id":"720fa91321bc9cfbcd1622355a23e9ab69d9a577"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8c1c707b5529724eb0d9cd1dd0b7dcd631c5906","unresolved":false,"context_lines":[{"line_number":136,"context_line":"features on an opt in basis. See :doc:`/index` for an up to date"},{"line_number":137,"context_line":"history of the available microversions."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. TODO(edleafe): Correct the pathing for the link"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"The rules around when a microversion is needed are the same as for the"},{"line_number":142,"context_line":":nova-doc:`compute API \u003c/contributor/microversions\u003e`. When adding a new"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_2faa8470","line":139,"updated":"2018-09-15 17:26:28.000000000","message":"done","commit_id":"a45655efc9a18aa1ee33bd935790f279a71532f6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d8c1c707b5529724eb0d9cd1dd0b7dcd631c5906","unresolved":false,"context_lines":[{"line_number":375,"context_line":"It\u0027s also possible to use gabbi against a running placement service, for"},{"line_number":376,"context_line":"example in devstack. See `gabbi-run`_ to get started."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":".. TODO(edleafe): Remove this section?"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"Futures"},{"line_number":381,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_8fc4f842","line":378,"updated":"2018-09-15 17:26:28.000000000","message":"yup","commit_id":"a45655efc9a18aa1ee33bd935790f279a71532f6"}]}