)]}'
{"placement/tests/functional/fixtures/gabbits.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b301a0111e4d13ea653379b0bf85ab50b0a8a5ff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.output_stream_fixture.setUp()"},{"line_number":58,"context_line":"        self.logging_error_fixture \u003d ("},{"line_number":59,"context_line":"            logging_error.get_logging_handle_error_fixture())"},{"line_number":60,"context_line":"        self.logging_error_fixture.setUp()"},{"line_number":61,"context_line":"        # Filter ignorable warnings during test runs."},{"line_number":62,"context_line":"        self.warnings_fixture \u003d capture.WarningsFixture()"},{"line_number":63,"context_line":"        self.warnings_fixture.setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_168cbb2c","line":60,"updated":"2018-09-12 17:29:11.000000000","message":"Like ew, can\u0027t GabbiFixture support useFixture?","commit_id":"0ba46dd5a25de727dd3fb495f6fcb731826dec23"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d82c342d3189d77db35d572eb3a3d1b679aa7a8e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.output_stream_fixture.setUp()"},{"line_number":58,"context_line":"        self.logging_error_fixture \u003d ("},{"line_number":59,"context_line":"            logging_error.get_logging_handle_error_fixture())"},{"line_number":60,"context_line":"        self.logging_error_fixture.setUp()"},{"line_number":61,"context_line":"        # Filter ignorable warnings during test runs."},{"line_number":62,"context_line":"        self.warnings_fixture \u003d capture.WarningsFixture()"},{"line_number":63,"context_line":"        self.warnings_fixture.setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7642cfad","line":60,"in_reply_to":"3f79a3b5_168cbb2c","updated":"2018-09-12 17:34:24.000000000","message":"Explained in the commit message.\n\nGabbi fixtures wrap N\u003e\u003d1 tests, not individual tests, thus need explicit setUp and cleanUp handling to avoid the magic that useFixture does. I\u0027ll do some digging (or you can) to see if we can add some magic in gabbi to do the right thing, but my preference is to be as explicit as possible, always.","commit_id":"0ba46dd5a25de727dd3fb495f6fcb731826dec23"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"10e334d23282d390ac0b5d182092583a8abed2ef","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.output_stream_fixture.setUp()"},{"line_number":58,"context_line":"        self.logging_error_fixture \u003d ("},{"line_number":59,"context_line":"            logging_error.get_logging_handle_error_fixture())"},{"line_number":60,"context_line":"        self.logging_error_fixture.setUp()"},{"line_number":61,"context_line":"        # Filter ignorable warnings during test runs."},{"line_number":62,"context_line":"        self.warnings_fixture \u003d capture.WarningsFixture()"},{"line_number":63,"context_line":"        self.warnings_fixture.setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_960a0b25","line":60,"in_reply_to":"3f79a3b5_7642cfad","updated":"2018-09-12 17:44:03.000000000","message":"Yeah, my point would be that useFixture would simply automate the setUp and cleanUp thingies being added to start_fixture and stop_fixture.\n\nExplicit is cool, unless you forget to add the cleanUp (and your reviewers don\u0027t notice).","commit_id":"0ba46dd5a25de727dd3fb495f6fcb731826dec23"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f876837d2eeef0bcc5b4bf3d0dd562ca2d74b806","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.output_stream_fixture.setUp()"},{"line_number":58,"context_line":"        self.logging_error_fixture \u003d ("},{"line_number":59,"context_line":"            logging_error.get_logging_handle_error_fixture())"},{"line_number":60,"context_line":"        self.logging_error_fixture.setUp()"},{"line_number":61,"context_line":"        # Filter ignorable warnings during test runs."},{"line_number":62,"context_line":"        self.warnings_fixture \u003d capture.WarningsFixture()"},{"line_number":63,"context_line":"        self.warnings_fixture.setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3cf199df","line":60,"in_reply_to":"3f79a3b5_960a0b25","updated":"2018-09-12 17:56:58.000000000","message":"Sure, but that will require a change in gabbi itself, where test management (especially fixture management) is very complicated because it needs to work with both unittest and pytest-based tests (each of which have very different approaches).","commit_id":"0ba46dd5a25de727dd3fb495f6fcb731826dec23"}]}