)]}'
{"HACKING.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2e2070f3c66f7af8e0e442e51a4943787decd169","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Placement Specific Commandments"},{"line_number":9,"context_line":"-------------------------------"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- [N309] no db session in public API methods (disabled)"},{"line_number":12,"context_line":"  This enforces a guideline defined in ``oslo.db.sqlalchemy.session``"},{"line_number":13,"context_line":"- [N310] timeutils.utcnow() wrapper must be used instead of direct calls to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5f354a44","line":10,"updated":"2018-09-13 22:18:36.000000000","message":"So I would add a note here saying that none of this is actually true, since we didn\u0027t bring nova\u0027s hacking.py along when we extracted.\n\nAnd a TODO on the etherpad to do that or something like it.","commit_id":"5edf534b6787539eca97584a3a2b5fd6b2d433fb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e6162d87c7101c9e3732ca85ea81c60a3a086f68","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Placement Specific Commandments"},{"line_number":9,"context_line":"-------------------------------"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- [N309] no db session in public API methods (disabled)"},{"line_number":12,"context_line":"  This enforces a guideline defined in ``oslo.db.sqlalchemy.session``"},{"line_number":13,"context_line":"- [N310] timeutils.utcnow() wrapper must be used instead of direct calls to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_bf733e16","line":10,"in_reply_to":"3f79a3b5_5f354a44","updated":"2018-09-13 22:20:25.000000000","message":"This is a bit like what I said in my response at the same time as yours, except that I think most of the nova hacking rules are not really necessary, so we _might_ be able to get away with the defaults.\n\nOr to put another way: add things as we find them later","commit_id":"5edf534b6787539eca97584a3a2b5fd6b2d433fb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"02c671ec6d755651f7030e99420c0d56f55020d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":68,"context_line":"infrastructure in OpenStack Placement, please read"},{"line_number":69,"context_line":"``placement/tests/unit/README.rst``."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Running Tests"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3f816efc","line":69,"updated":"2018-09-13 22:19:00.000000000","message":"nit: i move this in https://review.openstack.org/#/c/602177/","commit_id":"5edf534b6787539eca97584a3a2b5fd6b2d433fb"}]}
