)]}'
{"placement/objects/resource_provider.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"25046be2b9347996edfa92f1e5ba16d29a37d6b8","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"            return []"},{"line_number":1444,"context_line":"        if rp_ids:"},{"line_number":1445,"context_line":"            query \u003d query.where(rp.c.id.in_(rp_ids))"},{"line_number":1446,"context_line":"        if forbidden_rp_ids:"},{"line_number":1447,"context_line":"            query \u003d query.where(~rp.c.id.in_(forbidden_rp_ids))"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"        if not resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_abdf5a09","line":1446,"range":{"start_line":1446,"start_character":8,"end_line":1446,"end_character":28},"updated":"2018-10-11 07:33:48.000000000","message":"Since line 2870 already exclude the forbidden_rp_ids, so we may generate this extra cause, but it actually is useless.\n\nSo we can use \u0027elif forbidden_rp_ids\u0027 at here.","commit_id":"8ef157e0830615c57368bf3716acd27da2f65094"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a7ecdff99c1ebc3e16ae3c8d080f0c806c2cd992","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"            return []"},{"line_number":1444,"context_line":"        if rp_ids:"},{"line_number":1445,"context_line":"            query \u003d query.where(rp.c.id.in_(rp_ids))"},{"line_number":1446,"context_line":"        if forbidden_rp_ids:"},{"line_number":1447,"context_line":"            query \u003d query.where(~rp.c.id.in_(forbidden_rp_ids))"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"        if not resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_96c87a56","line":1446,"range":{"start_line":1446,"start_character":8,"end_line":1446,"end_character":28},"in_reply_to":"3f79a3b5_30272dcb","updated":"2018-10-11 13:28:51.000000000","message":"the refactor shouldn\u0027t change any output, so this changed, but it is ok, it isn\u0027t something critical, let us do that in a followon.","commit_id":"8ef157e0830615c57368bf3716acd27da2f65094"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"114a01be4597080b79c99dd4db95302351e00809","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"            return []"},{"line_number":1444,"context_line":"        if rp_ids:"},{"line_number":1445,"context_line":"            query \u003d query.where(rp.c.id.in_(rp_ids))"},{"line_number":1446,"context_line":"        if forbidden_rp_ids:"},{"line_number":1447,"context_line":"            query \u003d query.where(~rp.c.id.in_(forbidden_rp_ids))"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"        if not resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_76a11e3a","line":1446,"range":{"start_line":1446,"start_character":8,"end_line":1446,"end_character":28},"in_reply_to":"3f79a3b5_96c87a56","updated":"2018-10-11 13:38:27.000000000","message":"https://review.openstack.org/#/c/609702/","commit_id":"8ef157e0830615c57368bf3716acd27da2f65094"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a73333a3229eda855c9c682db3e72d97988453b9","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"            return []"},{"line_number":1444,"context_line":"        if rp_ids:"},{"line_number":1445,"context_line":"            query \u003d query.where(rp.c.id.in_(rp_ids))"},{"line_number":1446,"context_line":"        if forbidden_rp_ids:"},{"line_number":1447,"context_line":"            query \u003d query.where(~rp.c.id.in_(forbidden_rp_ids))"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"        if not resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30272dcb","line":1446,"range":{"start_line":1446,"start_character":8,"end_line":1446,"end_character":28},"in_reply_to":"3f79a3b5_abdf5a09","updated":"2018-10-11 13:10:42.000000000","message":"This is true, good eye.\n\nHowever, it\u0027s a logic change (however slight and provably correct) and I would like to restrict this patch to refactor only. Can I do this in a followon?","commit_id":"8ef157e0830615c57368bf3716acd27da2f65094"}]}