)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c80945f1e00bab4ba5e1be166b5a6fc6dbcf8bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This means that the lower-constraints are clobbered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change makes it so that we call pip again after placement is"},{"line_number":16,"context_line":"installed to put the versions of code in lower-constraints into the text"},{"line_number":17,"context_line":"environment. Then all the test (unit and functional) are run to see if"},{"line_number":18,"context_line":"the versions are correct."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_616308ad","line":16,"range":{"start_line":16,"start_character":68,"end_line":16,"end_character":72},"updated":"2018-10-31 16:58:04.000000000","message":"test","commit_id":"af406ec712390d5ac35c441370e90cf20a474a6b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c80945f1e00bab4ba5e1be166b5a6fc6dbcf8bc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"the versions are correct."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This flagged up a few changes, the main one being that we did not have"},{"line_number":21,"context_line":"a new enough version of keystonemiddlware in order to require use of"},{"line_number":22,"context_line":"www_authenticate_uri."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The end result here is a lower-constraints.txt file that starts from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_a1ee00fc","line":21,"range":{"start_line":21,"start_character":24,"end_line":21,"end_character":41},"updated":"2018-10-31 16:58:04.000000000","message":"keystonemiddleware","commit_id":"af406ec712390d5ac35c441370e90cf20a474a6b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"28e22fbf664c241285382a8dda97cc9274c205ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This means that the lower-constraints are clobbered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change makes it so that we call pip again after placement is"},{"line_number":16,"context_line":"installed to put the versions of code in lower-constraints into the text"},{"line_number":17,"context_line":"environment. Then all the test (unit and functional) are run to see if"},{"line_number":18,"context_line":"the versions are correct."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_acd2775e","line":16,"range":{"start_line":16,"start_character":68,"end_line":16,"end_character":72},"updated":"2018-10-31 17:38:23.000000000","message":"repeating Matt\u0027s s/text/test","commit_id":"a3befc0857b687cf2e91fc8c384a70f15e59a5f4"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"28e22fbf664c241285382a8dda97cc9274c205ec","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change makes it so that we call pip again after placement is"},{"line_number":16,"context_line":"installed to put the versions of code in lower-constraints into the text"},{"line_number":17,"context_line":"environment. Then all the test (unit and functional) are run to see if"},{"line_number":18,"context_line":"the versions are correct."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This flagged up a few changes, the main one being that we did not have"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_6cdc5f71","line":17,"range":{"start_line":17,"start_character":26,"end_line":17,"end_character":30},"updated":"2018-10-31 17:38:23.000000000","message":"plural","commit_id":"a3befc0857b687cf2e91fc8c384a70f15e59a5f4"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"28e22fbf664c241285382a8dda97cc9274c205ec","unresolved":false,"context_lines":[{"line_number":18,"context_line":"the versions are correct."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This flagged up a few changes, the main one being that we did not have"},{"line_number":21,"context_line":"a new enough version of keystonemiddlware in order to require use of"},{"line_number":22,"context_line":"www_authenticate_uri. requirements.txt is updated for this as well.j"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The end result here is a lower-constraints.txt file that starts from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_0ccb6ba7","line":21,"range":{"start_line":21,"start_character":24,"end_line":21,"end_character":41},"updated":"2018-10-31 17:38:23.000000000","message":"repeating Matt\u0027s s/keystonemiddlware/keystonemiddleware","commit_id":"a3befc0857b687cf2e91fc8c384a70f15e59a5f4"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"28e22fbf664c241285382a8dda97cc9274c205ec","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This flagged up a few changes, the main one being that we did not have"},{"line_number":21,"context_line":"a new enough version of keystonemiddlware in order to require use of"},{"line_number":22,"context_line":"www_authenticate_uri. requirements.txt is updated for this as well.j"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The end result here is a lower-constraints.txt file that starts from"},{"line_number":25,"context_line":"the lower-constraints.txt defined by nova, and then is adapted to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_8cd53b4b","line":22,"updated":"2018-10-31 17:38:23.000000000","message":"j?","commit_id":"a3befc0857b687cf2e91fc8c384a70f15e59a5f4"}],"lower-constraints.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c80945f1e00bab4ba5e1be166b5a6fc6dbcf8bc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"jsonpointer\u003d\u003d2.0"},{"line_number":44,"context_line":"jsonschema\u003d\u003d2.6.0"},{"line_number":45,"context_line":"keystoneauth1\u003d\u003d3.9.0"},{"line_number":46,"context_line":"keystonemiddleware\u003d\u003d4.18.0"},{"line_number":47,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":48,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":49,"context_line":"Mako\u003d\u003d1.0.7"}],"source_content_type":"text/plain","patch_set":2,"id":"3f79a3b5_212c3048","line":46,"updated":"2018-10-31 16:58:04.000000000","message":"Should update requirements.txt as well then.\n\nhttps://github.com/openstack/placement/blob/master/requirements.txt#L7","commit_id":"af406ec712390d5ac35c441370e90cf20a474a6b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"958f85a0373d0ba1e35a29cd8dc0d5f0950f90c8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"six\u003d\u003d1.10.0"},{"line_number":89,"context_line":"smmap2\u003d\u003d2.0.3"},{"line_number":90,"context_line":"SQLAlchemy\u003d\u003d1.0.10"},{"line_number":91,"context_line":"sqlalchemy-migrate\u003d\u003d0.11.0"},{"line_number":92,"context_line":"sqlparse\u003d\u003d0.2.4"},{"line_number":93,"context_line":"statsd\u003d\u003d3.2.2"},{"line_number":94,"context_line":"stestr\u003d\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":7,"id":"3f79a3b5_498ef5d7","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":26},"updated":"2018-11-20 00:01:00.000000000","message":"Oh, I guess this didn\u0027t auto-conflict because it\u0027s actually re-adding the line. So yeah, this should be re-removed. Again.","commit_id":"634de97edce7acacb33bda75c60ab83607897f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a14bf1994a01cee0c7c79ffd36d883171020abb9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"mock\u003d\u003d2.0.0"},{"line_number":39,"context_line":"monotonic\u003d\u003d1.4"},{"line_number":40,"context_line":"mox3\u003d\u003d0.20.0"},{"line_number":41,"context_line":"msgpack-python\u003d\u003d0.5.6"},{"line_number":42,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":43,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":44,"context_line":"os-client-config\u003d\u003d1.29.0"}],"source_content_type":"text/plain","patch_set":8,"id":"3f79a3b5_b97afe23","line":41,"updated":"2018-11-27 15:51:43.000000000","message":"pypi says that msgpack-python is deprecated and use msgpack instead.\nhttps://pypi.org/project/msgpack-python/","commit_id":"f7f4bf2459c93c2ab96371f600b4e99c8f41284c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4ba18f68bf7620b94a9aceb95e00894c283d6867","unresolved":false,"context_lines":[{"line_number":38,"context_line":"mock\u003d\u003d2.0.0"},{"line_number":39,"context_line":"monotonic\u003d\u003d1.4"},{"line_number":40,"context_line":"mox3\u003d\u003d0.20.0"},{"line_number":41,"context_line":"msgpack-python\u003d\u003d0.5.6"},{"line_number":42,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":43,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":44,"context_line":"os-client-config\u003d\u003d1.29.0"}],"source_content_type":"text/plain","patch_set":8,"id":"3f79a3b5_f4315bbc","line":41,"in_reply_to":"3f79a3b5_b97afe23","updated":"2018-11-27 16:03:37.000000000","message":"something in the stack is requiring msgpack-python and making it (not msgpack) show up in the repo. The job of lower-constraints is to state what we are actually using, not what we should be using, so I figure this  is more correct in that it reflects the reality of a transitive dependency.","commit_id":"f7f4bf2459c93c2ab96371f600b4e99c8f41284c"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a14bf1994a01cee0c7c79ffd36d883171020abb9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"# When using pbr and in a git repo, \u0027setup.py install\u0027 does not install"},{"line_number":208,"context_line":"# packages. \u0027setup.py develop\u0027, used when usedevelop is True, does."},{"line_number":209,"context_line":"usedevelop \u003d False"},{"line_number":210,"context_line":"# Use our own install_command to turn off upper constraints, which conflicts"},{"line_number":211,"context_line":"# with lower constraints."},{"line_number":212,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":213,"context_line":"deps \u003d"},{"line_number":214,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":215,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f79a3b5_1904527c","line":212,"range":{"start_line":210,"start_character":0,"end_line":212,"end_character":47},"updated":"2018-11-27 15:51:43.000000000","message":"I looked at the lower constraints but I don\u0027t see how we are conflicting with the upper constraints. Then I tried running the test without this line and I did not see any conflict.","commit_id":"f7f4bf2459c93c2ab96371f600b4e99c8f41284c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4ba18f68bf7620b94a9aceb95e00894c283d6867","unresolved":false,"context_lines":[{"line_number":207,"context_line":"# When using pbr and in a git repo, \u0027setup.py install\u0027 does not install"},{"line_number":208,"context_line":"# packages. \u0027setup.py develop\u0027, used when usedevelop is True, does."},{"line_number":209,"context_line":"usedevelop \u003d False"},{"line_number":210,"context_line":"# Use our own install_command to turn off upper constraints, which conflicts"},{"line_number":211,"context_line":"# with lower constraints."},{"line_number":212,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":213,"context_line":"deps \u003d"},{"line_number":214,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":215,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f79a3b5_145e57e7","line":212,"range":{"start_line":210,"start_character":0,"end_line":212,"end_character":47},"in_reply_to":"3f79a3b5_1904527c","updated":"2018-11-27 16:03:37.000000000","message":"Because I\u0027ve fixed them in this change. I think if you try running this set of commands against a different branch you will get issues. If not, then something important got lost in the iteration toward this version of the patch.","commit_id":"f7f4bf2459c93c2ab96371f600b4e99c8f41284c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"487522293f3c2e5ac271a5278277798a475f4ba7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  find"},{"line_number":11,"context_line":"  rm"},{"line_number":12,"context_line":"  env"},{"line_number":13,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"  LANGUAGE\u003den_US"},{"line_number":17,"context_line":"  LC_ALL\u003den_US.utf-8"}],"source_content_type":"text/x-properties","patch_set":9,"id":"1f493fa4_bae1612d","line":14,"range":{"start_line":13,"start_character":30,"end_line":14,"end_character":2},"updated":"2020-05-07 15:19:04.000000000","message":"instead of defining your own install_command, move the constraints into deps as we do elsewhere.","commit_id":"4469a813cb68d99b81440dd33f5f7e9a1f892c27"}]}