)]}'
{"placement/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23a183caec855f936a9190c2b523aefb29ec4ec9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    # already registered"},{"line_number":60,"context_line":"                    pass"},{"line_number":61,"context_line":"                CONF.set_override(\u0027connection\u0027, \u0027sqlite://\u0027,"},{"line_number":62,"context_line":"                                  group\u003d\u0027placement_database\u0027)"},{"line_number":63,"context_line":"            placement_db.configure(CONF)"},{"line_number":64,"context_line":"            session_configured \u003d True"},{"line_number":65,"context_line":"        self.get_engine \u003d placement_db.get_placement_engine"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_0cb7998a","line":62,"updated":"2018-11-20 20:12:20.000000000","message":"Should this also set sqlite_synchronous\u003dFalse?","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a609797c2de9cd2464059f8dab598909f6f6f004","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    # already registered"},{"line_number":60,"context_line":"                    pass"},{"line_number":61,"context_line":"                CONF.set_override(\u0027connection\u0027, \u0027sqlite://\u0027,"},{"line_number":62,"context_line":"                                  group\u003d\u0027placement_database\u0027)"},{"line_number":63,"context_line":"            placement_db.configure(CONF)"},{"line_number":64,"context_line":"            session_configured \u003d True"},{"line_number":65,"context_line":"        self.get_engine \u003d placement_db.get_placement_engine"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_67ac26eb","line":62,"in_reply_to":"3f79a3b5_07f8d215","updated":"2018-11-20 20:21:51.000000000","message":"Okay, then that setting is unnecessary in the spots where this fixture is consumed?","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ecb39d5f22b01eef3035dac02d7b1d7bfbcc6b4b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    # already registered"},{"line_number":60,"context_line":"                    pass"},{"line_number":61,"context_line":"                CONF.set_override(\u0027connection\u0027, \u0027sqlite://\u0027,"},{"line_number":62,"context_line":"                                  group\u003d\u0027placement_database\u0027)"},{"line_number":63,"context_line":"            placement_db.configure(CONF)"},{"line_number":64,"context_line":"            session_configured \u003d True"},{"line_number":65,"context_line":"        self.get_engine \u003d placement_db.get_placement_engine"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_07f8d215","line":62,"in_reply_to":"3f79a3b5_0cb7998a","updated":"2018-11-20 20:19:02.000000000","message":"It doesn\u0027t really mean anything when using a ram-based database. It matters with file-based because it defines how/when it writes to disk.","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a2104a42d598d65964d0428002c7bd75dc1aa7b8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    # already registered"},{"line_number":60,"context_line":"                    pass"},{"line_number":61,"context_line":"                CONF.set_override(\u0027connection\u0027, \u0027sqlite://\u0027,"},{"line_number":62,"context_line":"                                  group\u003d\u0027placement_database\u0027)"},{"line_number":63,"context_line":"            placement_db.configure(CONF)"},{"line_number":64,"context_line":"            session_configured \u003d True"},{"line_number":65,"context_line":"        self.get_engine \u003d placement_db.get_placement_engine"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_e7eef61e","line":62,"in_reply_to":"3f79a3b5_67ac26eb","updated":"2018-11-20 22:47:17.000000000","message":"Yes, it\u0027s a cargo cult into the placement fixtures (when it was in nova) from nova, where synchronous was a default in the db opts, because it is a good choice if you are using a file-based sqlite db (which the config defaulted to for reasons we\u0027ve since realised are bunk and not repeated in placement.\n\ncan get that in the fup too. or rather the fup will get that because it wil set_config","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"}],"placement/tests/functional/base.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23a183caec855f936a9190c2b523aefb29ec4ec9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(TestCase, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Manage required configuration"},{"line_number":39,"context_line":"        conf_fixture \u003d self.useFixture(config_fixture.Config(CONF))"},{"line_number":40,"context_line":"        conf_fixture.config("},{"line_number":41,"context_line":"            group\u003d\u0027placement_database\u0027,"},{"line_number":42,"context_line":"            connection\u003d\u0027sqlite://\u0027,"},{"line_number":43,"context_line":"            sqlite_synchronous\u003dFalse)"},{"line_number":44,"context_line":"        CONF([], default_config_files\u003d[])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.useFixture(policy_fixture.PolicyFixture())"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_2cecd58f","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":37},"updated":"2018-11-20 20:12:20.000000000","message":"Is this still necessary? Could we...","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ecb39d5f22b01eef3035dac02d7b1d7bfbcc6b4b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(TestCase, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Manage required configuration"},{"line_number":39,"context_line":"        conf_fixture \u003d self.useFixture(config_fixture.Config(CONF))"},{"line_number":40,"context_line":"        conf_fixture.config("},{"line_number":41,"context_line":"            group\u003d\u0027placement_database\u0027,"},{"line_number":42,"context_line":"            connection\u003d\u0027sqlite://\u0027,"},{"line_number":43,"context_line":"            sqlite_synchronous\u003dFalse)"},{"line_number":44,"context_line":"        CONF([], default_config_files\u003d[])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.useFixture(policy_fixture.PolicyFixture())"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_a706be18","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":37},"in_reply_to":"3f79a3b5_2cecd58f","updated":"2018-11-20 20:19:02.000000000","message":"We could, but my intention was to avoid changing use of the fixture by placement itself, in this change, so as to minimize the scope of the change. If we want to use set_config in a follow up, it ought to work.\n\nThere are probably several tidy up like that that can happen.\n\nBut basically, yeah, wanted to avoid too much surface area.","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23a183caec855f936a9190c2b523aefb29ec4ec9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.useFixture(capture.WarningsFixture())"},{"line_number":52,"context_line":"        self.useFixture(logging_error.get_logging_handle_error_fixture())"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.placement_db \u003d self.useFixture(fixtures.Database())"},{"line_number":55,"context_line":"        self.context \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_4cf6f160","line":54,"range":{"start_line":54,"start_character":61,"end_line":54,"end_character":63},"updated":"2018-11-20 20:12:20.000000000","message":"...use set_config\u003dTrue here?\n\nPerhaps I\u0027m not grasping which is the preferred way to set up the db conf defaults.","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"}],"placement/tests/functional/fixtures/gabbits.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23a183caec855f936a9190c2b523aefb29ec4ec9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.warnings_fixture \u003d capture.WarningsFixture()"},{"line_number":63,"context_line":"        self.warnings_fixture.setUp()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.conf_fixture \u003d config_fixture.Config(CONF)"},{"line_number":66,"context_line":"        self.conf_fixture.setUp()"},{"line_number":67,"context_line":"        self.conf_fixture.config("},{"line_number":68,"context_line":"                group\u003d\"placement_database\","},{"line_number":69,"context_line":"                connection\u003d\u0027sqlite://\u0027,"},{"line_number":70,"context_line":"                sqlite_synchronous\u003dFalse)"},{"line_number":71,"context_line":"        self.conf_fixture.config(group\u003d\u0027api\u0027, auth_strategy\u003d\u0027noauth2\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.context \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_4c8b51c0","line":70,"range":{"start_line":65,"start_character":0,"end_line":70,"end_character":41},"updated":"2018-11-20 20:12:20.000000000","message":"ditto.","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"}],"placement/tests/functional/fixtures/placement.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23a183caec855f936a9190c2b523aefb29ec4ec9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    all calls would be passing this token."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This fixture takes care of starting a fixture for an in-RAM placement"},{"line_number":37,"context_line":"    database, unless the db kwargs is False."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Used by other services, including nova, for functional tests."},{"line_number":40,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_0cc0f9f8","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":34},"updated":"2018-11-20 20:12:20.000000000","message":"kwarg","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ecb39d5f22b01eef3035dac02d7b1d7bfbcc6b4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    all calls would be passing this token."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This fixture takes care of starting a fixture for an in-RAM placement"},{"line_number":37,"context_line":"    database, unless the db kwargs is False."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Used by other services, including nova, for functional tests."},{"line_number":40,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_c71ada69","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":34},"in_reply_to":"3f79a3b5_0cc0f9f8","updated":"2018-11-20 20:19:02.000000000","message":"will fup","commit_id":"2c72b94719b3c0b2e24f1ed3890455790d076cf4"}]}