)]}'
{"placement/wsgi.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4ddab6965569f21487e16a2d17332f92745dc4d5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    conf.CONF.reset()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    # This will raise cfg.RequiredOptError when a required option is not set"},{"line_number":113,"context_line":"    # (notably the database connection string). We this to be a hard fail that"},{"line_number":114,"context_line":"    # prevents the application from starting. The error will show up in the"},{"line_number":115,"context_line":"    # wsgi server\u0027s logs."},{"line_number":116,"context_line":"    _parse_args([], default_config_files\u003dconffile)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4d676f53","line":113,"range":{"start_line":113,"start_character":48,"end_line":113,"end_character":68},"updated":"2018-11-27 10:30:55.000000000","message":"nit: a word is missing here","commit_id":"184b188e29d340a8924bf02fe925d752d5e05ac3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9a7005e570577e9076b05216b64fc60fa43ebd73","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    dirname \u003d env.get(\u0027OS_PLACEMENT_CONFIG_DIR\u0027, \u0027\u0027).strip()"},{"line_number":59,"context_line":"    if dirname:"},{"line_number":60,"context_line":"        return [os.path.join(dirname, CONFIG_FILE)]"},{"line_number":61,"context_line":"    else:"},{"line_number":62,"context_line":"        return None"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_74851d02","line":60,"range":{"start_line":60,"start_character":14,"end_line":60,"end_character":51},"updated":"2018-11-29 13:05:19.000000000","message":"little nit... either just return os.path.join(dirname, CONFIG_FILE) or change the function name to _get_config_files(). I prefer adding the [] around conffile below...","commit_id":"647f9ba2ff6ed9b1e29fb2fc16716b924daf06f3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"475dcbb700aa7be5cad649dc059f9dc72c302ea5","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    dirname \u003d env.get(\u0027OS_PLACEMENT_CONFIG_DIR\u0027, \u0027\u0027).strip()"},{"line_number":59,"context_line":"    if dirname:"},{"line_number":60,"context_line":"        return [os.path.join(dirname, CONFIG_FILE)]"},{"line_number":61,"context_line":"    else:"},{"line_number":62,"context_line":"        return None"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_74ae7d84","line":60,"range":{"start_line":60,"start_character":14,"end_line":60,"end_character":51},"in_reply_to":"3f79a3b5_74851d02","updated":"2018-11-29 13:07:05.000000000","message":"Yeah, I waffled back and forth on that several times. Fixing.","commit_id":"647f9ba2ff6ed9b1e29fb2fc16716b924daf06f3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a27beab521591485074fd7e801442a77eb2e506b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    dirname \u003d env.get(\u0027OS_PLACEMENT_CONFIG_DIR\u0027, \u0027\u0027).strip()"},{"line_number":59,"context_line":"    if dirname:"},{"line_number":60,"context_line":"        return [os.path.join(dirname, CONFIG_FILE)]"},{"line_number":61,"context_line":"    else:"},{"line_number":62,"context_line":"        return None"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_940f9989","line":60,"range":{"start_line":60,"start_character":14,"end_line":60,"end_character":51},"in_reply_to":"3f79a3b5_74ae7d84","updated":"2018-11-29 13:14:36.000000000","message":"Ah, now I remember why I did it this way: None and [] mean different things to __call__ on the CONF and I didn\u0027t want to test for none on the return of this. I\u0027ll change the name of the method.","commit_id":"647f9ba2ff6ed9b1e29fb2fc16716b924daf06f3"}]}