)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e3cbddb66538fa1a1cb67ebd77535cec2350a8f3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Placement doesn\u0027t need to talk to itself, and for the time being it"},{"line_number":14,"context_line":"doesn\u0027t need to talk to anyone else but the database, so we can"},{"line_number":15,"context_line":"remove the settings. We do not need to deprecate them because we"},{"line_number":16,"context_line":"have aleady declared that a \"fresh config\" is required and we"},{"line_number":17,"context_line":"haven\u0027t had a release yet. If people have the settings in their"},{"line_number":18,"context_line":"config files they simply won\u0027t be used."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_a4af2e9a","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":11},"updated":"2018-11-27 20:57:20.000000000","message":"already","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12372b1711906caeb8437f0ad7d5967a63a38678","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Placement doesn\u0027t need to talk to itself, and for the time being it"},{"line_number":14,"context_line":"doesn\u0027t need to talk to anyone else but the database, so we can"},{"line_number":15,"context_line":"remove the settings. We do not need to deprecate them because we"},{"line_number":16,"context_line":"have aleady declared that a \"fresh config\" is required and we"},{"line_number":17,"context_line":"haven\u0027t had a release yet. If people have the settings in their"},{"line_number":18,"context_line":"config files they simply won\u0027t be used."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_1fb74bd3","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":11},"in_reply_to":"3f79a3b5_a4af2e9a","updated":"2018-11-27 21:57:05.000000000","message":"Done","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"569db13cb7cb6ef7c5c9d4217900e5761294308c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"haven\u0027t had a release yet. If people have the settings in their"},{"line_number":18,"context_line":"config files they simply won\u0027t be used."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Similar settings are registered in the [keystone] group, for"},{"line_number":21,"context_line":"the auth middleware."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"There\u0027s no test coverage for these because any tests which would"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_dfe6b349","line":20,"range":{"start_line":20,"start_character":39,"end_line":20,"end_character":49},"updated":"2018-11-27 21:32:57.000000000","message":"So, I don\u0027t think this is what you think it is. This is in nova specifically for when a couple of compute APIs need to talk to keystone to validate tenant_ids (the flavor access and limits APIs specifically I think):\n\nI2204c8bed8936d5bed0f410284d2a563f84e7100\n\nSo that should likely also be removed from placement since placement doesn\u0027t need to make any calls to keystone outside of the authtoken middleware, and configuration for that is in the [keystone_authtoken] group, which is not listed in the placement.conf docs:\n\nhttp://logs.openstack.org/99/619299/5/check/openstack-tox-docs/de1f813/html/configuration/config.html\n\nbut they are in the nova config docs:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#keystone-authtoken\n\nSo besides the commit message being misleading, there are obviously additional related changes to placement that need to be done:\n\n1. don\u0027t register [keystone] options since placement doesn\u0027t use them\n\n2. get the [keystone_authtoken] options built into the docs (there are likely other 3rd party library options that placement is using which aren\u0027t in the docs because they aren\u0027t listed in etc/config-generator.conf)","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12372b1711906caeb8437f0ad7d5967a63a38678","unresolved":false,"context_lines":[{"line_number":17,"context_line":"haven\u0027t had a release yet. If people have the settings in their"},{"line_number":18,"context_line":"config files they simply won\u0027t be used."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Similar settings are registered in the [keystone] group, for"},{"line_number":21,"context_line":"the auth middleware."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"There\u0027s no test coverage for these because any tests which would"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_dfda331a","line":20,"range":{"start_line":20,"start_character":39,"end_line":20,"end_character":49},"in_reply_to":"3f79a3b5_dfe6b349","updated":"2018-11-27 21:57:05.000000000","message":"Fixed in a follow up: https://review.openstack.org/620412","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"569db13cb7cb6ef7c5c9d4217900e5761294308c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"have used them are still in nova. Integration tests will make"},{"line_number":25,"context_line":"sure this change is fine."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: Id0635f512011c96e0683a26298c7382c711ac3a3"},{"line_number":28,"context_line":"Change-Id: I180a4df89d8338dc640dc2c5638775c65bde1cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_ff2b6f79","line":27,"updated":"2018-11-27 21:32:57.000000000","message":"Sounds like we can drop this now. And given https://review.openstack.org/617565 is merged, we can rebase and make sure we get a clean tempest/grenade run on this change on its own.","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12372b1711906caeb8437f0ad7d5967a63a38678","unresolved":false,"context_lines":[{"line_number":24,"context_line":"have used them are still in nova. Integration tests will make"},{"line_number":25,"context_line":"sure this change is fine."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: Id0635f512011c96e0683a26298c7382c711ac3a3"},{"line_number":28,"context_line":"Change-Id: I180a4df89d8338dc640dc2c5638775c65bde1cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_7fdd1f10","line":27,"in_reply_to":"3f79a3b5_ff2b6f79","updated":"2018-11-27 21:57:05.000000000","message":"Done","commit_id":"263f970d8a6b87f8268556dd4f8b9de88bd6dc11"}]}