)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bda6d875de9573fb677215ad7061bf4a20a6f1f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"With this change, the shell scripts will need to be executed under the"},{"line_number":21,"context_line":"following condition:"},{"line_number":22,"context_line":" - The placement is already installed to execute `placement-manage *`"},{"line_number":23,"context_line":" - The placement cli can access the placement\u0027s database, for example,"},{"line_number":24,"context_line":"   by reffering to the `[placement_database]` section in the"},{"line_number":25,"context_line":"   `placement.conf`."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_d876b440","line":23,"updated":"2018-12-11 17:17:02.000000000","message":"What are people\u0027s thoughts on making this graceful in case placement.conf isn\u0027t configured yet, like in the case of the grenade dependency below? If we could detect that then we could log a warning but not fail the DB migration. Although people are likely going to just be scripting this and not looking at command output if it doesn\u0027t fail, so maybe that\u0027s pointless.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9f95f72cf6472fceb7a5f449e5e8f7bfcb94da3a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"With this change, the shell scripts will need to be executed under the"},{"line_number":21,"context_line":"following condition:"},{"line_number":22,"context_line":" - The placement is already installed to execute `placement-manage *`"},{"line_number":23,"context_line":" - The placement cli can access the placement\u0027s database, for example,"},{"line_number":24,"context_line":"   by reffering to the `[placement_database]` section in the"},{"line_number":25,"context_line":"   `placement.conf`."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_05a6c7c0","line":23,"in_reply_to":"3f79a3b5_c6cc84bf","updated":"2018-12-14 01:34:41.000000000","message":"\u003e I agree that logging a warning, but not failing, is likely to go unseen.\n\nYup, one intent of this change is to let operators be aware of the necessity of stamping. If it is likely to go unseen, I don\u0027t think we need this change.\n\n\u003e If the migration script knows the target db\u0027s url, then we could consider putting that into the environment as OS_PLACEMENT_DATABASE__CONNECTION, and running the sync command with that, ignoring/overriding whatever is in the config file, and also working if the config file doesn\u0027t exist?\n\nIMO, this script should use the same value with the placement service, anyway, because having too many places to set the config value can confuse people.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3addc4d6c7be00211fc1907aa3600fbcf5dd6185","unresolved":false,"context_lines":[{"line_number":20,"context_line":"With this change, the shell scripts will need to be executed under the"},{"line_number":21,"context_line":"following condition:"},{"line_number":22,"context_line":" - The placement is already installed to execute `placement-manage *`"},{"line_number":23,"context_line":" - The placement cli can access the placement\u0027s database, for example,"},{"line_number":24,"context_line":"   by reffering to the `[placement_database]` section in the"},{"line_number":25,"context_line":"   `placement.conf`."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_c6cc84bf","line":23,"in_reply_to":"3f79a3b5_d876b440","updated":"2018-12-12 11:18:36.000000000","message":"If the migration script knows the target db\u0027s url, then we could consider putting that into the environment as OS_PLACEMENT_DATABASE__CONNECTION, and running the sync command with that, ignoring/overriding whatever is in the config file, and also working if the config file doesn\u0027t exist?\n\nI agree that logging a warning, but not failing, is likely to go unseen.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"}],"tools/mysql-migrate-db.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bda6d875de9573fb677215ad7061bf4a20a6f1f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    echo \"    3: Migration already completed\""},{"line_number":235,"context_line":"    echo \"    4: No data to migrate from nova (new deployment)\""},{"line_number":236,"context_line":"    echo \"    5: Unable to connect to one or both databases\""},{"line_number":237,"context_line":"    echo \"    6: Unable to execute placement\u0027s cli commands\""},{"line_number":238,"context_line":"    exit 0"},{"line_number":239,"context_line":"}"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_f8edb0b8","line":237,"range":{"start_line":237,"start_character":47,"end_line":237,"end_character":50},"updated":"2018-12-11 17:17:02.000000000","message":"nit: CLI","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9f95f72cf6472fceb7a5f449e5e8f7bfcb94da3a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    echo \"    3: Migration already completed\""},{"line_number":235,"context_line":"    echo \"    4: No data to migrate from nova (new deployment)\""},{"line_number":236,"context_line":"    echo \"    5: Unable to connect to one or both databases\""},{"line_number":237,"context_line":"    echo \"    6: Unable to execute placement\u0027s cli commands\""},{"line_number":238,"context_line":"    exit 0"},{"line_number":239,"context_line":"}"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_a5eef3fc","line":237,"range":{"start_line":237,"start_character":47,"end_line":237,"end_character":50},"in_reply_to":"3f79a3b5_f8edb0b8","updated":"2018-12-14 01:34:41.000000000","message":"Done","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bda6d875de9573fb677215ad7061bf4a20a6f1f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    echo \"Unable to proceed without connection to placement database\""},{"line_number":279,"context_line":"    exit 5"},{"line_number":280,"context_line":"elif [ $placement_cli -eq 1 ]; then"},{"line_number":281,"context_line":"    echo \"Unable to proceed without placement installed\""},{"line_number":282,"context_line":"    exit 6"},{"line_number":283,"context_line":"elif [ $placement_cli -eq 2 ]; then"},{"line_number":284,"context_line":"    echo \"The \u0027placement-manage db version\u0027 command fails\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_9816fca1","line":281,"range":{"start_line":281,"start_character":36,"end_line":281,"end_character":45},"updated":"2018-12-11 17:17:02.000000000","message":"nit: openstack-placement? That\u0027s the name of the pip right? Maybe that\u0027s too confusing though and \"placement\" is better since it\u0027s generic, e.g. someone could get confused if they are using rpms and would need to use python-openstackplacement or something.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9f95f72cf6472fceb7a5f449e5e8f7bfcb94da3a","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    echo \"Unable to proceed without connection to placement database\""},{"line_number":279,"context_line":"    exit 5"},{"line_number":280,"context_line":"elif [ $placement_cli -eq 1 ]; then"},{"line_number":281,"context_line":"    echo \"Unable to proceed without placement installed\""},{"line_number":282,"context_line":"    exit 6"},{"line_number":283,"context_line":"elif [ $placement_cli -eq 2 ]; then"},{"line_number":284,"context_line":"    echo \"The \u0027placement-manage db version\u0027 command fails\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_006b15b8","line":281,"range":{"start_line":281,"start_character":36,"end_line":281,"end_character":45},"in_reply_to":"3f79a3b5_6636d0b5","updated":"2018-12-14 01:34:41.000000000","message":"Okay, let\u0027s keep it simple.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3addc4d6c7be00211fc1907aa3600fbcf5dd6185","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    echo \"Unable to proceed without connection to placement database\""},{"line_number":279,"context_line":"    exit 5"},{"line_number":280,"context_line":"elif [ $placement_cli -eq 1 ]; then"},{"line_number":281,"context_line":"    echo \"Unable to proceed without placement installed\""},{"line_number":282,"context_line":"    exit 6"},{"line_number":283,"context_line":"elif [ $placement_cli -eq 2 ]; then"},{"line_number":284,"context_line":"    echo \"The \u0027placement-manage db version\u0027 command fails\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_6636d0b5","line":281,"range":{"start_line":281,"start_character":36,"end_line":281,"end_character":45},"in_reply_to":"3f79a3b5_9816fca1","updated":"2018-12-12 11:18:36.000000000","message":"I think generic is better here, because it is referring the service, not one of many different possible names for how the thing was installed.","commit_id":"5ae37451b3730040a58a2cfdcb45b07d175aacc4"}]}