)]}'
{"placement/cmd/status.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"88867190573736ef8aade0d97e43a18b383d4702","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Count the total number of unique consumers in the allocations table."},{"line_number":38,"context_line":"        num_alloc_consumers \u003d ctxt.session.query(models.Allocation).group_by("},{"line_number":39,"context_line":"            models.Allocation.consumer_id).count()"},{"line_number":40,"context_line":"        return num_alloc_consumers - num_consumers"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _check_incomplete_consumers(self):"},{"line_number":43,"context_line":"        \"\"\"Allocations created with microversion\u003c1.8 prior to Rocky will not"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_300a5426","line":40,"updated":"2019-01-21 11:32:38.000000000","message":"nice","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1fc5a8a2e157ade73bba29278315c91e18320f78","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Count the total number of unique consumers in the allocations table."},{"line_number":38,"context_line":"        num_alloc_consumers \u003d ctxt.session.query(models.Allocation).group_by("},{"line_number":39,"context_line":"            models.Allocation.consumer_id).count()"},{"line_number":40,"context_line":"        return num_alloc_consumers - num_consumers"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _check_incomplete_consumers(self):"},{"line_number":43,"context_line":"        \"\"\"Allocations created with microversion\u003c1.8 prior to Rocky will not"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_aabc9069","line":40,"in_reply_to":"9fdfeff1_300a5426","updated":"2019-01-21 14:26:23.000000000","message":"I can name that tune in one query, but yes, it\u0027s nice. :P","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35ac75e7f05c2e45714423da395bff21da8c200a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Count the total number of unique consumers in the allocations table."},{"line_number":38,"context_line":"        num_alloc_consumers \u003d ctxt.session.query(models.Allocation).group_by("},{"line_number":39,"context_line":"            models.Allocation.consumer_id).count()"},{"line_number":40,"context_line":"        return num_alloc_consumers - num_consumers"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _check_incomplete_consumers(self):"},{"line_number":43,"context_line":"        \"\"\"Allocations created with microversion\u003c1.8 prior to Rocky will not"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_0d6376de","line":40,"in_reply_to":"9fdfeff1_aabc9069","updated":"2019-01-21 14:31:49.000000000","message":"I started by copying the existing online data migration outerjoin query but ran into some trouble and rather than struggle for a day I just dumbed it down to this.","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0ef1b19af1ae4bdbfd4030b8dec35f634629325b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        via the REST API or when the"},{"line_number":49,"context_line":"        \"placement-manage db online_data_migrations\" command is run during"},{"line_number":50,"context_line":"        an upgrade. This status check emits a warning if there are incomplete"},{"line_number":51,"context_line":"        consumers to remind operators to perform the data migration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Note that normally we would not add an upgrade status check to simply"},{"line_number":54,"context_line":"        mirror an online data migration since online data migrations should"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_6de32207","line":51,"updated":"2019-01-21 14:45:55.000000000","message":"Do we have the case when a consumer record exists as the allocation was created with microversion \u003e\u003d 1.8 but consumer generation does not filled as microversion \u003c 1.28 ? If yes then I think the above query does not detect such problem.","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ab078e08fb1de9d49f5dc9bb4598535760bac668","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        via the REST API or when the"},{"line_number":49,"context_line":"        \"placement-manage db online_data_migrations\" command is run during"},{"line_number":50,"context_line":"        an upgrade. This status check emits a warning if there are incomplete"},{"line_number":51,"context_line":"        consumers to remind operators to perform the data migration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Note that normally we would not add an upgrade status check to simply"},{"line_number":54,"context_line":"        mirror an online data migration since online data migrations should"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_ad04aa7c","line":51,"in_reply_to":"9fdfeff1_6de32207","updated":"2019-01-21 14:52:22.000000000","message":"Matt explained to me that consumer generation is defaulted to 0 so if there is consumer record then the generation also initialized. So no problem with the above query.","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a0b5dc563657464172f824f88508437f1c8b520","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        via the REST API or when the"},{"line_number":49,"context_line":"        \"placement-manage db online_data_migrations\" command is run during"},{"line_number":50,"context_line":"        an upgrade. This status check emits a warning if there are incomplete"},{"line_number":51,"context_line":"        consumers to remind operators to perform the data migration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Note that normally we would not add an upgrade status check to simply"},{"line_number":54,"context_line":"        mirror an online data migration since online data migrations should"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_4dd09ef8","line":51,"in_reply_to":"9fdfeff1_6de32207","updated":"2019-01-21 14:51:47.000000000","message":"No I don\u0027t think so because the consumers table defaults generation to 0, so as long as there is a consumers table record for the allocation(s) then there is a generation.","commit_id":"0f97cebedd1dff8d5a61493f6b1f3909d34fb7dc"}]}