)]}'
{"placement/cmd/status.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1e1c3e383e31f79f5df991df7b8c152a2ebc6b0b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    config(args\u003d[], project\u003d\u0027placement\u0027)"},{"line_number":90,"context_line":"    db_api.configure(config)"},{"line_number":91,"context_line":"    return upgradecheck.main("},{"line_number":92,"context_line":"        cfg.ConfigOpts(), project\u003d\u0027placement\u0027, upgrade_command\u003dChecks(config))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_9b319ca5","line":92,"updated":"2019-01-24 11:15:06.000000000","message":"It\u0027s frustrating that two separate ConfigOpts are needed. You should add a comment explaining why here, otherwise someone is going to come along later and want to change it and discover that it doesn\u0027t work.\n\nAnother way to do this is like this:\n\n    config(args\u003d[], project\u003d\u0027placement\u0027)\n    config._args \u003d None\n    db_api.configure(config)\n    return upgradecheck.main(\n        config, project\u003d\u0027placement\u0027, upgrade_command\u003dChecks(config))\n\n(doing `config(args\u003dNone...` does _not_ work).\n\nI suspect that manipulating a private member is not a good idea, but it might be worth thinking about. What do you think?","commit_id":"461447e51cb9a6cc4e42388b49bd7f2de3b1d22e"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"0b22408f4b1b372c4be0540b2bc9da0dba15f576","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    config(args\u003d[], project\u003d\u0027placement\u0027)"},{"line_number":90,"context_line":"    db_api.configure(config)"},{"line_number":91,"context_line":"    return upgradecheck.main("},{"line_number":92,"context_line":"        cfg.ConfigOpts(), project\u003d\u0027placement\u0027, upgrade_command\u003dChecks(config))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_6078b729","line":92,"in_reply_to":"9fdfeff1_9b319ca5","updated":"2019-01-25 05:58:03.000000000","message":"Thanks for trying to seek another way. Hmm, that\u0027s a good alternative unless it doesn\u0027t access to the private member. IMO, using two instances for ConfigOpts is not too bad because it is now local variable and because the roles of the two are different; parsing DB config vs. CLI arguments. I\u0027ve added comments.","commit_id":"461447e51cb9a6cc4e42388b49bd7f2de3b1d22e"}]}
