)]}'
{"placement/cmd/status.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"63359825ce8437da33e9f164465449ee1f60d6dd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    conf.register_opts(config)"},{"line_number":123,"context_line":"    # Register cli opts before parsing args."},{"line_number":124,"context_line":"    upgradecheck.register_cli_options(config, Checks(config))"},{"line_number":125,"context_line":"    config(args\u003dsys.argv[1:], project\u003d\u0027placement\u0027)"},{"line_number":126,"context_line":"    db_api.configure(config)"},{"line_number":127,"context_line":"    return upgradecheck.run(config)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_3dbb8872","line":125,"range":{"start_line":125,"start_character":16,"end_line":125,"end_character":28},"updated":"2019-01-28 21:05:19.000000000","message":"This is odd. Is this change necessary or incidental?","commit_id":"5df2f609fa980391cf567d70d94feeec692f9f19"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a4c4c67f080a3b26b591f0d41ce927e419d040cd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    conf.register_opts(config)"},{"line_number":123,"context_line":"    # Register cli opts before parsing args."},{"line_number":124,"context_line":"    upgradecheck.register_cli_options(config, Checks(config))"},{"line_number":125,"context_line":"    config(args\u003dsys.argv[1:], project\u003d\u0027placement\u0027)"},{"line_number":126,"context_line":"    db_api.configure(config)"},{"line_number":127,"context_line":"    return upgradecheck.run(config)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9d571427","line":125,"range":{"start_line":125,"start_character":16,"end_line":125,"end_character":28},"in_reply_to":"9fdfeff1_3dbb8872","updated":"2019-01-28 21:10:15.000000000","message":"Necessary. In the previous iteration we were saying that the placement-sourced ConfigOpts had no command line args but that the one used in oslo.upgradecheck did (if you look at upgradecheck.main that may make it more clear).\n\nSince we\u0027re now using only one ConfigOpts and doing parsing (which happens when you __call__ a ConfigOpts) we need to pass in the command line args ourselves, which are sys.argv[1:].","commit_id":"5df2f609fa980391cf567d70d94feeec692f9f19"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"951a466d4037e32aeb8a2cc0ec9cebc2b8d9dd69","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    conf.register_opts(config)"},{"line_number":123,"context_line":"    # Register cli opts before parsing args."},{"line_number":124,"context_line":"    upgradecheck.register_cli_options(config, Checks(config))"},{"line_number":125,"context_line":"    config(args\u003dsys.argv[1:], project\u003d\u0027placement\u0027)"},{"line_number":126,"context_line":"    db_api.configure(config)"},{"line_number":127,"context_line":"    return upgradecheck.run(config)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_197f22ac","line":125,"range":{"start_line":125,"start_character":16,"end_line":125,"end_character":28},"in_reply_to":"9fdfeff1_9d571427","updated":"2019-02-06 15:31:58.000000000","message":"Maybe a comment explaining that would be helpful. It wasn\u0027t clear to me why we needed the slice either.","commit_id":"5df2f609fa980391cf567d70d94feeec692f9f19"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"10d0ebc43b0bd0c3b3066585e251cc33058f2b4c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # A slice of sys.argv is provided to pass the command line"},{"line_number":126,"context_line":"    # arguments for processing, without the name of the calling"},{"line_number":127,"context_line":"    # script (\u0027placement-status\u0027). If we were using"},{"line_number":128,"context_line":"    # upgradecheck.main() directly, it would do it for us, but"},{"line_number":129,"context_line":"    # we do not because of the need to configure the database"},{"line_number":130,"context_line":"    # first."},{"line_number":131,"context_line":"    config(args\u003dsys.argv[1:], project\u003d\u0027placement\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_40628e18","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":57},"updated":"2019-02-06 16:41:21.000000000","message":"Ah, because main() takes an argv kwarg, which we didn\u0027t specify previously, which defaults to sys.argv[1:]\n\nhttps://github.com/openstack/oslo.upgradecheck/blob/master/oslo_upgradecheck/upgradecheck.py#L160\n\nThis makes more sense now.","commit_id":"7697161396fa0065946d09e950025ab94052b4dc"}]}