)]}'
{"api-ref/source/allocation_candidates.inc":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b5ec9c2cebb2ea77c65e3959423a5f3c1bddd04a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"},{"line_number":37,"context_line":"  - requiredN: required_traits_granular"},{"line_number":38,"context_line":"  - member_ofN: member_of_granular"},{"line_number":39,"context_line":"  - in_treeN: allocation_candidates_in_tree_granular"},{"line_number":40,"context_line":"  - group_policy: allocation_candidates_group_policy"},{"line_number":41,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9fdfeff1_beb3009a","line":39,"updated":"2019-02-25 17:21:25.000000000","message":"If we mentioned in_treeN here I think it is worth mentioning in the commit message too.","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"299fb5ea93b62b9b80334a711acd9cda4c5a0fcf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  - resourcesN: resources_query_granular"},{"line_number":37,"context_line":"  - requiredN: required_traits_granular"},{"line_number":38,"context_line":"  - member_ofN: member_of_granular"},{"line_number":39,"context_line":"  - in_treeN: allocation_candidates_in_tree_granular"},{"line_number":40,"context_line":"  - group_policy: allocation_candidates_group_policy"},{"line_number":41,"context_line":"  - limit: allocation_candidates_limit"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"9fdfeff1_b7cc8389","line":39,"in_reply_to":"9fdfeff1_beb3009a","updated":"2019-02-25 19:01:48.000000000","message":"Done","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98a198eae61ca0d6d2f3893ec74f6baa2d8930da","unresolved":false,"context_lines":[{"line_number":67,"context_line":"allocation_candidates_in_tree_granular:"},{"line_number":68,"context_line":"  \u003c\u003c: *allocation_candidates_in_tree"},{"line_number":69,"context_line":"  description: \u003e"},{"line_number":70,"context_line":"    A string representing a resource provider uuid. The parameter key is"},{"line_number":71,"context_line":"    ``in_treeN``, where ``N`` represents a positive integer suffix"},{"line_number":72,"context_line":"    corresponding with a ``resourcesN`` parameter. When supplied, it will"},{"line_number":73,"context_line":"    filter the returned allocation candidates for that numbered group to only"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fdfeff1_71c5c65b","line":70,"updated":"2019-02-25 21:38:44.000000000","message":"We could really benefit from some user API docs with example scenarios, similar to the tree in https://review.openstack.org/#/c/638712/3/placement/tests/functional/fixtures/gabbits.py and some of the gabbits - see my confusion in:\n\nhttps://review.openstack.org/#/c/638712/3/placement/tests/functional/gabbits/allocation-candidates.yaml@550\n\nAs an API user, I\u0027d much rather see an example topology with some sample queries against that topology and explain the results.","commit_id":"ce10de2a297b3e44c5a8f75311cedd4e167c02dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5b7460a329010dd5a7ea75c7fa0aa5a55a2569d8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"allocation_candidates_in_tree_granular:"},{"line_number":68,"context_line":"  \u003c\u003c: *allocation_candidates_in_tree"},{"line_number":69,"context_line":"  description: \u003e"},{"line_number":70,"context_line":"    A string representing a resource provider uuid. The parameter key is"},{"line_number":71,"context_line":"    ``in_treeN``, where ``N`` represents a positive integer suffix"},{"line_number":72,"context_line":"    corresponding with a ``resourcesN`` parameter. When supplied, it will"},{"line_number":73,"context_line":"    filter the returned allocation candidates for that numbered group to only"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_9e42970e","line":70,"in_reply_to":"5fc1f717_720b6429","updated":"2019-03-26 14:02:17.000000000","message":"Yeah, that\u0027ll work.","commit_id":"ce10de2a297b3e44c5a8f75311cedd4e167c02dd"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c69b33f5b85aa0430fa7f6e7fe644aabbe72658e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"allocation_candidates_in_tree_granular:"},{"line_number":68,"context_line":"  \u003c\u003c: *allocation_candidates_in_tree"},{"line_number":69,"context_line":"  description: \u003e"},{"line_number":70,"context_line":"    A string representing a resource provider uuid. The parameter key is"},{"line_number":71,"context_line":"    ``in_treeN``, where ``N`` represents a positive integer suffix"},{"line_number":72,"context_line":"    corresponding with a ``resourcesN`` parameter. When supplied, it will"},{"line_number":73,"context_line":"    filter the returned allocation candidates for that numbered group to only"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_720b6429","line":70,"in_reply_to":"5fc1f717_8d6598b7","updated":"2019-03-26 11:19:39.000000000","message":"This [2] could help, too.\n\n[2] https://review.openstack.org/#/c/647716/","commit_id":"ce10de2a297b3e44c5a8f75311cedd4e167c02dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c08d4f9d85851e43c082d6fb04f37bae3f9198d2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"allocation_candidates_in_tree_granular:"},{"line_number":68,"context_line":"  \u003c\u003c: *allocation_candidates_in_tree"},{"line_number":69,"context_line":"  description: \u003e"},{"line_number":70,"context_line":"    A string representing a resource provider uuid. The parameter key is"},{"line_number":71,"context_line":"    ``in_treeN``, where ``N`` represents a positive integer suffix"},{"line_number":72,"context_line":"    corresponding with a ``resourcesN`` parameter. When supplied, it will"},{"line_number":73,"context_line":"    filter the returned allocation candidates for that numbered group to only"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_8d6598b7","line":70,"in_reply_to":"9fdfeff1_71c5c65b","updated":"2019-03-25 23:45:36.000000000","message":"Tetsuro has proposed this [1]. Do we want to link it from here? (Is that a done thing?)\n\n\n[1] https://review.openstack.org/#/c/647309/","commit_id":"ce10de2a297b3e44c5a8f75311cedd4e167c02dd"}],"placement/lib.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2bcd5103772fa3246dc5485794a1a7c4aea2d69","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        :param required_traits: A set of { trait_name, ... }"},{"line_number":49,"context_line":"        :param forbidden_traits: A set of { trait_name, ... }"},{"line_number":50,"context_line":"        :param member_of: A list of [ [aggregate_UUID],"},{"line_number":51,"context_line":"                                      [aggregate_UUID, aggregate_UUID] ... ]"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        self.use_same_provider \u003d use_same_provider"},{"line_number":54,"context_line":"        self.resources \u003d resources or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_681bd57f","line":51,"updated":"2019-02-21 22:32:08.000000000","message":"doc in_tree","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"cf3f124651f495b22a520fcc4838fbf3bc0dd29d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        :param required_traits: A set of { trait_name, ... }"},{"line_number":49,"context_line":"        :param forbidden_traits: A set of { trait_name, ... }"},{"line_number":50,"context_line":"        :param member_of: A list of [ [aggregate_UUID],"},{"line_number":51,"context_line":"                                      [aggregate_UUID, aggregate_UUID] ... ]"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        self.use_same_provider \u003d use_same_provider"},{"line_number":54,"context_line":"        self.resources \u003d resources or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b874a6ff","line":51,"in_reply_to":"9fdfeff1_681bd57f","updated":"2019-02-22 09:07:52.000000000","message":"Done","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param forbidden_traits: A set of { trait_name, ... }"},{"line_number":50,"context_line":"        :param member_of: A list of [ [aggregate_UUID],"},{"line_number":51,"context_line":"                                      [aggregate_UUID, aggregate_UUID] ... ]"},{"line_number":52,"context_line":"        :param in_tree: A UUID of a resource provider"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self.use_same_provider \u003d use_same_provider"},{"line_number":55,"context_line":"        self.resources \u003d resources or {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_8c42bfaa","line":52,"updated":"2019-02-22 16:54:53.000000000","message":"...from whose tree this RequestGroup must be satisfied.\n\nAnd this one does *not* need to be a root, right?","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"}],"placement/microversion.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b5ec9c2cebb2ea77c65e3959423a5f3c1bddd04a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u00271.29\u0027,  # Support nested providers in GET /allocation_candidates API."},{"line_number":78,"context_line":"    \u00271.30\u0027,  # Add POST /reshaper for atomically migrating resource provider"},{"line_number":79,"context_line":"             # inventories and allocations."},{"line_number":80,"context_line":"    \u00271.31\u0027,  # Add in_tree queryparam on `GET /allocation_candidates` API"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_fe30a809","line":80,"updated":"2019-02-25 17:21:25.000000000","message":"nit: \"in_tree and in_treeN queryparams...\"","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"299fb5ea93b62b9b80334a711acd9cda4c5a0fcf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u00271.29\u0027,  # Support nested providers in GET /allocation_candidates API."},{"line_number":78,"context_line":"    \u00271.30\u0027,  # Add POST /reshaper for atomically migrating resource provider"},{"line_number":79,"context_line":"             # inventories and allocations."},{"line_number":80,"context_line":"    \u00271.31\u0027,  # Add in_tree queryparam on `GET /allocation_candidates` API"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_f728cb33","line":80,"in_reply_to":"9fdfeff1_fe30a809","updated":"2019-02-25 19:01:48.000000000","message":"Done","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"}],"placement/rest_api_version_history.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ffaa32d80fa6321434dc2c6f7c39cb3f3a719446","unresolved":false,"context_lines":[{"line_number":526,"context_line":"Add support for the ``in_tree`` query parameter to the ``GET"},{"line_number":527,"context_line":"/allocation_candidates`` API. It accepts a UUID for a resource provider."},{"line_number":528,"context_line":"If this parameter is provided, the only resource providers returned will be"},{"line_number":529,"context_line":"those with the same tree with the given resource provider."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_359d6657","line":529,"updated":"2019-02-19 11:28:51.000000000","message":"Perhaps mention in_treeN here too","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2bcd5103772fa3246dc5485794a1a7c4aea2d69","unresolved":false,"context_lines":[{"line_number":526,"context_line":"Add support for the ``in_tree`` query parameter to the ``GET"},{"line_number":527,"context_line":"/allocation_candidates`` API. It accepts a UUID for a resource provider."},{"line_number":528,"context_line":"If this parameter is provided, the only resource providers returned will be"},{"line_number":529,"context_line":"those with the same tree with the given resource provider."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_8805d916","line":529,"range":{"start_line":529,"start_character":6,"end_line":529,"end_character":10},"updated":"2019-02-21 22:32:08.000000000","message":"in","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"cf3f124651f495b22a520fcc4838fbf3bc0dd29d","unresolved":false,"context_lines":[{"line_number":526,"context_line":"Add support for the ``in_tree`` query parameter to the ``GET"},{"line_number":527,"context_line":"/allocation_candidates`` API. It accepts a UUID for a resource provider."},{"line_number":528,"context_line":"If this parameter is provided, the only resource providers returned will be"},{"line_number":529,"context_line":"those with the same tree with the given resource provider."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_65369b54","line":529,"in_reply_to":"9fdfeff1_359d6657","updated":"2019-02-22 09:07:52.000000000","message":"Done","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"cf3f124651f495b22a520fcc4838fbf3bc0dd29d","unresolved":false,"context_lines":[{"line_number":526,"context_line":"Add support for the ``in_tree`` query parameter to the ``GET"},{"line_number":527,"context_line":"/allocation_candidates`` API. It accepts a UUID for a resource provider."},{"line_number":528,"context_line":"If this parameter is provided, the only resource providers returned will be"},{"line_number":529,"context_line":"those with the same tree with the given resource provider."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_053d4f2b","line":529,"range":{"start_line":529,"start_character":6,"end_line":529,"end_character":10},"in_reply_to":"9fdfeff1_8805d916","updated":"2019-02-22 09:07:52.000000000","message":"Done","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":526,"context_line":"Add support for the ``in_tree`` query parameter to the ``GET"},{"line_number":527,"context_line":"/allocation_candidates`` API. It accepts a UUID for a resource provider."},{"line_number":528,"context_line":"If this parameter is provided, the only resource providers returned will be"},{"line_number":529,"context_line":"those in the same tree with the given resource provider. The the numbered"},{"line_number":530,"context_line":"syntax ``in_treeN`` is also supported. If this is specified, the tree filter"},{"line_number":531,"context_line":"is only applied to the N\u0027th granular resource request and you often get the"},{"line_number":532,"context_line":"only resource providers in the same tree in the same way you specify"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_f7a9d48f","line":529,"range":{"start_line":529,"start_character":61,"end_line":529,"end_character":64},"updated":"2019-02-22 16:54:53.000000000","message":"strike","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":535,"context_line":"(e.g. DISK_GB) from a specific sharing resource provider (e.g. shared"},{"line_number":536,"context_line":"storage), you must specify the sharing provider using the numbered syntax"},{"line_number":537,"context_line":"``in_treeN`` so as to also get non-shared resource (e.g. VCPU) from another"},{"line_number":538,"context_line":"tree (e.g. compute node):"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"``?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:100\u0026in_tree1\u003d\u003css_uuid\u003e``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_977ac8b7","line":538,"updated":"2019-02-22 16:54:53.000000000","message":"Ah, good explanation of the sharing use case.\n\nThe wording here is a bit awkward (though excellent as usual for a non-native English speaker). Let me try:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nThe numbered syntax ``in_treeN`` is also supported. This restricts providers satisfying the Nth granular request group to the tree of the specified provider. This may be redundant with other ``in_tree[N]`` values specified in other groups (including the unnumbered group). However, it can be useful in cases where a specific resource (e.g. DISK_GB) needs to come from a specific sharing provider (e.g. shared storage).\n\nFor example, a request for ``VCPU`` and ``VGPU`` resources from ``myhost`` and ``DISK_GB`` resources from ``sharing1`` might look like::\n\n  ?resources\u003dVCPU:1\u0026in_tree\u003d\u003cmyhost_uuid\u003e\n  \u0026resources1\u003dVGPU:1\u0026in_tree1\u003d\u003cmyhost_uuid\u003e\n  \u0026resources2\u003dDISK_GB:100\u0026in_tree2\u003d\u003csharing1_uuid\u003e\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nChris, Jay, please refine?","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"}],"placement/tests/functional/gabbits/allocation-candidates.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2bcd5103772fa3246dc5485794a1a7c4aea2d69","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    - \"Invalid query string parameters\""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"- name: get allocation candidates in tree with invalid uuid"},{"line_number":427,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1,SRIOV_NET_VF:4\u0026in_tree\u003dlife-is-beautiful"},{"line_number":428,"context_line":"  status: 400"},{"line_number":429,"context_line":"  request_headers:"},{"line_number":430,"context_line":"      openstack-api-version: placement 1.31"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_1307da1a","line":427,"range":{"start_line":427,"start_character":70,"end_line":427,"end_character":87},"updated":"2019-02-21 22:32:08.000000000","message":"aww","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":463,"context_line":"  response_strings:"},{"line_number":464,"context_line":"    - \"All request groups must specify resources.\""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"- name: get allocation candidates in tree granular root 1"},{"line_number":467,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026in_tree1\u003d$ENVIRON[\u0027PF1_1_UUID\u0027]"},{"line_number":468,"context_line":"  status: 200"},{"line_number":469,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_f7123462","line":466,"range":{"start_line":466,"start_character":51,"end_line":466,"end_character":57},"updated":"2019-02-22 16:54:53.000000000","message":"this confused me, since you\u0027re using in_tree\u003d\u003cnon-root\u003e. You mean that the *resource* you\u0027re requesting comes from the root?","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":472,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":473,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"- name: get allocation candidates in tree granular root 2"},{"line_number":476,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026in_tree1\u003d$ENVIRON[\u0027PF1_1_UUID\u0027]"},{"line_number":477,"context_line":"  status: 200"},{"line_number":478,"context_line":"  request_headers:"},{"line_number":479,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":480,"context_line":"  response_json_paths:"},{"line_number":481,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":482,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"- name: get allocation candidates in tree granular child 1"},{"line_number":485,"context_line":"  GET: /allocation_candidates?resources1\u003dSRIOV_NET_VF:4\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_d707f01c","line":482,"range":{"start_line":475,"start_character":0,"end_line":482,"end_character":80},"updated":"2019-02-22 16:54:53.000000000","message":"This is the same as the previous.\n\n[Later] looking at the next two, I surmise you intended to use in_tree\u003d\u003cCN1_UUID\u003e in one of them.","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d06cad980dc5dd9647b85b44f5084018421e18b0","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  request_headers:"},{"line_number":476,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":477,"context_line":"  response_json_paths:"},{"line_number":478,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":479,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":480,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":481,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":482,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.DISK_GB: 10"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_1eefbee9","line":479,"range":{"start_line":478,"start_character":0,"end_line":479,"end_character":39},"updated":"2019-02-24 16:32:14.000000000","message":"Oh, that\u0027s interesting. I wonder if that\u0027s what we want to do here.\n\nThinking about the use cases, I\u0027m going to say yes. If you\u0027re using ?in_tree it\u0027s because you already know where you want the resources to come from, so if the disk is shared you should know that you want the disk to come from the sharing provider.\n\nThis still allows us to express a request like \"Give me CPU from tree `cnX` and disk from I-don\u0027t-care-where\" as:\n\n ?resources\u003dVCPU:1\u0026in_tree\u003dcnX\n \u0026resources1\u003dDISK_GB:100\n \u0026group_policy\u003dnone\n\nWhen you do your refresh of the spec, please include this detail.\n\n[Later] Please add a test case for this; I didn\u0027t see one below.","commit_id":"aa1f9a5215317ca5706041caececbf33e4b1de8b"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"6a2a1497178445f63986e2a3692a00e5ef00a22f","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  request_headers:"},{"line_number":476,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":477,"context_line":"  response_json_paths:"},{"line_number":478,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":479,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":480,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":481,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":482,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.DISK_GB: 10"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_378c25d6","line":479,"range":{"start_line":478,"start_character":0,"end_line":479,"end_character":39},"in_reply_to":"9fdfeff1_1eefbee9","updated":"2019-02-25 03:55:01.000000000","message":"I think that\u0027s \"get allocation candidates in tree granular compute\", so I added some comments, and... yes, the spec needs to be updated. I\u0027ll update it soon.","commit_id":"aa1f9a5215317ca5706041caececbf33e4b1de8b"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"7d413852c14797004ab67d943f0630504ae2fe62","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  request_headers:"},{"line_number":476,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":477,"context_line":"  response_json_paths:"},{"line_number":478,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":479,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":480,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":481,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":482,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.DISK_GB: 10"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_430c8b41","line":479,"range":{"start_line":478,"start_character":0,"end_line":479,"end_character":39},"in_reply_to":"9fdfeff1_378c25d6","updated":"2019-02-25 09:19:25.000000000","message":"Spec proposed in https://review.openstack.org/#/c/639033/","commit_id":"aa1f9a5215317ca5706041caececbf33e4b1de8b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d06cad980dc5dd9647b85b44f5084018421e18b0","unresolved":false,"context_lines":[{"line_number":529,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"- name: get allocation candidates in tree granular child resource 2"},{"line_number":532,"context_line":"  GET: /allocation_candidates?resources1\u003dSRIOV_NET_VF:4\u0026in_tree1\u003d$ENVIRON[\u0027PF1_1_UUID\u0027]"},{"line_number":533,"context_line":"  status: 200"},{"line_number":534,"context_line":"  request_headers:"},{"line_number":535,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":536,"context_line":"  response_json_paths:"},{"line_number":537,"context_line":"    $.allocation_requests.`len`: 2"},{"line_number":538,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":539,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"- name: get allocation candidates in tree granular local storage 1"},{"line_number":542,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_beb792f5","line":539,"range":{"start_line":532,"start_character":0,"end_line":539,"end_character":90},"updated":"2019-02-24 16:32:14.000000000","message":"Yeah, eventually we\u0027re going to have to address this. \"Intuitively\", the user could expect that if they say ?in_tree\u003dPF1, the would only get their VFs from PF1. This is probably going to have to be solved with affinity rather than in_tree, with plenty of docs comparing and contrasting the scenarios.","commit_id":"aa1f9a5215317ca5706041caececbf33e4b1de8b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0d7a4503f7571b37b4d26839227a3b5e1fb247b1","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027SS_UUID\u0027]\"].resources.DISK_GB: 10"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"- name: get allocation candidates in tree granular compute 2"},{"line_number":584,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026in_tree\u003d$ENVIRON[\u0027CN2_UUID\u0027]\u0026resources1\u003dDISK_GB:10"},{"line_number":585,"context_line":"  status: 200"},{"line_number":586,"context_line":"  request_headers:"},{"line_number":587,"context_line":"      openstack-api-version: placement 1.31"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_82734ce7","line":584,"range":{"start_line":584,"start_character":76,"end_line":584,"end_character":86},"updated":"2019-02-25 11:10:42.000000000","message":"Thanks. I recognize that the previous case had the same sumac, but this one had two places it could *actually* get disk from.","commit_id":"e66bb0dfc3f8f77bbac271f4f038545fbc96220f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b5ec9c2cebb2ea77c65e3959423a5f3c1bddd04a","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":509,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"- name: get allocation candidates in tree granular root resource 2"},{"line_number":512,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026in_tree1\u003d$ENVIRON[\u0027PF1_1_UUID\u0027]"},{"line_number":513,"context_line":"  status: 200"},{"line_number":514,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_de46047c","line":511,"range":{"start_line":511,"start_character":56,"end_line":511,"end_character":66},"updated":"2019-02-25 17:21:25.000000000","message":"It took me a while to realize that this was the second test, not a test about resources2. If there\u0027s a new version that might be clarified.","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"299fb5ea93b62b9b80334a711acd9cda4c5a0fcf","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":509,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"- name: get allocation candidates in tree granular root resource 2"},{"line_number":512,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026in_tree1\u003d$ENVIRON[\u0027PF1_1_UUID\u0027]"},{"line_number":513,"context_line":"  status: 200"},{"line_number":514,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_97e61f16","line":511,"range":{"start_line":511,"start_character":56,"end_line":511,"end_character":66},"in_reply_to":"9fdfeff1_de46047c","updated":"2019-02-25 19:01:48.000000000","message":"Done","commit_id":"28864a7e4792586197b5c59efc8cc9819ae959fc"}],"releasenotes/notes/alloc-candidates-in-tree-f69b0de5ba33096b.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ffaa32d80fa6321434dc2c6f7c39cb3f3a719446","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``GET /allocation_candidates`` API. When supplied, it will filter the"},{"line_number":7,"context_line":"    returned allocation candidates to only those resource providers that"},{"line_number":8,"context_line":"    are associated with the same tree similarly to the ``in_tree`` query"},{"line_number":9,"context_line":"    parameter in the ``GET /resource_providers`` API."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_55e4aae0","line":9,"updated":"2019-02-19 11:28:51.000000000","message":"in_treeN?","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"cf3f124651f495b22a520fcc4838fbf3bc0dd29d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``GET /allocation_candidates`` API. When supplied, it will filter the"},{"line_number":7,"context_line":"    returned allocation candidates to only those resource providers that"},{"line_number":8,"context_line":"    are associated with the same tree similarly to the ``in_tree`` query"},{"line_number":9,"context_line":"    parameter in the ``GET /resource_providers`` API."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_25389339","line":9,"in_reply_to":"9fdfeff1_55e4aae0","updated":"2019-02-22 09:07:52.000000000","message":"Done","commit_id":"98d445dc5ad7844e45640b0cf66672a120c7757f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8577fb6c400aa10c7a832cb6ae0d6a61724b9119","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    numbered syntax ``in_treeN`` so as to also get non-shared resource"},{"line_number":18,"context_line":"    (e.g. VCPU) from another tree (e.g. compute node):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    ``?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:100\u0026in_tree1\u003d\u003css_uuid\u003e``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_b8ad79eb","line":20,"updated":"2019-02-22 16:54:53.000000000","message":"copy/paste whatever we end up with from the microversion history","commit_id":"64dbabd0a99a5fa22b1f668563293117e557a7f8"}]}
