)]}'
{"placement/objects/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"460f3c5622a84facf7b38ad4fa0b0067ad0beeb5","unresolved":false,"context_lines":[{"line_number":2638,"context_line":"        if self.id is not None:"},{"line_number":2639,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":2640,"context_line":"                                              reason\u003d\u0027already created\u0027)"},{"line_number":2641,"context_line":"        if not self.name:"},{"line_number":2642,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":2643,"context_line":"                                              reason\u003d\u0027name is required\u0027)"},{"line_number":2644,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_d393084e","line":2641,"updated":"2019-02-15 17:10:01.000000000","message":"is None","commit_id":"8ab441e7b0d603f9710fba7532dea1b8e59686a4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0e492abb645609944b0990e8183cc25c0f958801","unresolved":false,"context_lines":[{"line_number":2638,"context_line":"        if self.id is not None:"},{"line_number":2639,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":2640,"context_line":"                                              reason\u003d\u0027already created\u0027)"},{"line_number":2641,"context_line":"        if not self.name:"},{"line_number":2642,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":2643,"context_line":"                                              reason\u003d\u0027name is required\u0027)"},{"line_number":2644,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_369922c3","line":2641,"in_reply_to":"9fdfeff1_d393084e","updated":"2019-02-15 17:40:02.000000000","message":"changed my mind, we don\u0027t want an empty string either","commit_id":"8ab441e7b0d603f9710fba7532dea1b8e59686a4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2c6b4c9dc8c707c2af572e0f536e0f5b0d2bb31d","unresolved":false,"context_lines":[{"line_number":2623,"context_line":"        self.updated_at \u003d updated_at"},{"line_number":2624,"context_line":"        self.created_at \u003d created_at"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"    # FIXME(cdent): Duped from resource_class."},{"line_number":2627,"context_line":"    @staticmethod"},{"line_number":2628,"context_line":"    def _from_db_object(context, target, source):"},{"line_number":2629,"context_line":"        target._context \u003d context"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_d309242b","line":2626,"updated":"2019-02-25 13:00:27.000000000","message":"not sure we need to fix this... it\u0027s explicit and fine by me :)","commit_id":"dc4c711029894cf2dcde8d113d578d85593e89dc"}],"placement/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5b282c318b676e51fb23a3bae86d9531c6d2a7b9","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"        t \u003d rp_obj.Trait(self.ctx)"},{"line_number":2171,"context_line":"        t.name \u003d \u0027CUSTOM_TRAIT_A\u0027"},{"line_number":2172,"context_line":"        t.create()"},{"line_number":2173,"context_line":"        self.assertIn(\u0027id\u0027, t)"},{"line_number":2174,"context_line":"        self.assertEqual(t.name, \u0027CUSTOM_TRAIT_A\u0027)"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"    def test_trait_create_with_id_set(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_9b87a113","side":"PARENT","line":2173,"range":{"start_line":2173,"start_character":8,"end_line":2173,"end_character":30},"updated":"2019-02-19 13:29:19.000000000","message":"This statement checks whether \u0027id\u0027 is set after the \u0027create\u0027 method is called.\nSo it should be \u0027self.assertIsNotNone(t.id)\u0027 instead of removing it.","commit_id":"778bd096cbc3aa333879d564ea9f30217366ef59"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f802674aac25220428464deee2bacb13477fda2c","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"        t \u003d rp_obj.Trait(self.ctx)"},{"line_number":2171,"context_line":"        t.name \u003d \u0027CUSTOM_TRAIT_A\u0027"},{"line_number":2172,"context_line":"        t.create()"},{"line_number":2173,"context_line":"        self.assertIn(\u0027id\u0027, t)"},{"line_number":2174,"context_line":"        self.assertEqual(t.name, \u0027CUSTOM_TRAIT_A\u0027)"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"    def test_trait_create_with_id_set(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_61ad0fe9","side":"PARENT","line":2173,"range":{"start_line":2173,"start_character":8,"end_line":2173,"end_character":30},"in_reply_to":"9fdfeff1_9b87a113","updated":"2019-02-24 19:27:51.000000000","message":"Good catch.","commit_id":"778bd096cbc3aa333879d564ea9f30217366ef59"}]}
