)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bfaca1c484dc3d1bfb9b3d8905cc24d61d69811e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"affect the repr() of some *List classes that didn\u0027t previously override"},{"line_number":14,"context_line":"__repr__. Since the repr is just used to make pretty logs/errors, this"},{"line_number":15,"context_line":"should be copacetic. (Besides, I\u0027m pretty sure we wildly changed the"},{"line_number":16,"context_line":"default __repr__ when we de-OVO-ified.)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia35403c5fe2afefd9b8d077b36561963abe16b34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_50f5c1c9","line":16,"updated":"2019-02-16 13:04:03.000000000","message":"yeah, I agree that it is OK","commit_id":"8442420d35cbb4378cd766f047c1c8c16fa28c93"}],"placement/objects/common.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bfaca1c484dc3d1bfb9b3d8905cc24d61d69811e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return self.objects[index]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __repr__(self):"},{"line_number":27,"context_line":"        strings \u003d [repr(x) for x in self.objects]"},{"line_number":28,"context_line":"        return \"%s[%s]\" % (self.__class__.__name__, \", \".join(strings))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d03211a7","line":27,"updated":"2019-02-16 13:04:03.000000000","message":"this is not ideal for any list that is long which most of them will be in a big cloud\n\nthis is a persistent challenge with this sort of thing: we need way to summarize the list, not verbosely enumerate it","commit_id":"8442420d35cbb4378cd766f047c1c8c16fa28c93"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"599e32df3d85c7364f1cbe18256fb99eaf8daee6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return self.objects[index]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __repr__(self):"},{"line_number":27,"context_line":"        strings \u003d [repr(x) for x in self.objects]"},{"line_number":28,"context_line":"        return \"%s[%s]\" % (self.__class__.__name__, \", \".join(strings))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c819057a","line":27,"in_reply_to":"9fdfeff1_abf1206d","updated":"2019-02-17 11:11:26.000000000","message":"That would potentially be a good idea except that many installations run with debug enabled all the time because you don\u0027t know you needed it until after you already needed it.\n\nWhich is part of why these kinds of logs message present a problem: they need to be sufficiently informative to be useful, but not so long as to break stuff.\n\nGiven that, Allocation * 12 is potentially insufficient, but, for example a vmware or powervm hypervisor, fully description of the allocations on a resource provider is overwhelming. A middle of the road option might be the the external id of whatever the thing being listed is.\n\nNot really sure.","commit_id":"8442420d35cbb4378cd766f047c1c8c16fa28c93"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fb07557b3045db2ca8c61551606ca1669a234d7f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return self.objects[index]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __repr__(self):"},{"line_number":27,"context_line":"        strings \u003d [repr(x) for x in self.objects]"},{"line_number":28,"context_line":"        return \"%s[%s]\" % (self.__class__.__name__, \", \".join(strings))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_abf1206d","line":27,"in_reply_to":"9fdfeff1_d03211a7","updated":"2019-02-16 18:31:17.000000000","message":"mm. What about\n\n \"%s[%s * %d]\" % (self.__class__.__name__, self.ITEM_CLS.__name__, len(self))\n\nE.g. \"AllocationList[Allocation * 12]\"\n\nAnother idea is to condition the \"thoroughness\" of the repr on some flag, like LOG.is_debug_enabled().","commit_id":"8442420d35cbb4378cd766f047c1c8c16fa28c93"}]}
