)]}'
{"placement/tests/functional/fixtures/gabbits.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_91df0a65","line":194,"range":{"start_line":194,"start_character":53,"end_line":194,"end_character":74},"updated":"2019-02-25 21:33:06.000000000","message":"This is also old - cn2 has local storage and is connected to two shared storage providers.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_51a0c2f4","line":194,"range":{"start_line":194,"start_character":30,"end_line":194,"end_character":38},"updated":"2019-02-25 21:33:06.000000000","message":"wuh?","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_91706a42","line":194,"range":{"start_line":194,"start_character":30,"end_line":194,"end_character":38},"in_reply_to":"9fdfeff1_51a0c2f4","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_51944237","line":194,"range":{"start_line":194,"start_character":53,"end_line":194,"end_character":74},"in_reply_to":"9fdfeff1_91df0a65","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_71b4e636","line":195,"range":{"start_line":195,"start_character":31,"end_line":195,"end_character":42},"updated":"2019-02-25 21:33:06.000000000","message":"this is no longer singular","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class SharedStorageFixture(APIFixture):"},{"line_number":194,"context_line":"    \"\"\"An APIFixture that has some two compute nodes without local storage"},{"line_number":195,"context_line":"    associated by aggregate to a provider of shared storage. Both compute"},{"line_number":196,"context_line":"    nodes have respectively two numa node resource providers, each of"},{"line_number":197,"context_line":"    which has a pf resource provider."},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f1945638","line":195,"range":{"start_line":195,"start_character":31,"end_line":195,"end_character":42},"in_reply_to":"9fdfeff1_71b4e636","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db4ec5ad310a7e294ccfee6ec6a04bd0f8f15be2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +----------------+--------+    |   +----------------+--------+"},{"line_number":204,"context_line":"                                       | aggregate"},{"line_number":205,"context_line":"        +--------------------------+   |   +------------------------+"},{"line_number":206,"context_line":"        | compute node (cn1)       |---+---| compute node (cn2)     |"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_510a02d2","line":203,"range":{"start_line":203,"start_character":25,"end_line":203,"end_character":26},"updated":"2019-02-25 21:34:10.000000000","message":"-","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db4ec5ad310a7e294ccfee6ec6a04bd0f8f15be2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +----------------+--------+    |   +----------------+--------+"},{"line_number":204,"context_line":"                                       | aggregate"},{"line_number":205,"context_line":"        +--------------------------+   |   +------------------------+"},{"line_number":206,"context_line":"        | compute node (cn1)       |---+---| compute node (cn2)     |"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f10a16cf","line":203,"range":{"start_line":203,"start_character":60,"end_line":203,"end_character":61},"updated":"2019-02-25 21:34:10.000000000","message":"-","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +----------------+--------+    |   +----------------+--------+"},{"line_number":204,"context_line":"                                       | aggregate"},{"line_number":205,"context_line":"        +--------------------------+   |   +------------------------+"},{"line_number":206,"context_line":"        | compute node (cn1)       |---+---| compute node (cn2)     |"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b1a24e99","line":203,"range":{"start_line":203,"start_character":25,"end_line":203,"end_character":26},"in_reply_to":"9fdfeff1_510a02d2","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +----------------+--------+    |   +----------------+--------+"},{"line_number":204,"context_line":"                                       | aggregate"},{"line_number":205,"context_line":"        +--------------------------+   |   +------------------------+"},{"line_number":206,"context_line":"        | compute node (cn1)       |---+---| compute node (cn2)     |"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d19fd24d","line":203,"range":{"start_line":203,"start_character":60,"end_line":203,"end_character":61},"in_reply_to":"9fdfeff1_f10a16cf","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"9e2227e420c1cf063c102141e8ffb8296e0a946b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    of which has a pf resource provider."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        +-------------------------+        +-------------------------+"},{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +-------------------------+    |   +-------------------------+"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_3f7618a6","line":200,"range":{"start_line":200,"start_character":26,"end_line":200,"end_character":30},"updated":"2019-02-26 12:37:45.000000000","message":"Super itty-bitty nit: We have cn1 \u0026 cn2, numa1_1, pf1_1, etc. Seems odd to have \u0027ss\u0027 and \u0027ss2\u0027 instead of \u0027ss1\u0027 and \u0027ss2\u0027. But I probably won\u0027t lose too much sleep over this.","commit_id":"fbc694080420f4dc4708e96b368cd53f36cc0801"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1691687e9410645f3fab880b8ec7ff94fa5ab1be","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    of which has a pf resource provider."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        +-------------------------+        +-------------------------+"},{"line_number":200,"context_line":"        | sharing storage (ss)    |        | sharing storage (ss2)   |"},{"line_number":201,"context_line":"        |  DISK_GB:2000           |----+---|  DISK_GB:2000           |"},{"line_number":202,"context_line":"        |  traits: MISC_SHARES... |    |   |  traits: MISC_SHARES... |"},{"line_number":203,"context_line":"        +-------------------------+    |   +-------------------------+"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_5bf3ef09","line":200,"range":{"start_line":200,"start_character":26,"end_line":200,"end_character":30},"in_reply_to":"9fdfeff1_3f7618a6","updated":"2019-02-26 13:35:40.000000000","message":"Yeah, deliberate decision, didn\u0027t want to have to rename it everywhere.","commit_id":"fbc694080420f4dc4708e96b368cd53f36cc0801"}],"placement/tests/functional/gabbits/allocation-candidates.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":485,"context_line":"  request_headers:"},{"line_number":486,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":487,"context_line":"  response_json_paths:"},{"line_number":488,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":489,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":490,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":491,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_71bb860e","line":488,"range":{"start_line":488,"start_character":43,"end_line":488,"end_character":47},"updated":"2019-02-25 21:33:06.000000000","message":"Or SS2 right?","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"  request_headers:"},{"line_number":486,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":487,"context_line":"  response_json_paths:"},{"line_number":488,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":489,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":490,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":491,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_f1ad3684","line":488,"range":{"start_line":488,"start_character":43,"end_line":488,"end_character":47},"in_reply_to":"9fdfeff1_51c1a253","updated":"2019-02-25 21:52:23.000000000","message":"Done","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"708ace791adeacf2b4ed5cfb2588e76f55489d01","unresolved":false,"context_lines":[{"line_number":485,"context_line":"  request_headers:"},{"line_number":486,"context_line":"      openstack-api-version: placement 1.31"},{"line_number":487,"context_line":"  response_json_paths:"},{"line_number":488,"context_line":"    # CN2 has local disk, but we don\u0027t get SS\u0027s disk"},{"line_number":489,"context_line":"    # because it\u0027s out of the CN2 tree."},{"line_number":490,"context_line":"    $.allocation_requests.`len`: 1"},{"line_number":491,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_51c1a253","line":488,"range":{"start_line":488,"start_character":43,"end_line":488,"end_character":47},"in_reply_to":"9fdfeff1_71bb860e","updated":"2019-02-25 21:39:40.000000000","message":"True, will fix.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates in tree granular local storage 1"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_d1703275","line":550,"updated":"2019-02-25 21:33:06.000000000","message":"Can someone explain the difference between \"get allocation candidates in tree granular compute 1\" and this? In this test we get nothing back because \"# CN1 has no local storage\" but in the other test we get cn1 back for VCPU and the 2 shared storage providers for the DISK_GB request, but what is the difference? Does the actual order of the parameters have a semantic difference in the request? If so, yikes....I hope that\u0027s clearly documented.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"708ace791adeacf2b4ed5cfb2588e76f55489d01","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates in tree granular local storage 1"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_d1ccb28a","line":550,"in_reply_to":"9fdfeff1_312e5e43","updated":"2019-02-25 21:39:40.000000000","message":"right","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b51db1ea7b61a867d7fb44726d34df41f7d3e1a","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates in tree granular local storage 1"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_312e5e43","line":550,"in_reply_to":"9fdfeff1_d1703275","updated":"2019-02-25 21:36:02.000000000","message":"Oh I see, in_tree1 vs in_tree, so resources1 for DISK_GB has to come from in_tree1 which is CN1, which doesn\u0027t have DISK_GB.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26c183d6a355bd5118819d2446ec90b61cfa499f","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates in tree granular local storage 1"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_916f0a27","line":550,"in_reply_to":"9fdfeff1_d1ccb28a","updated":"2019-02-25 21:52:23.000000000","message":"Did some renaming of test cases to hopefully make things clearer.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c6f8dd0735c4f6409436a4ca7f775f9fe892b1b","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":567,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.DISK_GB: 10"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"# Practical usage for \"Give me DISK_GB from SS and VCPU from I-don\u0027t-care-where\""},{"line_number":570,"context_line":"- name: get allocation candidates in tree granular shared storage"},{"line_number":571,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027SS_UUID\u0027]"},{"line_number":572,"context_line":"  status: 200"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_513c4292","line":569,"updated":"2019-02-25 21:33:06.000000000","message":"Should you have a test like this with SS2?","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"708ace791adeacf2b4ed5cfb2588e76f55489d01","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":567,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027CN2_UUID\u0027]\"].resources.DISK_GB: 10"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"# Practical usage for \"Give me DISK_GB from SS and VCPU from I-don\u0027t-care-where\""},{"line_number":570,"context_line":"- name: get allocation candidates in tree granular shared storage"},{"line_number":571,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027SS_UUID\u0027]"},{"line_number":572,"context_line":"  status: 200"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_11deba3d","line":569,"in_reply_to":"9fdfeff1_513c4292","updated":"2019-02-25 21:39:40.000000000","message":"Would be testing the same thing, nah?","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b51db1ea7b61a867d7fb44726d34df41f7d3e1a","unresolved":false,"context_lines":[{"line_number":580,"context_line":""},{"line_number":581,"context_line":"# Practical usage for \"Give me VCPU from CN1 and DISK_GB from I-don\u0027t-care-where\""},{"line_number":582,"context_line":"- name: get allocation candidates in tree granular compute 1"},{"line_number":583,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026in_tree\u003d$ENVIRON[\u0027CN1_UUID\u0027]\u0026resources1\u003dDISK_GB:10"},{"line_number":584,"context_line":"  status: 200"},{"line_number":585,"context_line":"  request_headers:"},{"line_number":586,"context_line":"      openstack-api-version: placement 1.31"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_9114eaea","line":583,"range":{"start_line":583,"start_character":47,"end_line":583,"end_character":54},"updated":"2019-02-25 21:36:02.000000000","message":"And the \"I don\u0027t care where\" is because this is unnumbered.","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"708ace791adeacf2b4ed5cfb2588e76f55489d01","unresolved":false,"context_lines":[{"line_number":580,"context_line":""},{"line_number":581,"context_line":"# Practical usage for \"Give me VCPU from CN1 and DISK_GB from I-don\u0027t-care-where\""},{"line_number":582,"context_line":"- name: get allocation candidates in tree granular compute 1"},{"line_number":583,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026in_tree\u003d$ENVIRON[\u0027CN1_UUID\u0027]\u0026resources1\u003dDISK_GB:10"},{"line_number":584,"context_line":"  status: 200"},{"line_number":585,"context_line":"  request_headers:"},{"line_number":586,"context_line":"      openstack-api-version: placement 1.31"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_b1948e45","line":583,"range":{"start_line":583,"start_character":47,"end_line":583,"end_character":54},"in_reply_to":"9fdfeff1_9114eaea","updated":"2019-02-25 21:39:40.000000000","message":"Well, yes, but more precisely because we *didn\u0027t* specify an in_tree for the group requesting the disk (i.e. group 1).","commit_id":"ae8e570876cc566ca2a0bbdd591dd873a6240fac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f8cbb97f24a83af2d83456d31297612e2ca37df0","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates, in tree granular local storage doesn\u0027t exist"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_1471c8a8","line":550,"range":{"start_line":550,"start_character":71,"end_line":550,"end_character":72},"updated":"2019-02-25 22:05:56.000000000","message":"Kind of surprised you can have punctuation marks and such (comma etc) in these test names but I guess they get handled.","commit_id":"aaed691b59f4ded78b9c4970807343de61a30dcd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5fd948a7b4cf10a231d48621e5edb460383e5c17","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates, in tree granular local storage doesn\u0027t exist"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_b4555c52","line":550,"range":{"start_line":550,"start_character":71,"end_line":550,"end_character":72},"in_reply_to":"9fdfeff1_1471c8a8","updated":"2019-02-25 22:34:53.000000000","message":"It does work, mostly because from the point of view of test runners nearly everything is done by reference, not name; the name is mostly for reporting and listing.\n\nBut it\u0027s not a great idea because it make it harder to do things like select a single test to run because of the multiple layers of tooling and processes involved. For example, if you wanted to run just this test, and select it by its full name, I don\u0027t know if it could work. I got shlex errors.\n\nGabbi itself doesn\u0027t try to fix the names because it\u0027s trying to not be in the business of accounting for every test runner and in any case, there\u0027s the \u0027desc\u0027 field and comments if people want to get into this level of detail. It\u0027s just supposed to be a short, unique name...\n\nSo: while this does \"work\", if we want to preserve test selectability, it\u0027s probably not good to punctuate in any form.","commit_id":"aaed691b59f4ded78b9c4970807343de61a30dcd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3740e5d149f6a2c8471f4a1e8ce2ac0f34f30cf4","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates, in tree granular local storage doesn\u0027t exist"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_f4fbe477","line":550,"range":{"start_line":550,"start_character":71,"end_line":550,"end_character":72},"in_reply_to":"9fdfeff1_1471c8a8","updated":"2019-02-25 22:26:49.000000000","message":"Yeah, it converts spaces, but doesn\u0027t seem to care about the comma or apostrophe:\n\n placement.tests.functional.test_api.allocation-candidates_get_allocation_candidates,_in_tree_granular_local_storage_doesn\u0027t_exist.test_request","commit_id":"aaed691b59f4ded78b9c4970807343de61a30dcd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da53fcc915cb50808edfeac29efbc8ca4efeb49e","unresolved":false,"context_lines":[{"line_number":547,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_1_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":548,"context_line":"    $.allocation_requests..allocations[\"$ENVIRON[\u0027PF1_2_UUID\u0027]\"].resources.SRIOV_NET_VF: 4"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: get allocation candidates, in tree granular local storage doesn\u0027t exist"},{"line_number":551,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026resources1\u003dDISK_GB:10\u0026in_tree1\u003d$ENVIRON[\u0027CN1_UUID\u0027]"},{"line_number":552,"context_line":"  status: 200"},{"line_number":553,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_747cd4b5","line":550,"range":{"start_line":550,"start_character":71,"end_line":550,"end_character":72},"in_reply_to":"9fdfeff1_b4555c52","updated":"2019-02-25 22:40:47.000000000","message":"Done","commit_id":"aaed691b59f4ded78b9c4970807343de61a30dcd"}]}
