)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"86736779594918069e0c87e53a6714b531aab554","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Adapting to this change requires a lot of changes in tests and"},{"line_number":16,"context_line":"the allocation handler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This is still a WIP because:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* There are problems in the patch before this one which mean"},{"line_number":21,"context_line":"  it has bad formatting and can\u0027t pass py27 tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* This patch also has formatting problems."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"However, the general principles are there and it seems to work"},{"line_number":26,"context_line":"(for python 3), so conceptual review is welcome."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_be5ce519","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":42},"updated":"2019-03-01 23:54:09.000000000","message":"I think these might be fixed up now. I\u0027ll let Chris say yea or nay and edit this appropriately.","commit_id":"c1d965fbe03e4af2a211f5bcf38b0ca98cd92773"}],"placement/handlers/allocation.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"75dc50c9870e8dc0c2558b63baf7aaf824c0765c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    return result"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# TODO(cdent): Extracting this is useful, for reuse by reshaper code,"},{"line_number":160,"context_line":"# but having it in this file seems wrong, however, since it uses"},{"line_number":161,"context_line":"# _new_allocations it\u0027s being left here for now. We need a place for shared"},{"line_number":162,"context_line":"# handler code, but util.py is already too big and too diverse."},{"line_number":163,"context_line":"def create_allocation_list(context, data, consumers):"},{"line_number":164,"context_line":"    \"\"\"Create a list of Allocations based on provided data."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_32158e4a","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":63},"updated":"2019-03-01 21:16:07.000000000","message":"does this TODO still apply?","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"21a722aa0a6283dfb75a65430b37eece518fcf2b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    return result"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# TODO(cdent): Extracting this is useful, for reuse by reshaper code,"},{"line_number":160,"context_line":"# but having it in this file seems wrong, however, since it uses"},{"line_number":161,"context_line":"# _new_allocations it\u0027s being left here for now. We need a place for shared"},{"line_number":162,"context_line":"# handler code, but util.py is already too big and too diverse."},{"line_number":163,"context_line":"def create_allocation_list(context, data, consumers):"},{"line_number":164,"context_line":"    \"\"\"Create a list of Allocations based on provided data."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a3c5b25e","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":63},"in_reply_to":"9fdfeff1_32158e4a","updated":"2019-03-01 23:08:08.000000000","message":"I think so. I wanted handler code to be almost solely about manipulation of http requests and responses and not much else. But we went away from that quite a lot.","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"75dc50c9870e8dc0c2558b63baf7aaf824c0765c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            # Internal to the allocation object this is signalled by a"},{"line_number":191,"context_line":"            # used value of 0."},{"line_number":192,"context_line":"            allocations \u003d alloc_obj.get_all_by_consumer_id("},{"line_number":193,"context_line":"                    context, consumer_uuid)"},{"line_number":194,"context_line":"            for allocation in allocations:"},{"line_number":195,"context_line":"                allocation.used \u003d 0"},{"line_number":196,"context_line":"                allocation_objects.append(allocation)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b2009e04","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":20},"updated":"2019-03-01 21:16:07.000000000","message":"why?","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"21a722aa0a6283dfb75a65430b37eece518fcf2b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            # Internal to the allocation object this is signalled by a"},{"line_number":191,"context_line":"            # used value of 0."},{"line_number":192,"context_line":"            allocations \u003d alloc_obj.get_all_by_consumer_id("},{"line_number":193,"context_line":"                    context, consumer_uuid)"},{"line_number":194,"context_line":"            for allocation in allocations:"},{"line_number":195,"context_line":"                allocation.used \u003d 0"},{"line_number":196,"context_line":"                allocation_objects.append(allocation)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c3979645","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":20},"in_reply_to":"9fdfeff1_b2009e04","updated":"2019-03-01 23:08:08.000000000","message":"I think my editor did that and I didn\u0027t notice.  Some python people say continuations should be a double indent and I guess on one machine my vim does too. I don\u0027t really have a strong opinion (I think ed does, though) except with what\u0027s happening above at line 184. That\u0027s horrible.","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1b58b6473332ad5abb7a00785ee7b17bc60c1f25","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            # Internal to the allocation object this is signalled by a"},{"line_number":191,"context_line":"            # used value of 0."},{"line_number":192,"context_line":"            allocations \u003d alloc_obj.get_all_by_consumer_id("},{"line_number":193,"context_line":"                    context, consumer_uuid)"},{"line_number":194,"context_line":"            for allocation in allocations:"},{"line_number":195,"context_line":"                allocation.used \u003d 0"},{"line_number":196,"context_line":"                allocation_objects.append(allocation)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9e46c150","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":20},"in_reply_to":"9fdfeff1_c3979645","updated":"2019-03-01 23:52:29.000000000","message":"Okay, well, pep8 has an opinion, which we\u0027ve been ignoring, until [1]. I guess anyone with conflicting opinions should weigh in there.\n\n[1] https://review.openstack.org/#/c/640554/","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"}],"placement/tests/functional/db/test_allocation.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f30069fca10860471dd6c299ae926febe50b9fbe","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        mock_log.reset_mock()"},{"line_number":498,"context_line":"        with mock.patch.object(alloc_obj.AllocationList,"},{"line_number":499,"context_line":"                               \u0027RP_CONFLICT_RETRY_COUNT\u0027, 3):"},{"line_number":500,"context_line":"            unmocked_set \u003d functools.partial("},{"line_number":501,"context_line":"                alloc_obj.AllocationList._set_allocations, alloc_list)"},{"line_number":502,"context_line":"            with mock.patch(\u0027placement.objects.allocation.\u0027"},{"line_number":503,"context_line":"                            \u0027AllocationList._set_allocations\u0027) as mock_set:"},{"line_number":504,"context_line":"                exceptions \u003d iter(["}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_32b9d8eb","side":"PARENT","line":501,"range":{"start_line":500,"start_character":27,"end_line":501,"end_character":70},"updated":"2019-03-05 14:33:44.000000000","message":"good to clear this up. ++","commit_id":"322c6f5b61fa8500ee0bf38d802f8fc7703db4df"}],"placement/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"75dc50c9870e8dc0c2558b63baf7aaf824c0765c","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"        self.assertEqual(0, len(allocations))"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_all_with_multiple_consumers(self):"},{"line_number":1158,"context_line":"        \"\"\"Tests fix for LP #1781430 where alloc_obj.delete_all() when"},{"line_number":1159,"context_line":"        issued for a list of allocations returned by"},{"line_number":1160,"context_line":"        alloc_obj.get_by_resource_provider() where the resource provider"},{"line_number":1161,"context_line":"        had multiple consumers allocated against it, left the DB in an"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_15539418","line":1158,"range":{"start_line":1158,"start_character":25,"end_line":1158,"end_character":65},"updated":"2019-03-01 21:16:07.000000000","message":"I assume this still applies to the new form of allocation list.","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"21a722aa0a6283dfb75a65430b37eece518fcf2b","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"        self.assertEqual(0, len(allocations))"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_all_with_multiple_consumers(self):"},{"line_number":1158,"context_line":"        \"\"\"Tests fix for LP #1781430 where alloc_obj.delete_all() when"},{"line_number":1159,"context_line":"        issued for a list of allocations returned by"},{"line_number":1160,"context_line":"        alloc_obj.get_by_resource_provider() where the resource provider"},{"line_number":1161,"context_line":"        had multiple consumers allocated against it, left the DB in an"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e3909a52","line":1158,"range":{"start_line":1158,"start_character":25,"end_line":1158,"end_character":65},"in_reply_to":"9fdfeff1_15539418","updated":"2019-03-01 23:08:08.000000000","message":"It should, yes, the operation of the internals of the method is no different.","commit_id":"a1172d93c4856e965e9d485fb5f53e7d18e68a3b"}]}