)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02a7f347b21944c9fcbe82a9cf1fb645ee4c78ac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the PlacementFixture usable without intercept"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases where it is necessary to use the PlacementFixture"},{"line_number":10,"context_line":"without it running a wsgi-intercept, for example when you\u0027d  like"},{"line_number":11,"context_line":"to run an indepdendent wsgi-intercept, as in the nova tests that"},{"line_number":12,"context_line":"exercise the report client."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_3a51c1da","line":10,"range":{"start_line":10,"start_character":59,"end_line":10,"end_character":61},"updated":"2019-03-04 20:28:21.000000000","message":"s/  / /","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02a7f347b21944c9fcbe82a9cf1fb645ee4c78ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"using a nova conf global to initialize the wsgi intercept. They"},{"line_number":16,"context_line":"just happened to be working because that CONF has the required"},{"line_number":17,"context_line":"configuration settings. When placement\u0027s conf diverged [1] things"},{"line_number":18,"context_line":"broken. A nova change which depends on this one will resolve the"},{"line_number":19,"context_line":"bug."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that as a part of this change, the code which deletes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_5a4e0539","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":6},"updated":"2019-03-04 20:28:21.000000000","message":"broke","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5d7cd1f4c141782c202d12a58ed5e37c00a33035","unresolved":false,"context_lines":[{"line_number":15,"context_line":"using a nova conf global to initialize the wsgi intercept. They"},{"line_number":16,"context_line":"just happened to be working because that CONF has the required"},{"line_number":17,"context_line":"configuration settings. When placement\u0027s conf diverged [1] things"},{"line_number":18,"context_line":"broken. A nova change which depends on this one will resolve the"},{"line_number":19,"context_line":"bug."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that as a part of this change, the code which deletes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_dade753d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":6},"updated":"2019-03-04 20:36:58.000000000","message":"broke","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02a7f347b21944c9fcbe82a9cf1fb645ee4c78ac","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u0027sync_on_startup\u0027 (the new conf option) before configuring the"},{"line_number":23,"context_line":"database, is adapted to be more flexible. There really is only"},{"line_number":24,"context_line":"one conf setting that is required to start the placement database,"},{"line_number":25,"context_line":"connect, and we\u0027d like to make it possible for people to set"},{"line_number":26,"context_line":"just that when doing tests or experiments and not have to worry"},{"line_number":27,"context_line":"about extraneous optional things."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_fa5c99f1","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":7},"updated":"2019-03-04 20:28:21.000000000","message":"connection","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02a7f347b21944c9fcbe82a9cf1fb645ee4c78ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partial-Bug: #1818560"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1] Ie43a69be8b75250d9deca6a911eda7b722ef8648"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8c36f35dbe85b0c0db1a5b6b5389b160b68ca488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_1abe3dd4","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":45},"updated":"2019-03-04 20:28:21.000000000","message":"There is no testing associated with this change - is there anything that could have been added to test the fixture?\n\nDo we need to have a conversation about test coverage of the placement fixtures which are used externally, either by in-tree tests testing whatever sort of contract there is on the fixture behavior, or running some nova-functional job on placement changes to at least the fixtures subdirectory?","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ce7d4b25677c294a94b94c7ad38fba456c9f01a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partial-Bug: #1818560"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1] Ie43a69be8b75250d9deca6a911eda7b722ef8648"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8c36f35dbe85b0c0db1a5b6b5389b160b68ca488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_5a712544","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":45},"in_reply_to":"9fdfeff1_1abe3dd4","updated":"2019-03-04 20:30:24.000000000","message":"\u003e Do we need to have a conversation about test coverage of the placement fixtures which are used externally, either by in-tree tests testing whatever sort of contract there is on the fixture behavior, or running some nova-functional job on placement changes to at least the fixtures subdirectory?\n\nI\u0027m very aware that we don\u0027t want the latter.","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"aab839335353a135e97839a8a19548a841ad35d0","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partial-Bug: #1818560"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1] Ie43a69be8b75250d9deca6a911eda7b722ef8648"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8c36f35dbe85b0c0db1a5b6b5389b160b68ca488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_9aca2d44","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":45},"in_reply_to":"9fdfeff1_5a712544","updated":"2019-03-04 20:34:24.000000000","message":"Good that you feel that way, it ought to be possible to do the former if we can line up what the contract is.","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2f6015537455c52805f4932ee8d283fb039b1e37","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u0027sync_on_startup\u0027 (the new conf option) before configuring the"},{"line_number":23,"context_line":"database, is adapted to be more flexible. There really is only"},{"line_number":24,"context_line":"one conf setting that is required to start the placement database,"},{"line_number":25,"context_line":"connectection, and we\u0027d like to make it possible for people to set"},{"line_number":26,"context_line":"just that when doing tests or experiments and not have to worry"},{"line_number":27,"context_line":"about extraneous optional things."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_dad2f5d1","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":13},"updated":"2019-03-04 20:39:05.000000000","message":"really?","commit_id":"e1b37d79b7e59a5c9c23eaf510f708ba839fca9c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"442c1cbae72f9ddafb7186a17c5ff5a0bedb96b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u0027sync_on_startup\u0027 (the new conf option) before configuring the"},{"line_number":23,"context_line":"database, is adapted to be more flexible. There really is only"},{"line_number":24,"context_line":"one conf setting that is required to start the placement database,"},{"line_number":25,"context_line":"connectection, and we\u0027d like to make it possible for people to set"},{"line_number":26,"context_line":"just that when doing tests or experiments and not have to worry"},{"line_number":27,"context_line":"about extraneous optional things."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_3ae1c19c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":13},"in_reply_to":"9fdfeff1_dad2f5d1","updated":"2019-03-04 20:39:28.000000000","message":"wow","commit_id":"e1b37d79b7e59a5c9c23eaf510f708ba839fca9c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4d632aa5d6ccd3e6d02c71088f5063cf79dd5146","unresolved":false,"context_lines":[{"line_number":24,"context_line":"one conf setting that is required to start the placement database,"},{"line_number":25,"context_line":"connectection, and we\u0027d like to make it possible for people to set"},{"line_number":26,"context_line":"just that when doing tests or experiments and not have to worry"},{"line_number":27,"context_line":"about extraneous optional things."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"We should add more robust testing to all three of PlacementFixture,"},{"line_number":30,"context_line":"fixtures.Database, and PlacementDirect, but at the moment we are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_9aab0d1d","line":27,"updated":"2019-03-04 20:44:01.000000000","message":"in other words, instead of having to remember to update that code to pop every new conf option we create from here on out, we would instead pull only the conf option we need and ignore the rest?","commit_id":"e1b37d79b7e59a5c9c23eaf510f708ba839fca9c"}],"placement/db_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5d7cd1f4c141782c202d12a58ed5e37c00a33035","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def _get_db_conf(conf_group):"},{"line_number":24,"context_line":"    conf_dict \u003d dict(conf_group.items())"},{"line_number":25,"context_line":"    # Remove the \u0027sync_on_startup\u0027 conf setting, enginefacade does not use it."},{"line_number":26,"context_line":"    # Use pop since it might not be present, in testing situations and we"},{"line_number":27,"context_line":"    # don\u0027t want to care here."},{"line_number":28,"context_line":"    conf_dict.pop(\u0027sync_on_startup\u0027, None)"},{"line_number":29,"context_line":"    return conf_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9ae0edfa","line":26,"range":{"start_line":26,"start_character":43,"end_line":26,"end_character":44},"updated":"2019-03-04 20:36:58.000000000","message":"extraneous comma","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02a7f347b21944c9fcbe82a9cf1fb645ee4c78ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def _get_db_conf(conf_group):"},{"line_number":24,"context_line":"    conf_dict \u003d dict(conf_group.items())"},{"line_number":25,"context_line":"    # Remove the \u0027sync_on_startup\u0027 conf setting, enginefacade does not use it."},{"line_number":26,"context_line":"    # Use pop since it might not be present, in testing situations and we"},{"line_number":27,"context_line":"    # don\u0027t want to care here."},{"line_number":28,"context_line":"    conf_dict.pop(\u0027sync_on_startup\u0027, None)"},{"line_number":29,"context_line":"    return conf_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_da42f50f","line":26,"range":{"start_line":26,"start_character":43,"end_line":26,"end_character":44},"updated":"2019-03-04 20:28:21.000000000","message":"nix","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4d632aa5d6ccd3e6d02c71088f5063cf79dd5146","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def _get_db_conf(conf_group):"},{"line_number":24,"context_line":"    conf_dict \u003d dict(conf_group.items())"},{"line_number":25,"context_line":"    # Remove the \u0027sync_on_startup\u0027 conf setting, enginefacade does not use it."},{"line_number":26,"context_line":"    # Use pop since it might not be present in testing situations and we"},{"line_number":27,"context_line":"    # don\u0027t want to care here."},{"line_number":28,"context_line":"    conf_dict.pop(\u0027sync_on_startup\u0027, None)"},{"line_number":29,"context_line":"    return conf_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_1a65dd1d","line":26,"updated":"2019-03-04 20:44:01.000000000","message":"...so like here,\n\n return {\u0027connection\u0027: conf_dict[\u0027connection\u0027]}\n\n?","commit_id":"e1b37d79b7e59a5c9c23eaf510f708ba839fca9c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6c2c7eab261ea07afba15bc9def55eec6ef01ca0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def _get_db_conf(conf_group):"},{"line_number":24,"context_line":"    conf_dict \u003d dict(conf_group.items())"},{"line_number":25,"context_line":"    # Remove the \u0027sync_on_startup\u0027 conf setting, enginefacade does not use it."},{"line_number":26,"context_line":"    # Use pop since it might not be present in testing situations and we"},{"line_number":27,"context_line":"    # don\u0027t want to care here."},{"line_number":28,"context_line":"    conf_dict.pop(\u0027sync_on_startup\u0027, None)"},{"line_number":29,"context_line":"    return conf_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_fa2d79ae","line":26,"in_reply_to":"9fdfeff1_1a65dd1d","updated":"2019-03-04 20:45:46.000000000","message":"No, there are about 20 others, see conf/database, but there is only one which is not legit for enginefacade.","commit_id":"e1b37d79b7e59a5c9c23eaf510f708ba839fca9c"}],"placement/tests/functional/fixtures/placement.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5d7cd1f4c141782c202d12a58ed5e37c00a33035","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    Used by other services, including nova, for functional tests."},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    def __init__(self, token\u003d\u0027admin\u0027, conf_fixture\u003dNone, db\u003dTrue,"},{"line_number":45,"context_line":"                 intercept\u003dTrue):"},{"line_number":46,"context_line":"        self.token \u003d token"},{"line_number":47,"context_line":"        self.db \u003d db"},{"line_number":48,"context_line":"        self.intercept \u003d intercept"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fa9d796c","line":45,"range":{"start_line":45,"start_character":17,"end_line":45,"end_character":26},"updated":"2019-03-04 20:36:58.000000000","message":"use_intercept? create_intercept? Else it sounds like it\u0027s expecting us to pass in one we made earlier.\n\n...and we\u0027re at a point (if we weren\u0027t already) where a docstring describing these parameters would be helpful.","commit_id":"864c5ebafbd121be025d387a35ce5e85ba5d3514"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adb49f1e4a61adf5a9e6221e43d7afcd1ba29857","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :param conf_fixture: An oslo_conf.fixture.Config. If provided, config"},{"line_number":51,"context_line":"                             will be based from it."},{"line_number":52,"context_line":"        :param db: Whether to start the Database fixture."},{"line_number":53,"context_line":"        :param use_intercept: If true, install a wsgi-intercept of the"},{"line_number":54,"context_line":"                              placement WSGI app."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        self.token \u003d token"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c50bfad2","line":53,"updated":"2019-03-04 21:06:04.000000000","message":"nit: it\u0027d be good to mention when you might *not* want this since it\u0027s kind of lost on me, but you know...urgency and all.","commit_id":"c04a107e322ecf16b59b85090f3c432040b52c14"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b4c5dc2b52320e2b7c631f56fb941ebb2c8d4271","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :param conf_fixture: An oslo_conf.fixture.Config. If provided, config"},{"line_number":51,"context_line":"                             will be based from it."},{"line_number":52,"context_line":"        :param db: Whether to start the Database fixture."},{"line_number":53,"context_line":"        :param use_intercept: If true, install a wsgi-intercept of the"},{"line_number":54,"context_line":"                              placement WSGI app."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        self.token \u003d token"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_25d5261c","line":53,"in_reply_to":"9fdfeff1_c50bfad2","updated":"2019-03-04 21:09:32.000000000","message":"I left that out, because if/when we get rid of test_report_client using PlacementDirect then the one reason we have for it goes away.\n\nSo my thinking is that we\u0027d either:\n\n* remove this then\n* know better how/why we might want that then, thus be able to write something better","commit_id":"c04a107e322ecf16b59b85090f3c432040b52c14"}]}