)]}'
{"placement/context.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"22d42870a2bec30e391bf1ca7f74acc4e9efefc0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            return policy.authorize(self, action, target)"},{"line_number":54,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":55,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":56,"context_line":"                if not fatal:"},{"line_number":57,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":58,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d5f2de9a","line":55,"updated":"2019-03-06 13:42:03.000000000","message":"Is this needed here? That is, can another exception happen here, clearing the pending exception?\n\nOr are you simply doing this to keep things clear and futureproof?","commit_id":"55f0214c96cd538b2a736ca63213b9f8c06dae47"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"468b91cb6b83dbe2cb2082de39d0bb43ff6a7357","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            return policy.authorize(self, action, target)"},{"line_number":54,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":55,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":56,"context_line":"                if not fatal:"},{"line_number":57,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":58,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_451b8e1a","line":55,"in_reply_to":"5fc1f717_d5f2de9a","updated":"2019-03-06 22:31:22.000000000","message":"Yeah, I think we could do without this one. \u0027if fatal\u0027 can\u0027t affect the exception context, and IMO any potential futureproofing isn\u0027t worth the relative increase in ick factor here.","commit_id":"55f0214c96cd538b2a736ca63213b9f8c06dae47"}]}