)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"731877f29aeb17d7626af149576b214fae07219f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"A new unit.objects.test_inventory is created. A"},{"line_number":14,"context_line":"functional.db.test_inventory is _not_ created because though"},{"line_number":15,"context_line":"there are inventory related tests within test_resource_provider"},{"line_number":16,"context_line":"they are within a ResourceProvider-related class and teasing"},{"line_number":17,"context_line":"out the ones that are for the sake of just Inventory versus"},{"line_number":18,"context_line":"for both Inventory and ResourceProvider is not entirely"},{"line_number":19,"context_line":"clear."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia1ad18585194236647ec2c83480254531a619e91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_a2547622","line":19,"range":{"start_line":16,"start_character":53,"end_line":19,"end_character":6},"updated":"2019-03-08 21:03:03.000000000","message":"yeah, what would that even mean? Can you have an inventory without a provider?","commit_id":"3969b870b1a73ea00ea0a808b0cfcc7287d8ca60"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d455db19dc4293c664a62f69a38ca9161325abc7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"A new unit.objects.test_inventory is created. A"},{"line_number":14,"context_line":"functional.db.test_inventory is _not_ created because though"},{"line_number":15,"context_line":"there are inventory related tests within test_resource_provider"},{"line_number":16,"context_line":"they are within a ResourceProvider-related class and teasing"},{"line_number":17,"context_line":"out the ones that are for the sake of just Inventory versus"},{"line_number":18,"context_line":"for both Inventory and ResourceProvider is not entirely"},{"line_number":19,"context_line":"clear."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia1ad18585194236647ec2c83480254531a619e91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_dcb2b0e6","line":19,"range":{"start_line":16,"start_character":53,"end_line":19,"end_character":6},"in_reply_to":"5fc1f717_a2547622","updated":"2019-03-11 14:06:43.000000000","message":"I would imagine that those that are concerned with adding/changing/deleting inventory could be considered Inventory methods, because the RP is just a FK related to it. But the distinction is not very big, and not very important.","commit_id":"3969b870b1a73ea00ea0a808b0cfcc7287d8ca60"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4b493064e2511a26367019969dd162b13f42b7f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move Inventory and InventoryList to own file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Inventory and InventoryList classes are moved to an"},{"line_number":10,"context_line":"inventory.py file. Tests and other callers are udpated"},{"line_number":11,"context_line":"to reflect the new location."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A new unit.objects.test_inventory is created. A"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5fc1f717_f46e49c7","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":54},"updated":"2019-03-15 06:07:53.000000000","message":"updated","commit_id":"ca3ade76162d1d1e7b9d1018b18ad7e5c4c930d2"}],"placement/handlers/reshaper.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d455db19dc4293c664a62f69a38ca9161325abc7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        for res_class, raw_inventory in inventory_data[\u0027inventories\u0027].items():"},{"line_number":80,"context_line":"            inv_data \u003d copy.copy(inventory.INVENTORY_DEFAULTS)"},{"line_number":81,"context_line":"            inv_data.update(raw_inventory)"},{"line_number":82,"context_line":"            inv_object \u003d inventory.make_inventory_object("},{"line_number":83,"context_line":"                resource_provider, res_class, **inv_data)"},{"line_number":84,"context_line":"            inv_list.append(inv_object)"},{"line_number":85,"context_line":"        inventory_by_rp[resource_provider] \u003d inv_obj.InventoryList("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5cf48086","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":22},"updated":"2019-03-11 14:06:43.000000000","message":"\"inv_obj\" and \"inv_object\" are a little too close in my mind. Not a big deal, as this is a small section of the code, but in the future renaming might be a good idea to avoid confusion.\n\nJust as I\u0027m typing this I thought that maybe changing the imports from `import foo as foo_obj` to `import foo as foo_module` might eliminate some of this weird naming.","commit_id":"3969b870b1a73ea00ea0a808b0cfcc7287d8ca60"}],"placement/objects/inventory.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"731877f29aeb17d7626af149576b214fae07219f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fc1f717_c20d023f","updated":"2019-03-08 21:03:03.000000000","message":"✔","commit_id":"3969b870b1a73ea00ea0a808b0cfcc7287d8ca60"}],"placement/tests/unit/objects/test_inventory.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"731877f29aeb17d7626af149576b214fae07219f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fc1f717_e2083e2e","updated":"2019-03-08 21:03:03.000000000","message":"✔","commit_id":"3969b870b1a73ea00ea0a808b0cfcc7287d8ca60"}]}