)]}'
{"id":"openstack%2Fplacement~645255","triplet_id":"openstack%2Fplacement~master~I61fb232ededaec2ba0d65b5879ff91a76e8b9887","project":"openstack/placement","branch":"master","topic":"test-PlacementFixture","hashtags":[],"change_id":"I61fb232ededaec2ba0d65b5879ff91a76e8b9887","subject":"Start unit tests for PlacementFixture","status":"ABANDONED","created":"2019-03-21 17:22:40.000000000","updated":"2019-05-30 15:52:22.000000000","total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b7bffbebf48655e48f0b14e3a48cd35a055f5ee7","_number":645255,"virtual_id_number":645255,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":-1,"date":"2019-03-21 23:31:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"date":"2019-03-21 23:00:02.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-03-21 22:54:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2019-03-22 14:22:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-21 22:54:58.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-03-21 23:31:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-22 14:22:35.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"f2e91e898bec54305a842162323483d52cd7c77c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 17:22:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fbd12b3f35b4ad3f1452fec9464d926e0521d434","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 17:24:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7a2a60cdbb74d915de764c56f9f97a52f335bb3e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-21 17:31:20.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI think this is fine to have, but like I\u0027ve mentioned elsewhere it feels like these are are largely tests of a) dependent libraries, b) that a keyword and a conditional follow the rules of Python. As a regression test, I guess that\u0027s a nice thing, so yeah, sure.\n\nThe -1 is because of the notes around the assertion that Exception was raised. That\u0027s dangerous and info hiding and the note about not making a requirement is confused because it looks like you\u0027ve already made it (unless I\u0027m completely misunderstanding the note)","accounts_in_message":[],"_revision_number":1},{"id":"91448ced5abd031047176d9be2e2a1a3a30b8cb1","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 18:08:12.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bf00bfb3338666ccabf8c7df899548855390872f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 18:08:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"73d5a56a3e14c4ca31de87dee6ab78809a2382da","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-21 19:10:57.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\ntest_register_opts_fail is going a very round about way to get where you want it. I\u0027ve provided an alternative but it might not be sufficient for what you want. The notes surrounding it should provide some insights into other options.","accounts_in_message":[],"_revision_number":2},{"id":"341d2c5becfb40bef9d7713b29ac0c2d0f717b08","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 21:35:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e3cd24aadfb7897d17c89fc4414737142a4d4fb6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 21:36:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9e195cbcacc4df896ad4287e24c0d2b78a54c1ab","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-21 22:54:58.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)\n\na pep8 issues and the addition of the pf.setUp identifies some problems with how things are being called\n\nisn\u0027t this all such byzantine fun?","accounts_in_message":[],"_revision_number":3},{"id":"d41b42ddd706f21df68692b02944d9d01896b08d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-21 23:00:02.000000000","message":"Patch Set 3:\n\nI was trying to avoid testing too much of the specifics, but it occurs to me: these are *unit* tests so why tf not?\n\nI\u0027ll fix this up tomorrow, thanks for the feedback.","accounts_in_message":[],"_revision_number":3},{"id":"f8be52f57c0f60a30d314abd8548315d466d75e6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-21 23:31:31.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/55/645255/3/check/openstack-tox-docs/d47a5bd/html/ : SUCCESS in 6m 29s\n- openstack-tox-cover http://logs.openstack.org/55/645255/3/check/openstack-tox-cover/0876faf/cover/ : SUCCESS in 6m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/645255/3/check/openstack-tox-lower-constraints/d6021e3/ : SUCCESS in 6m 15s\n- openstack-tox-pep8 http://logs.openstack.org/55/645255/3/check/openstack-tox-pep8/de1fe73/ : FAILURE in 4m 48s\n- openstack-tox-py27 http://logs.openstack.org/55/645255/3/check/openstack-tox-py27/c903533/ : SUCCESS in 4m 35s\n- openstack-tox-py35 http://logs.openstack.org/55/645255/3/check/openstack-tox-py35/a77bdbd/ : FAILURE in 4m 17s\n- openstack-tox-py36 http://logs.openstack.org/55/645255/3/check/openstack-tox-py36/187172b/ : SUCCESS in 4m 38s\n- openstack-tox-py37 http://logs.openstack.org/55/645255/3/check/openstack-tox-py37/251992c/ : FAILURE in 5m 30s\n- openstack-tox-functional http://logs.openstack.org/55/645255/3/check/openstack-tox-functional/67a3ac1/ : SUCCESS in 5m 29s\n- openstack-tox-functional-py35 http://logs.openstack.org/55/645255/3/check/openstack-tox-functional-py35/4ef5af9/ : SUCCESS in 6m 17s\n- openstack-tox-functional-py36 http://logs.openstack.org/55/645255/3/check/openstack-tox-functional-py36/2bebdd8/ : SUCCESS in 5m 10s","accounts_in_message":[],"_revision_number":3},{"id":"bd0005ce2ff1631bcf3e0f3f49a35a299112735e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-22 10:05:33.000000000","message":"Patch Set 3:\n\nSo, that different tests are failing in different python version is likely not because of the python versions. Initially I thought it was perhaps because fixtures setUp is happening explicitly but no cleanUp is being called, which suggests some lurking global state.\n\nHowever, it is complicated by the fact that the error raised when one test fails causes the entire test class to fail and no other tests are run.\n\nIn the py36 tests, where there is success, all three tests are run, but in two different processes so that might be some kind of clue.\n\n/me facepalms","accounts_in_message":[],"_revision_number":3},{"id":"6ce86760d27051ecd09d0e7d9a86f5e200b5b3c0","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-30 15:52:22.000000000","message":"Abandoned\n\nI\u0027m probably never going to get back to this.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bd57e8061acd2223b12a80c6ab99b9efe249e154","revisions":{"209bbe6592842f92b4bc64088c57937ea0cdcbe9":{"kind":"REWORK","_number":1,"created":"2019-03-21 17:22:40.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/55/645255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/55/645255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/55/645255/1"}}},"commit":{"parents":[{"commit":"c6a23a30377ca367ce39451d2f6b61b5cdf00383","subject":"Merge \"Add register_opts param to PlacementFixture\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c6a23a30377ca367ce39451d2f6b61b5cdf00383"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 17:19:23.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 17:19:23.000000000","tz":-300},"subject":"Start unit tests for PlacementFixture","message":"Start unit tests for PlacementFixture\n\nTesting PlacementFixture is hard. The most effective tests are from\nthings (like nova) trying to use the fixture. But a certain amount of\nunit testing is still possible and desirable.\n\nThis commit introduces placement.tests.unit.test_fixtures with a\nPlacementFixtureTest which initially exercises the register_opts kwarg\nadded in [1].\n\n[1] I360a306b5d05ada75274733038b73ec2f2bdc4d4\n\nChange-Id: I61fb232ededaec2ba0d65b5879ff91a76e8b9887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/209bbe6592842f92b4bc64088c57937ea0cdcbe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/209bbe6592842f92b4bc64088c57937ea0cdcbe9"}]},"branch":"refs/heads/master"},"43598595f517ed70bf2d0143300b48eed9e05ec3":{"kind":"REWORK","_number":2,"created":"2019-03-21 18:08:20.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/55/645255/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/55/645255/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/55/645255/2"}}},"commit":{"parents":[{"commit":"c6a23a30377ca367ce39451d2f6b61b5cdf00383","subject":"Merge \"Add register_opts param to PlacementFixture\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c6a23a30377ca367ce39451d2f6b61b5cdf00383"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 17:19:23.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 18:08:18.000000000","tz":-300},"subject":"Start unit tests for PlacementFixture","message":"Start unit tests for PlacementFixture\n\nTesting PlacementFixture is hard. The most effective tests are from\nthings (like nova) trying to use the fixture. But a certain amount of\nunit testing is still possible and desirable.\n\nThis commit introduces placement.tests.unit.test_fixtures with a\nPlacementFixtureTest which initially exercises the register_opts kwarg\nadded in [1].\n\n[1] I360a306b5d05ada75274733038b73ec2f2bdc4d4\n\nChange-Id: I61fb232ededaec2ba0d65b5879ff91a76e8b9887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/43598595f517ed70bf2d0143300b48eed9e05ec3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/43598595f517ed70bf2d0143300b48eed9e05ec3"}]},"branch":"refs/heads/master"},"bd57e8061acd2223b12a80c6ab99b9efe249e154":{"kind":"REWORK","_number":3,"created":"2019-03-21 21:35:59.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/55/645255/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/55/645255/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/55/645255/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/55/645255/3"}}},"commit":{"parents":[{"commit":"c6a23a30377ca367ce39451d2f6b61b5cdf00383","subject":"Merge \"Add register_opts param to PlacementFixture\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c6a23a30377ca367ce39451d2f6b61b5cdf00383"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 17:19:23.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-21 21:35:57.000000000","tz":-300},"subject":"Start unit tests for PlacementFixture","message":"Start unit tests for PlacementFixture\n\nTesting PlacementFixture is hard. The most effective tests are from\nthings (like nova) trying to use the fixture. But a certain amount of\nunit testing is still possible and desirable.\n\nThis commit introduces placement.tests.unit.test_fixtures with a\nPlacementFixtureTest which initially exercises the register_opts kwarg\nadded in [1].\n\n[1] I360a306b5d05ada75274733038b73ec2f2bdc4d4\n\nChange-Id: I61fb232ededaec2ba0d65b5879ff91a76e8b9887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/bd57e8061acd2223b12a80c6ab99b9efe249e154"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/bd57e8061acd2223b12a80c6ab99b9efe249e154"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}