)]}'
{"doc/source/contributor/contributing.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e41a1f9abfca3c385db17d85e90e8a7de3303a11","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  meantime."},{"line_number":116,"context_line":"* Gerrit can be good for code review, but is often not a great environment for"},{"line_number":117,"context_line":"  having a discussion that is struggling to resolve to a decision. Move"},{"line_number":118,"context_line":"  discussion to the mailing list sooner than later."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Special Considerations For Core Reviewers"},{"line_number":121,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_eebbe40b","line":118,"updated":"2019-03-26 16:54:16.000000000","message":"Not mentioning IRC here on purpose?\n\nAlso: \"sooner rather than later\" if you don\u0027t mind.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2668f7069ab10ecbacc5644ae30bb50478cdc2ea","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  meantime."},{"line_number":116,"context_line":"* Gerrit can be good for code review, but is often not a great environment for"},{"line_number":117,"context_line":"  having a discussion that is struggling to resolve to a decision. Move"},{"line_number":118,"context_line":"  discussion to the mailing list sooner than later."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Special Considerations For Core Reviewers"},{"line_number":121,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_9dddb415","line":118,"in_reply_to":"5fc1f717_eebbe40b","updated":"2019-03-26 20:12:47.000000000","message":"Yes (see below) and okay.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e41a1f9abfca3c385db17d85e90e8a7de3303a11","unresolved":false,"context_lines":[{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_ee50c4d7","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":34},"updated":"2019-03-26 16:54:16.000000000","message":"Oh, I see.\n\nHopefully the reader can extrapolate that there are (frequently!) cases where a realtime conversation is necessary for progress to be made, even at the sacrifice of a reduced number of participants.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"188e080ca57e6f42c87b3af49a19f9fedef3db76","unresolved":false,"context_lines":[{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_3594d836","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":34},"in_reply_to":"5fc1f717_350a98d1","updated":"2019-03-26 20:40:02.000000000","message":"\u003e Fair, and I\u0027m not going to downvote on this, but I really feel like\n \u003e you are giving IRC short shrift as a tool for Getting Things Done.\n\nSure, but IRC doesn\u0027t need any help or encouragement. It\u0027s going to get used by default no matter what gets said, so it doesn\u0027t need to be buttressed. Everything else does.\n\nBeyond that I think that \"design brainstorming and working out issues\" is \"info to share\". Info to share it not just outcomes it is also how you got there.\n\nBut worry not: It\u0027s not going anywhere. It\u0027s not going to get less. It will still be used and useful. Consider what I\u0027m doing with ML and IRC here a bit like affirmative action: nobody really likes it, especially people with privilege, but it sometimes brings about improved outcomes, globally.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ca12d2a0a29060a3695cd3d71ffd653972e86178","unresolved":false,"context_lines":[{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_58aaf970","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":34},"in_reply_to":"5fc1f717_3594d836","updated":"2019-03-26 21:28:31.000000000","message":"For anything trivial, IRC is probably fastest and easiest to deal with.\n\nFor anything of substance, email discussions are much better. For those cases where email discussions need a real-time forum to settle issues, like a hangout, that should also be posted in email ahead of time so that people in timezones that don\u0027t lend themselves to attending the hangout can at least register their thoughts and/or concerns ahead of time. And it is critical that any such hangout-type discussion be summarized and posted in email so that everyone can be aware of the decisions being made.\n\nIn summary, IRC for most day-to-day things; email for anything of substance.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2668f7069ab10ecbacc5644ae30bb50478cdc2ea","unresolved":false,"context_lines":[{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_fdecf8bb","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":34},"in_reply_to":"5fc1f717_ee50c4d7","updated":"2019-03-26 20:12:47.000000000","message":"I\u0027m trying to make it clear that the frequency of such things should be low for the sake of \"enabl[ing] other people to contribute good code\" and \"input from unexpected sources\".\n\nIRC should be for shit shooting, checking in, fact checking, making reminders, etc. If there\u0027s real info to share, it shouldn\u0027t be synchronous and if we\u0027re really really stuck we should probably take it to a hangout.\n\nI recognize that won\u0027t always happen or be realistic, but as above we should \"strive\".","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d26431308def632d33cb75f2e6426e1e622b5328","unresolved":false,"context_lines":[{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_350a98d1","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":34},"in_reply_to":"5fc1f717_fdecf8bb","updated":"2019-03-26 20:32:36.000000000","message":"\u003e IRC should be for shit shooting, checking in, fact checking, making\n \u003e reminders, etc.\n\nI agree, but also think it \"should be\" (is very effective for) design brainstorming and working out issues.\n\n \u003e If there\u0027s real info to share,\n\nYah, \"info to share\" is definitely ML material.\n\n \u003e if we\u0027re really really stuck we should probably\n \u003e take it to a hangout.\n\nAgree, but for just really stuck, hangout is too heavyweight and IRC is most efficient.\n\n \u003e I recognize that won\u0027t always happen or be realistic, but as above\n \u003e we should \"strive\".\n\nFair, and I\u0027m not going to downvote on this, but I really feel like you are giving IRC short shrift as a tool for Getting Things Done.","commit_id":"3adfbf427e5ce595a753d5b2fdd793ccaa2cae5d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68d0b0fb65feff202cb90803f11fefdbe5a4298e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"See `How to Review Changes the OpenStack Way`_ for an overview of the review"},{"line_number":90,"context_line":"and voting process."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"There is a small group of people within the Placement team called \"core"},{"line_number":93,"context_line":"reviewers\". These are people who are empowered to signal (via the ``+2`` vote)"},{"line_number":94,"context_line":"that code is of a suitable standard to be merged and is aligned with the"},{"line_number":95,"context_line":"current goals of the project. Core reviewers are regularly selected from all"},{"line_number":96,"context_line":"active reviewers based on the quantity and quality of their reviews and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_2870d73f","line":93,"range":{"start_line":92,"start_character":66,"end_line":93,"end_character":10},"updated":"2019-03-28 10:30:41.000000000","message":"You can link to https://review.openstack.org/#/admin/groups/1936,members to show who they are.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7e1cac977e4c65e07bc4668c28a0d375d1410bcb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"See `How to Review Changes the OpenStack Way`_ for an overview of the review"},{"line_number":90,"context_line":"and voting process."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"There is a small group of people within the Placement team called \"core"},{"line_number":93,"context_line":"reviewers\". These are people who are empowered to signal (via the ``+2`` vote)"},{"line_number":94,"context_line":"that code is of a suitable standard to be merged and is aligned with the"},{"line_number":95,"context_line":"current goals of the project. Core reviewers are regularly selected from all"},{"line_number":96,"context_line":"active reviewers based on the quantity and quality of their reviews and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_3397ec47","line":93,"range":{"start_line":92,"start_character":66,"end_line":93,"end_character":10},"in_reply_to":"5fc1f717_2870d73f","updated":"2019-03-28 11:13:19.000000000","message":"Yeah, I wasn\u0027t sure whether I wanted to do that here or not. I feel weird about people needing to know who the cores are. It should be the other way round, the cores should know who the contributors are.\n\nIn nova it was important to know who a core is so you can hassle someone to get your code reviewed. I don\u0027t want that to ever be the case in placement. If code is not getting quick review, the cores aren\u0027t doing their jobs...","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5f2fc42172525e9654a46f8192b6b30a44951ccf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"See `How to Review Changes the OpenStack Way`_ for an overview of the review"},{"line_number":90,"context_line":"and voting process."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"There is a small group of people within the Placement team called \"core"},{"line_number":93,"context_line":"reviewers\". These are people who are empowered to signal (via the ``+2`` vote)"},{"line_number":94,"context_line":"that code is of a suitable standard to be merged and is aligned with the"},{"line_number":95,"context_line":"current goals of the project. Core reviewers are regularly selected from all"},{"line_number":96,"context_line":"active reviewers based on the quantity and quality of their reviews and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_6525a55b","line":93,"range":{"start_line":92,"start_character":66,"end_line":93,"end_character":10},"in_reply_to":"5fc1f717_3397ec47","updated":"2019-03-28 13:48:01.000000000","message":"fair point.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"fa130f7881ad07a89cd730c6323877ce4a408bd5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Special Considerations For Core Reviewers"},{"line_number":121,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Core reviewers have special powers. With great power comes great responsibility"},{"line_number":124,"context_line":"and thus being held to a standard. As a core reviewer, your job is to enable"},{"line_number":125,"context_line":"other people to contribute good code. Under ideal conditions it is more"},{"line_number":126,"context_line":"important to be reviewing other people\u0027s code and bugs and fixing bugs than it"},{"line_number":127,"context_line":"is to be writing your own features. Frequently conditions will not be ideal,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_1808f18f","line":124,"range":{"start_line":123,"start_character":36,"end_line":124,"end_character":33},"updated":"2019-03-26 21:29:59.000000000","message":"A bit corny, and also awkward phrasing. Can be fixed in a FUP, though.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5c126e85076da4d313a2558d84610b2d2f7ce461","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Special Considerations For Core Reviewers"},{"line_number":121,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Core reviewers have special powers. With great power comes great responsibility"},{"line_number":124,"context_line":"and thus being held to a standard. As a core reviewer, your job is to enable"},{"line_number":125,"context_line":"other people to contribute good code. Under ideal conditions it is more"},{"line_number":126,"context_line":"important to be reviewing other people\u0027s code and bugs and fixing bugs than it"},{"line_number":127,"context_line":"is to be writing your own features. Frequently conditions will not be ideal,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_f835e545","line":124,"range":{"start_line":123,"start_character":36,"end_line":124,"end_character":33},"in_reply_to":"5fc1f717_1808f18f","updated":"2019-03-26 21:31:54.000000000","message":"I made it corny on purpose.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68d0b0fb65feff202cb90803f11fefdbe5a4298e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Similarly, if the CI system is throwing up random failures in test runs, you"},{"line_number":131,"context_line":"should endeavor whenever possible to investigate, not simply ``recheck``. A"},{"line_number":132,"context_line":"flakey gate is an indication that OpenStack is not robust and at the root of"},{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_48cd2364","line":133,"updated":"2019-03-28 10:30:41.000000000","message":"This task shall not be limited for core reviewers. Fixing an unstable functional test case is a good learning experience.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7e1cac977e4c65e07bc4668c28a0d375d1410bcb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Similarly, if the CI system is throwing up random failures in test runs, you"},{"line_number":131,"context_line":"should endeavor whenever possible to investigate, not simply ``recheck``. A"},{"line_number":132,"context_line":"flakey gate is an indication that OpenStack is not robust and at the root of"},{"line_number":133,"context_line":"all this, making OpenStack work well is what we are doing."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_53d15822","line":133,"in_reply_to":"5fc1f717_48cd2364","updated":"2019-03-28 11:13:19.000000000","message":"good point, I\u0027ll move it up","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68d0b0fb65feff202cb90803f11fefdbe5a4298e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Writing Code"},{"line_number":141,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_c8def30f","line":138,"updated":"2019-03-28 10:30:41.000000000","message":"... but please link the mailthread back to the gerrit review for discoverability for latecommers.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ddda210ff60b06c6d0d26168c89ffa66782f0d11","unresolved":false,"context_lines":[{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Writing Code"},{"line_number":141,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_8e0c73ec","line":138,"in_reply_to":"5fc1f717_73cc9488","updated":"2019-03-28 12:04:05.000000000","message":"I\u0027ve added that point but in the more general section above.","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7e1cac977e4c65e07bc4668c28a0d375d1410bcb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"When there are open questions that need to be resolved, try to prefer the"},{"line_number":136,"context_line":"`openstack-discuss`_ list over IRC so that anyone can be involved according"},{"line_number":137,"context_line":"to their own schedules and input from unexpected sources can be available."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Writing Code"},{"line_number":141,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_73cc9488","line":138,"in_reply_to":"5fc1f717_c8def30f","updated":"2019-03-28 11:13:19.000000000","message":"also a good point","commit_id":"ec1532bc5becfb41ba8729a5ebf316a620f63583"}]}