)]}'
{"placement/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"db6fecf6c4d03847638e2d63e22d0c5762c53638","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"        # CUSTOM_TRAIT_A"},{"line_number":1022,"context_line":"        filters \u003d {\u0027required\u0027: [\u0027CUSTOM_TRAIT_A\u0027, \u0027!CUSTOM_TRAIT_B\u0027]}"},{"line_number":1023,"context_line":"        expected_rps \u003d [\u0027rp_1\u0027]"},{"line_number":1024,"context_line":"        custom_a_rps \u003d self._run_get_all_by_filters(expected_rps,"},{"line_number":1025,"context_line":"                                                    filters\u003dfilters)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"        self.assertEqual(uuidsentinel.rp_1, custom_a_rps[0].uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_f6514dda","line":1024,"range":{"start_line":1024,"start_character":8,"end_line":1024,"end_character":23},"updated":"2019-03-28 15:18:32.000000000","message":"afaict this is the only place you\u0027re using the return value from your helper. You might be able to get rid of it...","commit_id":"92d5df4aa3eb5aa802aacad831a9dc7fdff35755"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"db6fecf6c4d03847638e2d63e22d0c5762c53638","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"        custom_a_rps \u003d self._run_get_all_by_filters(expected_rps,"},{"line_number":1025,"context_line":"                                                    filters\u003dfilters)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"        self.assertEqual(uuidsentinel.rp_1, custom_a_rps[0].uuid)"},{"line_number":1028,"context_line":"        traits \u003d trait_obj.get_all_by_resource_provider("},{"line_number":1029,"context_line":"            self.ctx, custom_a_rps[0])"},{"line_number":1030,"context_line":"        self.assertEqual(1, len(traits))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_d63bf198","line":1027,"range":{"start_line":1027,"start_character":8,"end_line":1027,"end_character":65},"updated":"2019-03-28 15:18:32.000000000","message":"this seems unnecessary","commit_id":"92d5df4aa3eb5aa802aacad831a9dc7fdff35755"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"db6fecf6c4d03847638e2d63e22d0c5762c53638","unresolved":false,"context_lines":[{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"        self.assertEqual(uuidsentinel.rp_1, custom_a_rps[0].uuid)"},{"line_number":1028,"context_line":"        traits \u003d trait_obj.get_all_by_resource_provider("},{"line_number":1029,"context_line":"            self.ctx, custom_a_rps[0])"},{"line_number":1030,"context_line":"        self.assertEqual(1, len(traits))"},{"line_number":1031,"context_line":"        self.assertEqual(\u0027CUSTOM_TRAIT_A\u0027, traits[0].name)"},{"line_number":1032,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_763ebd8b","line":1029,"range":{"start_line":1029,"start_character":22,"end_line":1029,"end_character":37},"updated":"2019-03-28 15:18:32.000000000","message":"and you could probably fake this","commit_id":"92d5df4aa3eb5aa802aacad831a9dc7fdff35755"}]}