)]}'
{"doc/source/upgrade/to-stein.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d7442be0b4f68cbfe693572cb5ddb7ebf3f9515","unresolved":false,"context_lines":[{"line_number":62,"context_line":"may be used to copy the data or as models for your own tooling:"},{"line_number":63,"context_line":"`mysql-migrate-db.sh`_ and `postgresql-migrate-db.sh`_."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. note:: These migration scripts are also packaged with the"},{"line_number":66,"context_line":"          `openstack-placement`_ package on PyPI. Their filenames may be"},{"line_number":67,"context_line":"          discovered using ``pkg_resources`` to look in the"},{"line_number":68,"context_line":"          ``placement_db_tools``::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_886add7d","line":65,"updated":"2019-05-06 21:51:08.000000000","message":"This could be a tad bit confusing if someone trying to follow this guide in Stein is reading this (because of the /latest/ path in the docs); they can get back to the stein docs easily enough if they know how. With the symlinks preserving the old location maybe it doesn\u0027t matter. Just wasn\u0027t sure if this should say something like, \"Starting in the Train release, these migration scripts...\".","commit_id":"76814664c129d921dc3311c716d42c985049cc07"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8bfc2774253fbc7ec00f54d24a3b81521fc834d3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"may be used to copy the data or as models for your own tooling:"},{"line_number":63,"context_line":"`mysql-migrate-db.sh`_ and `postgresql-migrate-db.sh`_."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. note:: These migration scripts are also packaged with the"},{"line_number":66,"context_line":"          `openstack-placement`_ package on PyPI. Their filenames may be"},{"line_number":67,"context_line":"          discovered using ``pkg_resources`` to look in the"},{"line_number":68,"context_line":"          ``placement_db_tools``::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_c8cc558b","line":65,"in_reply_to":"dfbec78f_886add7d","updated":"2019-05-06 22:01:00.000000000","message":"That\u0027s a good idea, I\u0027ll add that.","commit_id":"76814664c129d921dc3311c716d42c985049cc07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d7442be0b4f68cbfe693572cb5ddb7ebf3f9515","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          discovered using ``pkg_resources`` to look in the"},{"line_number":68,"context_line":"          ``placement_db_tools``::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"              pkg_resources.resource_filename(\u0027placement_db_tools\u0027, \u0027mysql-migrate-db.sh\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For best results run the database migration on your database host. If you are"},{"line_number":73,"context_line":"unable to do this, you will need to take some additional steps below."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_68f0c9ca","line":70,"updated":"2019-05-06 21:51:08.000000000","message":"Yup:\n\n(venv) osboxes@osboxes:~/git/placement$ ls -la tools/\ntotal 16\ndrwxrwxr-x  2 osboxes osboxes 4096 May  6 17:38 .\ndrwxrwxr-x 16 osboxes osboxes 4096 May  6 17:38 ..\n-rwxrwxr-x  1 osboxes osboxes  475 Mar  6 09:16 flake8wrap.sh\nlrwxrwxrwx  1 osboxes osboxes   41 May  6 17:38 mysql-migrate-db.sh -\u003e ../placement_db_tools/mysql-migrate-db.sh\nlrwxrwxrwx  1 osboxes osboxes   46 May  6 17:38 postgresql-migrate-db.sh -\u003e ../placement_db_tools/postgresql-migrate-db.sh\n-rwxrwxr-x  1 osboxes osboxes 1860 Mar  6 09:16 test-setup.sh\n(venv) osboxes@osboxes:~/git/placement$ python\nPython 3.6.7 (default, Oct 22 2018, 11:32:17) \n[GCC 8.2.0] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e import pkg_resources\n\u003e\u003e\u003e pkg_resources.resource_filename(\u0027placement_db_tools\u0027, \u0027mysql-migrate-db.sh\u0027)\n\u0027/home/osboxes/git/placement/placement_db_tools/mysql-migrate-db.sh\u0027","commit_id":"76814664c129d921dc3311c716d42c985049cc07"}],"placement_db_tools/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d7442be0b4f68cbfe693572cb5ddb7ebf3f9515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dfbec78f_88ff3da9","line":1,"updated":"2019-05-06 21:51:08.000000000","message":"Could this have been simply tools/db/? Then you wouldn\u0027t need both /tools and /placement_db_tools.\n\nOtherwise maybe this could use some description or README of what should live in here - that\u0027s just a nit though.\n\nActually, why do you even need an __init__.py for this? Just for python data files (it\u0027s been awhile since I\u0027ve done one of these)? Oh I guess because, \"placement_db_tools is added to the list of packages included in the openstack-placement distro. This means that when \u0027pip install openstack-placement\u0027 happens, the python environment will then include placement and placement_db_tools directories.\"","commit_id":"76814664c129d921dc3311c716d42c985049cc07"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8bfc2774253fbc7ec00f54d24a3b81521fc834d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dfbec78f_689e8964","line":1,"in_reply_to":"dfbec78f_88ff3da9","updated":"2019-05-06 22:01:00.000000000","message":"Your last paragraph basically covers the why of how it was done and why \"it\u0027s own directory\" seemed best.\n\nIf you don\u0027t include an __init__.py the package will not be considered a package by python and the pkg_resources call will not work. In addition the bdist_wheel tools will produce a warning which I guess some packaging situations would treat as an error and blow things up.\n\nI\u0027ll put a doc string in the __init__.py itself. Don\u0027t want to muddy things with a README.","commit_id":"76814664c129d921dc3311c716d42c985049cc07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eea0e53350bffbf6a30682dcb31c5e0556c35840","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Their filenames may be discovered using ``pkg_resources`` to look in the"},{"line_number":17,"context_line":"``placement_db_tools`` package:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    pkg_resources.resource_filename(\u0027placement_db_tools\u0027, \u0027mysql-migrate-db.sh\u0027)"},{"line_number":20,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_5cda6a17","line":19,"updated":"2019-05-07 00:08:22.000000000","message":"pep8 line too long","commit_id":"582bdaa9b73e0983334fa9bf7380e4e719c3fa2f"}]}