)]}'
{"id":"openstack%2Fplacement~657716","triplet_id":"openstack%2Fplacement~master~I84baff29505550f3f20069ad5817784d0d1aaea6","project":"openstack/placement","branch":"master","topic":"cd/profiler-hack","hashtags":[],"change_id":"I84baff29505550f3f20069ad5817784d0d1aaea6","subject":"Remove null root provider protections","status":"MERGED","created":"2019-05-08 01:39:24.000000000","updated":"2019-05-23 14:09:13.000000000","submitted":"2019-05-23 14:09:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"657716-1558620553243-36664bbb","meta_rev_id":"aa7326d37adaa441b3e74da3ad93b4a113fd7807","_number":657716,"virtual_id_number":657716,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-23 09:16:47.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-05-23 14:09:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-05-23 11:40:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-05-22 21:42:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2019-05-23 11:40:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-08 02:19:18.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-05-10 13:31:47.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-22 21:42:05.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-23 11:40:38.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-05-23 14:09:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"add289647237b93fa18036681cfde6f351b7402b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-08 01:39:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e3bfee99bb1350a05186ee3358e995ea0d63794","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-08 02:19:18.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"84cf4a4130ca4fee8739bce70f423cc534286697","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 03:17:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/16/657716/1/check/grenade-py3/3e2ecf4/ : SUCCESS in 57m 21s\n- tempest-full-py3 http://logs.openstack.org/16/657716/1/check/tempest-full-py3/0ba1506/ : SUCCESS in 1h 37m 25s\n- openstack-tox-docs http://logs.openstack.org/16/657716/1/check/openstack-tox-docs/4f0b0b9/html/ : SUCCESS in 3m 45s\n- openstack-tox-cover http://logs.openstack.org/16/657716/1/check/openstack-tox-cover/b8b90d3/cover/ : SUCCESS in 6m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/657716/1/check/openstack-tox-lower-constraints/a5e6ecb/ : SUCCESS in 5m 45s\n- openstack-tox-pep8 http://logs.openstack.org/16/657716/1/check/openstack-tox-pep8/d9aa0ad/ : FAILURE in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/16/657716/1/check/openstack-tox-py27/65dbcb6/ : SUCCESS in 3m 55s\n- openstack-tox-py36 http://logs.openstack.org/16/657716/1/check/openstack-tox-py36/f728d05/ : SUCCESS in 9m 43s\n- openstack-tox-py37 http://logs.openstack.org/16/657716/1/check/openstack-tox-py37/2833ce9/ : SUCCESS in 5m 00s\n- openstack-tox-functional http://logs.openstack.org/16/657716/1/check/openstack-tox-functional/f03f867/ : SUCCESS in 9m 57s\n- openstack-tox-functional-py36 http://logs.openstack.org/16/657716/1/check/openstack-tox-functional-py36/c1a0671/ : SUCCESS in 4m 09s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/16/657716/1/check/placement-nova-tox-functional-py36/b93bcdf/ : SUCCESS in 11m 30s\n- placement-perfload http://logs.openstack.org/16/657716/1/check/placement-perfload/ff6cacb/ : SUCCESS in 4m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2afb9779466ade450502f4d15cba15c22388f105","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-08 04:40:19.000000000","message":"Patch Set 1:\n\nThanks for noticing Tetsuro. That\u0027s a bit disappointing but makes sense. I\u0027ll abandon[1]  this for now, make a note on the story, and look for other places where the profiling shows some possibilities.\n\n[1] Instead of a -2, so it\u0027s not showing on the radar.","accounts_in_message":[],"_revision_number":1},{"id":"940b51b3a2858cdb603d1353d94bc253d1df9185","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-08 04:40:31.000000000","message":"Abandoned\n\nWait until U.","accounts_in_message":[],"_revision_number":1},{"id":"8582d7449d216c00a5e327bb1b98857b1fc03f9e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 17:32:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4986d92f42ed09e51d92ac8fdd918979a81d1c5f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:54:00.000000000","message":"Patch Set 1:\n\nYou could rebase on the series I started here:\n\nhttps://review.opendev.org/#/c/658164/","accounts_in_message":[],"_revision_number":1},{"id":"c3d9344457fc243d931fbcd99528b71694e4b3ea","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:54:24.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"3df86b3d9805a03b06b1124ea82319abe7d583a4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:54:36.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"06b04bccc07ee4f0f1afe4f1855678716ca046ec","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:54:48.000000000","message":"Topic changed from cd/profiler-hack to story/2005613","accounts_in_message":[],"_revision_number":2},{"id":"74094d151fe3da2d1cadee70a545c52e3e8148d7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:56:39.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"01200c202606e056fe996641fc269750313c0d28","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-09 21:45:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a718891d90473ab375f032ed9b5f3c42a4bcad15","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-09 21:53:38.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"57305233056b4f26574b03c13761222c46e43af8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-09 21:54:41.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"4c45a2e66773759ad972f340608d2513a73a84fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 23:45:04.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/16/657716/5/check/grenade-py3/b875411/ : FAILURE in 43m 22s\n- tempest-full-py3 http://logs.openstack.org/16/657716/5/check/tempest-full-py3/65f2e63/ : SUCCESS in 1h 33m 19s\n- openstack-tox-docs http://logs.openstack.org/16/657716/5/check/openstack-tox-docs/9769804/html/ : SUCCESS in 3m 55s\n- openstack-tox-cover http://logs.openstack.org/16/657716/5/check/openstack-tox-cover/8b5cf55/cover/ : SUCCESS in 4m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/657716/5/check/openstack-tox-lower-constraints/15cb611/ : SUCCESS in 4m 45s\n- openstack-tox-pep8 http://logs.openstack.org/16/657716/5/check/openstack-tox-pep8/6e21b81/ : SUCCESS in 3m 44s\n- openstack-tox-py27 http://logs.openstack.org/16/657716/5/check/openstack-tox-py27/87e020e/ : SUCCESS in 3m 59s\n- openstack-tox-py36 http://logs.openstack.org/16/657716/5/check/openstack-tox-py36/a82ff3c/ : SUCCESS in 4m 59s\n- openstack-tox-py37 http://logs.openstack.org/16/657716/5/check/openstack-tox-py37/a263733/ : SUCCESS in 4m 43s\n- openstack-tox-functional http://logs.openstack.org/16/657716/5/check/openstack-tox-functional/95f8d16/ : SUCCESS in 4m 57s\n- openstack-tox-functional-py36 http://logs.openstack.org/16/657716/5/check/openstack-tox-functional-py36/d7e2b96/ : SUCCESS in 4m 11s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/16/657716/5/check/placement-nova-tox-functional-py36/1739386/ : SUCCESS in 10m 45s\n- placement-perfload http://logs.openstack.org/16/657716/5/check/placement-perfload/766f3fe/ : SUCCESS in 3m 37s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"ab0879d83e970eeb27adb54ac1b11e5e357b1440","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-10 13:31:47.000000000","message":"Patch Set 5:\n\nrecheck grenade unrelated","accounts_in_message":[],"_revision_number":5},{"id":"c6250001e41391d9d24cd363a17fc645d54aefb7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 16:11:20.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/16/657716/5/check/grenade-py3/0d0456e/ : SUCCESS in 58m 30s\n- tempest-full-py3 http://logs.openstack.org/16/657716/5/check/tempest-full-py3/09c4768/ : SUCCESS in 1h 26m 04s\n- openstack-tox-docs http://logs.openstack.org/16/657716/5/check/openstack-tox-docs/50796e1/html/ : SUCCESS in 5m 49s\n- openstack-tox-cover http://logs.openstack.org/16/657716/5/check/openstack-tox-cover/56e00b8/cover/ : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/657716/5/check/openstack-tox-lower-constraints/7c9515e/ : SUCCESS in 4m 44s\n- openstack-tox-pep8 http://logs.openstack.org/16/657716/5/check/openstack-tox-pep8/98efabe/ : SUCCESS in 4m 04s\n- openstack-tox-py27 http://logs.openstack.org/16/657716/5/check/openstack-tox-py27/5b28e06/ : SUCCESS in 4m 05s\n- openstack-tox-py36 http://logs.openstack.org/16/657716/5/check/openstack-tox-py36/6c28267/ : SUCCESS in 3m 47s\n- openstack-tox-py37 http://logs.openstack.org/16/657716/5/check/openstack-tox-py37/237a5e6/ : SUCCESS in 4m 29s\n- openstack-tox-functional http://logs.openstack.org/16/657716/5/check/openstack-tox-functional/b0d73c5/ : SUCCESS in 4m 38s\n- openstack-tox-functional-py36 http://logs.openstack.org/16/657716/5/check/openstack-tox-functional-py36/6dacb5a/ : SUCCESS in 6m 40s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/16/657716/5/check/placement-nova-tox-functional-py36/b07f289/ : SUCCESS in 14m 36s\n- placement-perfload http://logs.openstack.org/16/657716/5/check/placement-perfload/e49ba84/ : SUCCESS in 3m 28s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"7120174aef554cf9e15b33192e584aa2b833085e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-22 19:19:32.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"a61e762916ef877071e6771c56eb9f3a230f4493","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-22 21:42:05.000000000","message":"Patch Set 6: Code-Review+2\n\n(2 comments)\n\nOne miss and a question. Both can be fixed up later. Let\u0027s make this happen.","accounts_in_message":[],"_revision_number":6},{"id":"8ed884dd455014758e75866418ddb7f6ed4a6c02","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 05:55:34.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/16/657716/6/check/grenade-py3/77794a0/ : SUCCESS in 59m 31s\n- tempest-full-py3 http://logs.openstack.org/16/657716/6/check/tempest-full-py3/fd0f2b3/ : SUCCESS in 1h 23m 56s\n- openstack-tox-docs http://logs.openstack.org/16/657716/6/check/openstack-tox-docs/8bdfebf/html/ : SUCCESS in 3m 54s\n- openstack-tox-cover http://logs.openstack.org/16/657716/6/check/openstack-tox-cover/83e15b8/cover/ : SUCCESS in 5m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/657716/6/check/openstack-tox-lower-constraints/6b1c7ea/ : SUCCESS in 5m 17s\n- openstack-tox-pep8 http://logs.openstack.org/16/657716/6/check/openstack-tox-pep8/273964e/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/16/657716/6/check/openstack-tox-py27/e3e142d/ : SUCCESS in 4m 20s\n- openstack-tox-py36 http://logs.openstack.org/16/657716/6/check/openstack-tox-py36/69d22b3/ : SUCCESS in 3m 59s\n- openstack-tox-py37 http://logs.openstack.org/16/657716/6/check/openstack-tox-py37/a6c1191/ : SUCCESS in 4m 48s\n- openstack-tox-functional http://logs.openstack.org/16/657716/6/check/openstack-tox-functional/f0dd3f7/ : SUCCESS in 4m 51s\n- openstack-tox-functional-py36 http://logs.openstack.org/16/657716/6/check/openstack-tox-functional-py36/c21ed27/ : SUCCESS in 4m 20s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/16/657716/6/check/placement-nova-tox-functional-py36/d05f60d/ : SUCCESS in 12m 15s\n- placement-perfload http://logs.openstack.org/16/657716/6/check/placement-perfload/9b9e780/ : SUCCESS in 3m 25s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"5564adc5f843d5141d079f1c23a5a8e94cbfeee8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-23 09:16:47.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nGot the concerns identified by Eric in https://review.opendev.org/#/c/660951/","accounts_in_message":[],"_revision_number":6},{"id":"fbfb6748da002cc8b863f522bb80dbc88428d64f","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-05-23 11:40:38.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\nLooks good and the follow up checks out as well.\nCheers,\ngibi","accounts_in_message":[],"_revision_number":6},{"id":"e2f2cc101800ce1380744e5a5fac49141f2c994f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 11:41:02.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"3838d2ba011763c95b93c11be7a5ba2ffb4b1250","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 14:09:12.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/16/657716/6/gate/grenade-py3/2422e2d/ : SUCCESS in 56m 27s\n- tempest-full-py3 http://logs.openstack.org/16/657716/6/gate/tempest-full-py3/8775642/ : SUCCESS in 1h 20m 04s\n- openstack-tox-docs http://logs.openstack.org/16/657716/6/gate/openstack-tox-docs/2529e8a/html/ : SUCCESS in 4m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/657716/6/gate/openstack-tox-lower-constraints/0a39295/ : SUCCESS in 4m 50s\n- openstack-tox-pep8 http://logs.openstack.org/16/657716/6/gate/openstack-tox-pep8/b0b1f60/ : SUCCESS in 4m 26s\n- openstack-tox-py27 http://logs.openstack.org/16/657716/6/gate/openstack-tox-py27/21c7b61/ : SUCCESS in 3m 56s\n- openstack-tox-py36 http://logs.openstack.org/16/657716/6/gate/openstack-tox-py36/7404562/ : SUCCESS in 4m 18s\n- openstack-tox-py37 http://logs.openstack.org/16/657716/6/gate/openstack-tox-py37/9e20a1d/ : SUCCESS in 4m 51s\n- openstack-tox-functional http://logs.openstack.org/16/657716/6/gate/openstack-tox-functional/746ec06/ : SUCCESS in 5m 31s\n- openstack-tox-functional-py36 http://logs.openstack.org/16/657716/6/gate/openstack-tox-functional-py36/252060e/ : SUCCESS in 5m 51s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/16/657716/6/gate/placement-nova-tox-functional-py36/4c217f7/ : SUCCESS in 11m 18s","accounts_in_message":[],"_revision_number":6},{"id":"c7bc1a0ab6354a1a2facc87530e0791e308147f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 14:09:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"e0efa65e296eea041f88e38cee898f1e7b785798","revisions":{"e7a94e469265edffbba57b15aa54a35b7cca60c6":{"kind":"REWORK","_number":1,"created":"2019-05-08 01:39:24.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/16/657716/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/1"}}},"commit":{"parents":[{"commit":"57026255615679122e6f305dfa3520c012f57ca7","subject":"Merge \"Skip notification sample tests when running nova functional\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57026255615679122e6f305dfa3520c012f57ca7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:34:14.000000000","tz":-420},"subject":"WIP: Remove null root provider protections","message":"WIP: Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check.\n\nThis is a WIP because:\n\n* I\u0027m out of brain and I don\u0027t know if I\u0027m done.\n* Release note required\n* Do we need a stopper migration or something of that ilk?\n\nBased on profiling, removing the in_ ought to make things\nmore tidy.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e7a94e469265edffbba57b15aa54a35b7cca60c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e7a94e469265edffbba57b15aa54a35b7cca60c6"}]},"branch":"refs/heads/master"},"f1c141f68e911bb557d51003995707011ba9f993":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-05-09 18:54:36.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/16/657716/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/2"}}},"commit":{"parents":[{"commit":"07cbce8e857b31b901d7801db2928a0f0439ace9","subject":"WIP: Add blocker alembic migration for null root_provider_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07cbce8e857b31b901d7801db2928a0f0439ace9"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-09 18:54:36.000000000","tz":0},"subject":"WIP: Remove null root provider protections","message":"WIP: Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check.\n\nThis is a WIP because:\n\n* I\u0027m out of brain and I don\u0027t know if I\u0027m done.\n* Release note required\n* Do we need a stopper migration or something of that ilk?\n\nBased on profiling, removing the in_ ought to make things\nmore tidy.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f1c141f68e911bb557d51003995707011ba9f993"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f1c141f68e911bb557d51003995707011ba9f993"}]},"branch":"refs/heads/master"},"5cc67ddf8e4bf22955590cffae3af686d2544412":{"kind":"REWORK","_number":3,"created":"2019-05-09 21:45:26.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/16/657716/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/3"}}},"commit":{"parents":[{"commit":"07cbce8e857b31b901d7801db2928a0f0439ace9","subject":"WIP: Add blocker alembic migration for null root_provider_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07cbce8e857b31b901d7801db2928a0f0439ace9"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-09 21:37:20.000000000","tz":-420},"subject":"Remove null root provider protections","message":"Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check and now\n(prior to this patch) there is a blocker migration and the\nstatus check is an error instead of warning.\n\nThe release note for the change of the status check should\nsuffice for covering this. That is: it makes what it says,\nTrue.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/5cc67ddf8e4bf22955590cffae3af686d2544412"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/5cc67ddf8e4bf22955590cffae3af686d2544412"}]},"branch":"refs/heads/master"},"38f083ea828279320c92afd06a6f5a449fc062dd":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2019-05-09 21:53:38.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/16/657716/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/4"}}},"commit":{"parents":[{"commit":"57026255615679122e6f305dfa3520c012f57ca7","subject":"Merge \"Skip notification sample tests when running nova functional\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57026255615679122e6f305dfa3520c012f57ca7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-09 21:49:27.000000000","tz":-420},"subject":"Remove null root provider protections","message":"Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check and now\n(prior to this patch) there is a blocker migration and the\nstatus check is an error instead of warning.\n\nThe release note for the change of the status check should\nsuffice for covering this. That is: it makes what it says,\nTrue.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/38f083ea828279320c92afd06a6f5a449fc062dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/38f083ea828279320c92afd06a6f5a449fc062dd"}]},"branch":"refs/heads/master"},"4b3a15eb11ba90349c08edb324c47657a64512f0":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2019-05-09 21:54:41.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/16/657716/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/5"}}},"commit":{"parents":[{"commit":"07cbce8e857b31b901d7801db2928a0f0439ace9","subject":"WIP: Add blocker alembic migration for null root_provider_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07cbce8e857b31b901d7801db2928a0f0439ace9"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-09 21:54:21.000000000","tz":-420},"subject":"Remove null root provider protections","message":"Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check and now\n(prior to this patch) there is a blocker migration and the\nstatus check is an error instead of warning.\n\nThe release note for the change of the status check should\nsuffice for covering this. That is: it makes what it says,\nTrue.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4b3a15eb11ba90349c08edb324c47657a64512f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4b3a15eb11ba90349c08edb324c47657a64512f0"}]},"branch":"refs/heads/master"},"e0efa65e296eea041f88e38cee898f1e7b785798":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2019-05-22 19:19:32.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/16/657716/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/16/657716/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/16/657716/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/16/657716/6"}}},"commit":{"parents":[{"commit":"4606e55d1912c29348b49dfa42e0d7792f77f638","subject":"Add blocker alembic migration for null root_provider_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4606e55d1912c29348b49dfa42e0d7792f77f638"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-08 01:33:36.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-22 19:18:27.000000000","tz":-240},"subject":"Remove null root provider protections","message":"Remove null root provider protections\n\nA when root providers were added, a series of TODOs were\nleft in allocation candidate and resource provider data\nhandling. These TODOs should be removed once we are assured\nthat there are no null roots. That is the case now, given\nthat we had an online migration and a status check and now\n(prior to this patch) there is a blocker migration and the\nstatus check is an error instead of warning.\n\nThe release note for the change of the status check should\nsuffice for covering this. That is: it makes what it says,\nTrue.\n\nStory: 2005613\nTask: 30860\nChange-Id: I84baff29505550f3f20069ad5817784d0d1aaea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e0efa65e296eea041f88e38cee898f1e7b785798"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e0efa65e296eea041f88e38cee898f1e7b785798"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}