)]}'
{"id":"openstack%2Fplacement~658182","triplet_id":"openstack%2Fplacement~master~I74c49d286dfc62f49af24303ed1cb18489e7e89d","project":"openstack/placement","branch":"master","topic":"cd/profiler-hack","hashtags":[],"change_id":"I74c49d286dfc62f49af24303ed1cb18489e7e89d","subject":"Add blocker alembic migration for null root_provider_ids","status":"MERGED","created":"2019-05-09 18:49:17.000000000","updated":"2019-05-23 12:08:19.000000000","submitted":"2019-05-23 12:08:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658182-1558613299266-263a428c","meta_rev_id":"92e87efdeda18a76eeedd9dbe6fa4a1d4c204cf3","_number":658182,"virtual_id_number":658182,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-05-23 12:08:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-05-22 21:02:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-05-23 09:19:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-05-23 09:19:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-22 21:02:25.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-23 09:19:49.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-05-23 12:08:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7269c1ebe5ffb9608ca5c9713da1e2a7e9d3f15a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:49:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"288af6d4df19ee8db0ec33be01d3c35a383f61b3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-09 18:52:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"44608ff260027b20f56ef14db15d668b7c0c4744","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-09 21:48:13.000000000","message":"Patch Set 1:\n\n(1 comment)\n\ngrammar nit with\n\nFor the testing I would think that looking at test_upgrade_twice in functional.db.test_migration might point the way:\n\nupgrade to the version before the blocker\ncreate an rp with a null root\nupgrade to the version with the blocker watch it explode\n\nThanks for doing this, removing some cruft out of the db code will be a very nice thing.","accounts_in_message":[],"_revision_number":1},{"id":"d249a807175859696990664b745c0ad3f38b049f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 22:51:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/82/658182/1/check/grenade-py3/3221660/ : SUCCESS in 1h 08m 33s\n- tempest-full-py3 http://logs.openstack.org/82/658182/1/check/tempest-full-py3/26ee333/ : SUCCESS in 1h 43m 36s\n- openstack-tox-docs http://logs.openstack.org/82/658182/1/check/openstack-tox-docs/9ddd583/html/ : SUCCESS in 4m 26s\n- openstack-tox-cover http://logs.openstack.org/82/658182/1/check/openstack-tox-cover/c56f4c6/cover/ : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/658182/1/check/openstack-tox-lower-constraints/a85ac59/ : SUCCESS in 6m 01s\n- openstack-tox-pep8 http://logs.openstack.org/82/658182/1/check/openstack-tox-pep8/d9ecf52/ : SUCCESS in 5m 36s\n- openstack-tox-py27 http://logs.openstack.org/82/658182/1/check/openstack-tox-py27/33ab724/ : SUCCESS in 6m 00s\n- openstack-tox-py36 http://logs.openstack.org/82/658182/1/check/openstack-tox-py36/eef3e83/ : SUCCESS in 5m 32s\n- openstack-tox-py37 http://logs.openstack.org/82/658182/1/check/openstack-tox-py37/74a2d00/ : SUCCESS in 5m 12s\n- openstack-tox-functional http://logs.openstack.org/82/658182/1/check/openstack-tox-functional/67fa09a/ : SUCCESS in 4m 12s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/658182/1/check/openstack-tox-functional-py36/81635f2/ : SUCCESS in 4m 47s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/658182/1/check/placement-nova-tox-functional-py36/5d9e8ac/ : SUCCESS in 10m 52s\n- placement-perfload http://logs.openstack.org/82/658182/1/check/placement-perfload/4878221/ : SUCCESS in 3m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3fea4476ff9f440d84e88faa6a5b91e77b1492e9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-10 13:31:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3280dbb4dfa8347099d70865be6a6e54d629e399","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-22 19:19:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"74aeb4bbc5802f8de4917c72acfb99d33fb7aa33","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-22 21:02:25.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8c9f5ebbe2d5747cb65b1daf4f0f2c29387a91a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 05:56:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/82/658182/2/check/grenade-py3/26f0b50/ : SUCCESS in 1h 01m 16s\n- tempest-full-py3 http://logs.openstack.org/82/658182/2/check/tempest-full-py3/e25c795/ : SUCCESS in 1h 29m 45s\n- openstack-tox-docs http://logs.openstack.org/82/658182/2/check/openstack-tox-docs/a046d58/html/ : SUCCESS in 4m 30s\n- openstack-tox-cover http://logs.openstack.org/82/658182/2/check/openstack-tox-cover/93b19de/cover/ : SUCCESS in 4m 56s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/658182/2/check/openstack-tox-lower-constraints/e0bd2c4/ : SUCCESS in 4m 30s\n- openstack-tox-pep8 http://logs.openstack.org/82/658182/2/check/openstack-tox-pep8/8753676/ : SUCCESS in 3m 43s\n- openstack-tox-py27 http://logs.openstack.org/82/658182/2/check/openstack-tox-py27/cd767e9/ : SUCCESS in 3m 57s\n- openstack-tox-py36 http://logs.openstack.org/82/658182/2/check/openstack-tox-py36/5ab952b/ : SUCCESS in 5m 15s\n- openstack-tox-py37 http://logs.openstack.org/82/658182/2/check/openstack-tox-py37/d318453/ : SUCCESS in 6m 26s\n- openstack-tox-functional http://logs.openstack.org/82/658182/2/check/openstack-tox-functional/e367323/ : SUCCESS in 5m 54s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/658182/2/check/openstack-tox-functional-py36/4c02f8d/ : SUCCESS in 5m 46s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/658182/2/check/placement-nova-tox-functional-py36/723b00f/ : SUCCESS in 12m 37s\n- placement-perfload http://logs.openstack.org/82/658182/2/check/placement-perfload/afb83e8/ : SUCCESS in 3m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0504cec14a167666466edf81e2ea7660bfbe8399","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-23 09:19:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nnice test","accounts_in_message":[],"_revision_number":2},{"id":"de180dea5f608ee4076e5ac8c9923a3200385676","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 09:20:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"45e8cbd032bbd6a84c2e06b86e810be40b1676c4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 12:08:18.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/82/658182/2/gate/grenade-py3/576ea22/ : SUCCESS in 56m 52s\n- tempest-full-py3 http://logs.openstack.org/82/658182/2/gate/tempest-full-py3/b21f712/ : SUCCESS in 1h 36m 38s\n- openstack-tox-docs http://logs.openstack.org/82/658182/2/gate/openstack-tox-docs/9196fa7/html/ : SUCCESS in 4m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/658182/2/gate/openstack-tox-lower-constraints/c3f8bc5/ : SUCCESS in 5m 38s\n- openstack-tox-pep8 http://logs.openstack.org/82/658182/2/gate/openstack-tox-pep8/fc705b0/ : SUCCESS in 4m 44s\n- openstack-tox-py27 http://logs.openstack.org/82/658182/2/gate/openstack-tox-py27/989177a/ : SUCCESS in 5m 48s\n- openstack-tox-py36 http://logs.openstack.org/82/658182/2/gate/openstack-tox-py36/f51eea1/ : SUCCESS in 4m 37s\n- openstack-tox-py37 http://logs.openstack.org/82/658182/2/gate/openstack-tox-py37/50a9ab4/ : SUCCESS in 6m 18s\n- openstack-tox-functional http://logs.openstack.org/82/658182/2/gate/openstack-tox-functional/01b1b22/ : SUCCESS in 5m 41s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/658182/2/gate/openstack-tox-functional-py36/5d4962d/ : SUCCESS in 7m 46s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/658182/2/gate/placement-nova-tox-functional-py36/7c5a634/ : SUCCESS in 11m 55s","accounts_in_message":[],"_revision_number":2},{"id":"e1403266dd7646abfa8896fbd72ed80492d2c79a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 12:08:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4606e55d1912c29348b49dfa42e0d7792f77f638","revisions":{"07cbce8e857b31b901d7801db2928a0f0439ace9":{"kind":"REWORK","_number":1,"created":"2019-05-09 18:49:17.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/82/658182/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/658182/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/658182/1"}}},"commit":{"parents":[{"commit":"2b8e7dfdf79a6650cd48ad56b069d62fddcaf00a","subject":"Change \"Missing Root Provider IDs\" upgrade check to a failure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/2b8e7dfdf79a6650cd48ad56b069d62fddcaf00a"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-09 18:47:58.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-09 18:47:58.000000000","tz":-240},"subject":"WIP: Add blocker alembic migration for null root_provider_ids","message":"WIP: Add blocker alembic migration for null root_provider_ids\n\nThis adds an alembic migration script which will block a db_sync\nif the online data migration has not been run.\n\nWIP since tests are tricky...\n\nChange-Id: I74c49d286dfc62f49af24303ed1cb18489e7e89d\nStory: 2005613\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07cbce8e857b31b901d7801db2928a0f0439ace9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07cbce8e857b31b901d7801db2928a0f0439ace9"}]},"branch":"refs/heads/master"},"4606e55d1912c29348b49dfa42e0d7792f77f638":{"kind":"REWORK","_number":2,"created":"2019-05-22 19:19:32.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/82/658182/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/658182/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/658182/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/658182/2"}}},"commit":{"parents":[{"commit":"4af1df9408adb79497be30496078b246c39601ae","subject":"Change \"Missing Root Provider IDs\" upgrade check to a failure","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4af1df9408adb79497be30496078b246c39601ae"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-09 18:47:58.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-22 19:17:42.000000000","tz":-240},"subject":"Add blocker alembic migration for null root_provider_ids","message":"Add blocker alembic migration for null root_provider_ids\n\nThis adds an alembic migration script which will block a db_sync\nif the online data migration has not been run.\n\nChange-Id: I74c49d286dfc62f49af24303ed1cb18489e7e89d\nStory: 2005613\nTask: 30921\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4606e55d1912c29348b49dfa42e0d7792f77f638"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4606e55d1912c29348b49dfa42e0d7792f77f638"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}