)]}'
{"id":"openstack%2Fplacement~658977","triplet_id":"openstack%2Fplacement~master~I4efdc65395e69a6d33fba927018d003cce26fa68","project":"openstack/placement","branch":"master","topic":"bug/1828937","hashtags":[],"change_id":"I4efdc65395e69a6d33fba927018d003cce26fa68","subject":"Skip _exclude_nested_providers() if not nested","status":"MERGED","created":"2019-05-14 07:47:36.000000000","updated":"2019-05-15 02:00:54.000000000","submitted":"2019-05-14 20:04:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658977-1557864282890-0de1d12d","meta_rev_id":"0449b8283e4a78b619e3a622f4bbc2f14cff9639","_number":658977,"virtual_id_number":658977,"owner":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-05-14 20:04:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-05-14 15:31:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-14 17:48:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-14 17:48:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-14 15:31:17.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-14 17:48:45.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-05-14 20:04:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"04c789e03c0909ab550eefdb04c1744b46bf84f0","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-14 07:47:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d47f9a403f5c4428f1831aa6489171296fa3750a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 09:20:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/77/658977/1/check/grenade-py3/b44c49a/ : SUCCESS in 55m 39s\n- tempest-full-py3 http://logs.openstack.org/77/658977/1/check/tempest-full-py3/a22bf64/ : SUCCESS in 1h 31m 29s\n- openstack-tox-docs http://logs.openstack.org/77/658977/1/check/openstack-tox-docs/7dc1095/html/ : SUCCESS in 4m 07s\n- openstack-tox-cover http://logs.openstack.org/77/658977/1/check/openstack-tox-cover/0e0b551/cover/ : SUCCESS in 4m 53s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/658977/1/check/openstack-tox-lower-constraints/205e581/ : SUCCESS in 4m 18s\n- openstack-tox-pep8 http://logs.openstack.org/77/658977/1/check/openstack-tox-pep8/b3566b1/ : FAILURE in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/77/658977/1/check/openstack-tox-py27/736b8e1/ : SUCCESS in 3m 49s\n- openstack-tox-py36 http://logs.openstack.org/77/658977/1/check/openstack-tox-py36/e95c94d/ : SUCCESS in 4m 11s\n- openstack-tox-py37 http://logs.openstack.org/77/658977/1/check/openstack-tox-py37/64ef354/ : SUCCESS in 4m 38s\n- openstack-tox-functional http://logs.openstack.org/77/658977/1/check/openstack-tox-functional/663854c/ : SUCCESS in 4m 46s\n- openstack-tox-functional-py36 http://logs.openstack.org/77/658977/1/check/openstack-tox-functional-py36/b954939/ : SUCCESS in 4m 25s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/77/658977/1/check/placement-nova-tox-functional-py36/68e1a34/ : SUCCESS in 11m 27s\n- placement-perfload http://logs.openstack.org/77/658977/1/check/placement-perfload/be7ae80/ : SUCCESS in 3m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0d6688f6c1211613b10f32dff9012183984f27d9","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-14 09:33:46.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"77a3d1d185d75730992d9820c01badca7f8841d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 11:04:01.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/77/658977/2/check/grenade-py3/d162279/ : SUCCESS in 1h 00m 51s\n- tempest-full-py3 http://logs.openstack.org/77/658977/2/check/tempest-full-py3/303fbda/ : SUCCESS in 1h 29m 07s\n- openstack-tox-docs http://logs.openstack.org/77/658977/2/check/openstack-tox-docs/c35d11b/html/ : SUCCESS in 4m 01s\n- openstack-tox-cover http://logs.openstack.org/77/658977/2/check/openstack-tox-cover/8b5e55e/cover/ : SUCCESS in 4m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/658977/2/check/openstack-tox-lower-constraints/1624659/ : SUCCESS in 4m 36s\n- openstack-tox-pep8 http://logs.openstack.org/77/658977/2/check/openstack-tox-pep8/427c551/ : FAILURE in 4m 18s\n- openstack-tox-py27 http://logs.openstack.org/77/658977/2/check/openstack-tox-py27/c0a7d4a/ : SUCCESS in 3m 43s\n- openstack-tox-py36 http://logs.openstack.org/77/658977/2/check/openstack-tox-py36/3504a1b/ : SUCCESS in 5m 42s\n- openstack-tox-py37 http://logs.openstack.org/77/658977/2/check/openstack-tox-py37/0899b8e/ : SUCCESS in 4m 57s\n- openstack-tox-functional http://logs.openstack.org/77/658977/2/check/openstack-tox-functional/4982ec1/ : SUCCESS in 4m 55s\n- openstack-tox-functional-py36 http://logs.openstack.org/77/658977/2/check/openstack-tox-functional-py36/992e796/ : SUCCESS in 6m 12s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/77/658977/2/check/placement-nova-tox-functional-py36/e815038/ : SUCCESS in 11m 22s\n- placement-perfload http://logs.openstack.org/77/658977/2/check/placement-perfload/2af977b/ : SUCCESS in 3m 38s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c0704c9a9a5ea40f922cf6dd47b5e7a282f4ed3e","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-14 12:09:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fd8375664a1634c824c6c38aa6db8260fc332132","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 13:52:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/77/658977/3/check/grenade-py3/8359215/ : SUCCESS in 59m 48s\n- tempest-full-py3 http://logs.openstack.org/77/658977/3/check/tempest-full-py3/f068361/ : SUCCESS in 1h 42m 21s\n- openstack-tox-docs http://logs.openstack.org/77/658977/3/check/openstack-tox-docs/1773f86/html/ : SUCCESS in 4m 00s\n- openstack-tox-cover http://logs.openstack.org/77/658977/3/check/openstack-tox-cover/38a34cb/cover/ : SUCCESS in 4m 43s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/658977/3/check/openstack-tox-lower-constraints/917914c/ : SUCCESS in 4m 32s\n- openstack-tox-pep8 http://logs.openstack.org/77/658977/3/check/openstack-tox-pep8/8007375/ : SUCCESS in 4m 41s\n- openstack-tox-py27 http://logs.openstack.org/77/658977/3/check/openstack-tox-py27/61a8846/ : SUCCESS in 4m 00s\n- openstack-tox-py36 http://logs.openstack.org/77/658977/3/check/openstack-tox-py36/90e59ef/ : SUCCESS in 3m 53s\n- openstack-tox-py37 http://logs.openstack.org/77/658977/3/check/openstack-tox-py37/6bf5eac/ : SUCCESS in 4m 06s\n- openstack-tox-functional http://logs.openstack.org/77/658977/3/check/openstack-tox-functional/275709c/ : SUCCESS in 4m 31s\n- openstack-tox-functional-py36 http://logs.openstack.org/77/658977/3/check/openstack-tox-functional-py36/f99f053/ : SUCCESS in 4m 33s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/77/658977/3/check/placement-nova-tox-functional-py36/499e660/ : SUCCESS in 10m 22s\n- placement-perfload http://logs.openstack.org/77/658977/3/check/placement-perfload/ed8d920/ : SUCCESS in 3m 07s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ecf9e4a717927e963266cd1ff5b55c17d0b334c1","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-14 15:31:17.000000000","message":"Patch Set 3: Code-Review+2\n\nThis is a clear win, great work Tetsuro.\n\nI have concerns about backporting, but they don\u0027t have to hold up this patch.\n\nAre we really thinking to backport this to rocky? That would entail first making a stable-only patch in the nova repo in stein. That said, is there an alternative for folks running rocky? Is it possible to run extracted stein+ placement against rocky everything-else? (I don\u0027t see why it wouldn\u0027t be from an API point of view, but I\u0027m not sure what barriers would exist in terms of upper constraints and distros and configuration...)\n\nConclusion of above musings: particularly considering how self-contained this fix is, making stable-only patches in nova seems like a reasonable plan.","accounts_in_message":[],"_revision_number":3},{"id":"4b8df2e98b7871adb47548a6de980e6ff195379e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-14 17:48:45.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nThanks for doing this. I especially like that the data manipulation method has been moved to the data manipulation python files, out of the handlers.\n\nRe backporting: if people want it, we should considering doing it, but only if there is demand. The impact of OVO on performance is significant enough that if people have performance issues they are best served by upgrading to extracted placement, even if they continue to run older nova/neutron. They will need to be intelligent about migrating their data, but we have at least one person who is already doing this:\n\n* throughout the day after: http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-05-03.log.html#t2019-05-03T16:41:47\n* http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-05-10.log.html#t2019-05-10T17:51:03","accounts_in_message":[],"_revision_number":3},{"id":"71a6a113a408f5bea776d3fd35b80477abed4c24","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 17:48:58.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"148ecd62c04db5c69c752c5a501a6d35008e81dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 20:04:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"857ea03bcc071327add68fb56de11c4df1229641","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-14 20:04:42.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/77/658977/3/gate/grenade-py3/feb46d8/ : SUCCESS in 58m 29s\n- tempest-full-py3 http://logs.openstack.org/77/658977/3/gate/tempest-full-py3/7e353ce/ : SUCCESS in 1h 42m 06s\n- openstack-tox-docs http://logs.openstack.org/77/658977/3/gate/openstack-tox-docs/e624720/html/ : SUCCESS in 5m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/77/658977/3/gate/openstack-tox-lower-constraints/10c6ef1/ : SUCCESS in 5m 41s\n- openstack-tox-pep8 http://logs.openstack.org/77/658977/3/gate/openstack-tox-pep8/6d38016/ : SUCCESS in 4m 28s\n- openstack-tox-py27 http://logs.openstack.org/77/658977/3/gate/openstack-tox-py27/bf05e7e/ : SUCCESS in 3m 46s\n- openstack-tox-py36 http://logs.openstack.org/77/658977/3/gate/openstack-tox-py36/d8ddd45/ : SUCCESS in 4m 15s\n- openstack-tox-py37 http://logs.openstack.org/77/658977/3/gate/openstack-tox-py37/43d4154/ : SUCCESS in 4m 48s\n- openstack-tox-functional http://logs.openstack.org/77/658977/3/gate/openstack-tox-functional/df24ab3/ : SUCCESS in 4m 35s\n- openstack-tox-functional-py36 http://logs.openstack.org/77/658977/3/gate/openstack-tox-functional-py36/db2a79c/ : SUCCESS in 4m 37s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/77/658977/3/gate/placement-nova-tox-functional-py36/c86d76d/ : SUCCESS in 11m 18s","accounts_in_message":[],"_revision_number":3},{"id":"eea874ff4284940dc1962b4a5f82ca2c96f47a35","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-15 02:00:54.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 28a341acfd77fe34dc8948ddb663439f67dea7d6","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c","revisions":{"a47d63a18fba986b8364da1027714083fe9e583b":{"kind":"REWORK","_number":1,"created":"2019-05-14 07:47:36.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/77/658977/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/77/658977/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/77/658977/1"}}},"commit":{"parents":[{"commit":"57026255615679122e6f305dfa3520c012f57ca7","subject":"Merge \"Skip notification sample tests when running nova functional\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57026255615679122e6f305dfa3520c012f57ca7"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 11:34:05.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 11:51:12.000000000","tz":0},"subject":"Skip _exclude_nested_providers() if not nested","message":"Skip _exclude_nested_providers() if not nested\n\nIn rocky cycle, \u0027GET /allocation_candidates\u0027 started to be aware of\nnested providers from microversion 1.29, namely, it can have multiple\nallocations from multiple resource providers in the same tree in the\nallocation requests.\n\nTo keep the behavior of microversion before 1.29, it added a filters\nto exculde nested providers being unaware of the nested architecture.\nHowever that function \"_exclude_nested_providers()\" is very heavy\nand is executed even if there is no nested provider in the environment\nwhen microversion \u003c 1.29.\n\nThis patch changes it to skip it if there is no nested provider.\n\nSince _exclude_nested_providers() should be done before limitting\nthe candidates, this patch also moves it from hander file to the\ndeeper layer.\n\nChange-Id: I4efdc65395e69a6d33fba927018d003cce26fa68\nStory: 2005669\nTask: 30980\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a47d63a18fba986b8364da1027714083fe9e583b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a47d63a18fba986b8364da1027714083fe9e583b"}]},"branch":"refs/heads/master"},"89a8039561e45bdcd169c90410a1dde471a492b8":{"kind":"REWORK","_number":2,"created":"2019-05-14 09:33:46.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/77/658977/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/77/658977/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/77/658977/2"}}},"commit":{"parents":[{"commit":"57026255615679122e6f305dfa3520c012f57ca7","subject":"Merge \"Skip notification sample tests when running nova functional\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57026255615679122e6f305dfa3520c012f57ca7"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 11:34:05.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-14 09:30:52.000000000","tz":0},"subject":"Skip _exclude_nested_providers() if not nested","message":"Skip _exclude_nested_providers() if not nested\n\nIn rocky cycle, \u0027GET /allocation_candidates\u0027 started to be aware of\nnested providers from microversion 1.29, namely, it can have multiple\nallocations from multiple resource providers in the same tree in the\nallocation requests.\n\nTo keep the behavior of microversion before 1.29, it added a filters\nto exculde nested providers being unaware of the nested architecture.\nHowever that function \"_exclude_nested_providers()\" is very heavy\nand is executed even if there is no nested provider in the environment\nwhen microversion \u003c 1.29.\n\nThis patch changes it to skip it if there is no nested provider.\n\nSince _exclude_nested_providers() should be done before limitting\nthe candidates, this patch also moves it from hander file to the\ndeeper layer.\n\nChange-Id: I4efdc65395e69a6d33fba927018d003cce26fa68\nStory: 2005669\nTask: 30980\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/89a8039561e45bdcd169c90410a1dde471a492b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/89a8039561e45bdcd169c90410a1dde471a492b8"}]},"branch":"refs/heads/master"},"727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c":{"kind":"REWORK","_number":3,"created":"2019-05-14 12:09:32.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/77/658977/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/77/658977/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/658977/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/77/658977/3"}}},"commit":{"parents":[{"commit":"57026255615679122e6f305dfa3520c012f57ca7","subject":"Merge \"Skip notification sample tests when running nova functional\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57026255615679122e6f305dfa3520c012f57ca7"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 11:34:05.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 12:38:28.000000000","tz":0},"subject":"Skip _exclude_nested_providers() if not nested","message":"Skip _exclude_nested_providers() if not nested\n\nIn rocky cycle, \u0027GET /allocation_candidates\u0027 started to be aware of\nnested providers from microversion 1.29, namely, it can have multiple\nallocations from multiple resource providers in the same tree in the\nallocation requests.\n\nTo keep the behavior of microversion before 1.29, it added a filters\nto exculde nested providers being unaware of the nested architecture.\nHowever that function \"_exclude_nested_providers()\" is very heavy\nand is executed even if there is no nested provider in the environment\nwhen microversion \u003c 1.29.\n\nThis patch changes it to skip it if there is no nested provider.\n\nSince _exclude_nested_providers() should be done before limitting\nthe candidates, this patch also moves it from hander file to the\ndeeper layer.\n\nChange-Id: I4efdc65395e69a6d33fba927018d003cce26fa68\nStory: 2005669\nTask: 30980\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}