)]}'
{"id":"openstack%2Fplacement~659200","triplet_id":"openstack%2Fplacement~stable%2Fstein~I4efdc65395e69a6d33fba927018d003cce26fa68","project":"openstack/placement","branch":"stable/stein","topic":"bug/1828937-stable/stein","hashtags":[],"change_id":"I4efdc65395e69a6d33fba927018d003cce26fa68","subject":"Skip _exclude_nested_providers() if not nested","status":"MERGED","created":"2019-05-15 02:00:54.000000000","updated":"2019-05-15 15:36:01.000000000","submitted":"2019-05-15 15:36:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659200-1557934561508-cf8f5779","meta_rev_id":"9a6d42226e3f7d576cc2bccae01011b3604fca6e","_number":659200,"virtual_id_number":659200,"owner":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-05-15 15:36:01.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":2,"date":"2019-05-15 13:26:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-05-15 13:22:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2019-05-15 06:25:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-05-15 08:36:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":1,"date":"2019-05-15 13:26:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-15 13:07:25.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 06:25:55.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-05-15 08:36:17.000000000","updated_by":{"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"},"reviewer":{"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"},"state":"REVIEWER"},{"updated":"2019-05-15 13:07:25.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-15 13:22:12.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-05-15 13:26:15.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-05-15 15:36:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a8cd6cd5a3cc8e9c41a1be329203982c6cb76c79","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-15 02:00:54.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"a3500626a11bf8527be201219360ea8b3955cb67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 03:30:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/00/659200/1/check/grenade-py3/d1fcf42/ : SUCCESS in 50m 43s\n- tempest-full-py3 http://logs.openstack.org/00/659200/1/check/tempest-full-py3/1c6614d/ : SUCCESS in 1h 28m 12s\n- openstack-tox-docs http://logs.openstack.org/00/659200/1/check/openstack-tox-docs/a905fc6/html/ : SUCCESS in 4m 03s\n- openstack-tox-cover http://logs.openstack.org/00/659200/1/check/openstack-tox-cover/2663889/cover/ : SUCCESS in 4m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/00/659200/1/check/openstack-tox-lower-constraints/6d2c71e/ : SUCCESS in 5m 23s\n- openstack-tox-pep8 http://logs.openstack.org/00/659200/1/check/openstack-tox-pep8/f15c4b7/ : SUCCESS in 3m 36s\n- openstack-tox-py27 http://logs.openstack.org/00/659200/1/check/openstack-tox-py27/77f066e/ : SUCCESS in 3m 45s\n- openstack-tox-py35 http://logs.openstack.org/00/659200/1/check/openstack-tox-py35/456b2e2/ : SUCCESS in 4m 43s\n- openstack-tox-py36 http://logs.openstack.org/00/659200/1/check/openstack-tox-py36/df00560/ : SUCCESS in 3m 37s\n- openstack-tox-py37 http://logs.openstack.org/00/659200/1/check/openstack-tox-py37/9b151bf/ : SUCCESS in 6m 56s\n- openstack-tox-functional http://logs.openstack.org/00/659200/1/check/openstack-tox-functional/aa58195/ : SUCCESS in 3m 48s\n- openstack-tox-functional-py35 http://logs.openstack.org/00/659200/1/check/openstack-tox-functional-py35/cd0dcaa/ : SUCCESS in 4m 11s\n- openstack-tox-functional-py36 http://logs.openstack.org/00/659200/1/check/openstack-tox-functional-py36/09a2d10/ : SUCCESS in 3m 59s\n- placement-perfload http://logs.openstack.org/00/659200/1/check/placement-perfload/5fd7b95/ : SUCCESS in 3m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8d89d994f6b00c34bc620a24fe59fe2a5c96d128","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-05-15 06:25:55.000000000","message":"Patch Set 1: Code-Review+1\n\nClean backport. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"1c6a8b544a6806724d0a5a50e772fa80fa1eb757","author":{"_account_id":30403,"name":"hu","email":"huxy@awcloud.com"},"date":"2019-05-15 08:36:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5abe06cb84202cd204a18ba1fde600259e904141","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-15 13:07:11.000000000","message":"Patch Set 1:\n\nI think we need some input from the stable-maint folk to decide if this is a legit backport (getting it all the way back to nova stable/rocky is the goal [1]). Do we make a habit of backporting performance fixes?\n\nGonna prod some of those people.\n\n[1] https://review.opendev.org/#/c/659207/","accounts_in_message":[],"_revision_number":1},{"id":"adbad0ef2f45a34ff5b6924617a807c1ba683b1e","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-05-15 13:22:12.000000000","message":"Patch Set 1: Code-Review+2\n\nThis appears to be done in a backwards compatible way, and could be considered a bug IMO since it can have a performance impact to scaling. I think this is acceptable to backport.\n\nDocstrings aren\u0027t following pep257, but doesn\u0027t appear most are. Not relevant to change in a cherry-pick anyway.\n\nMerged to master (train), so I think this is OK.","accounts_in_message":[],"_revision_number":1},{"id":"3e2f2edaeb5b3aeb6484e9c7f480d642dc3849d4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-15 13:26:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n\u003e This appears to be done in a backwards compatible way, and could be\n \u003e considered a bug IMO since it can have a performance impact to\n \u003e scaling. I think this is acceptable to backport.\n\nCool, thanks for the quick response.\n\n \u003e Docstrings aren\u0027t following pep257, but doesn\u0027t appear most are.\n \u003e Not relevant to change in a cherry-pick anyway.\n\nplacement has inherited not following pep257 for docstrings from nova","accounts_in_message":[],"_revision_number":1},{"id":"84e71b0a41db36e96d103b3301a70884b890a363","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 13:26:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7082710845c5b06bfa93f01124acc402f4fa9242","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 15:36:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"70dc38e6e6bd26b6f4e7bc2287254a9a0e53a95d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 15:36:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/00/659200/1/gate/grenade-py3/a1c0c00/ : SUCCESS in 1h 08m 55s\n- tempest-full-py3 http://logs.openstack.org/00/659200/1/gate/tempest-full-py3/2a8368b/ : SUCCESS in 1h 26m 51s\n- openstack-tox-docs http://logs.openstack.org/00/659200/1/gate/openstack-tox-docs/eb6480d/html/ : SUCCESS in 4m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/00/659200/1/gate/openstack-tox-lower-constraints/939e7bc/ : SUCCESS in 4m 35s\n- openstack-tox-pep8 http://logs.openstack.org/00/659200/1/gate/openstack-tox-pep8/225fbc4/ : SUCCESS in 6m 40s\n- openstack-tox-py27 http://logs.openstack.org/00/659200/1/gate/openstack-tox-py27/ae639b5/ : SUCCESS in 3m 42s\n- openstack-tox-py35 http://logs.openstack.org/00/659200/1/gate/openstack-tox-py35/f0fe0d1/ : SUCCESS in 4m 03s\n- openstack-tox-py36 http://logs.openstack.org/00/659200/1/gate/openstack-tox-py36/c7ecc0d/ : SUCCESS in 5m 39s\n- openstack-tox-py37 http://logs.openstack.org/00/659200/1/gate/openstack-tox-py37/f5359f7/ : SUCCESS in 4m 10s\n- openstack-tox-functional http://logs.openstack.org/00/659200/1/gate/openstack-tox-functional/7077da8/ : SUCCESS in 6m 05s\n- openstack-tox-functional-py35 http://logs.openstack.org/00/659200/1/gate/openstack-tox-functional-py35/71c2cb1/ : SUCCESS in 4m 29s\n- openstack-tox-functional-py36 http://logs.openstack.org/00/659200/1/gate/openstack-tox-functional-py36/38a3bc2/ : SUCCESS in 7m 15s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"28a341acfd77fe34dc8948ddb663439f67dea7d6","revisions":{"28a341acfd77fe34dc8948ddb663439f67dea7d6":{"kind":"REWORK","_number":1,"created":"2019-05-15 02:00:54.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/00/659200/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/00/659200/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/00/659200/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/00/659200/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/00/659200/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/00/659200/1"}}},"commit":{"parents":[{"commit":"58d557972c544333763fc94b39ece630fde32107","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/58d557972c544333763fc94b39ece630fde32107"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-13 11:34:05.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-15 02:00:54.000000000","tz":0},"subject":"Skip _exclude_nested_providers() if not nested","message":"Skip _exclude_nested_providers() if not nested\n\nIn rocky cycle, \u0027GET /allocation_candidates\u0027 started to be aware of\nnested providers from microversion 1.29, namely, it can have multiple\nallocations from multiple resource providers in the same tree in the\nallocation requests.\n\nTo keep the behavior of microversion before 1.29, it added a filters\nto exculde nested providers being unaware of the nested architecture.\nHowever that function \"_exclude_nested_providers()\" is very heavy\nand is executed even if there is no nested provider in the environment\nwhen microversion \u003c 1.29.\n\nThis patch changes it to skip it if there is no nested provider.\n\nSince _exclude_nested_providers() should be done before limitting\nthe candidates, this patch also moves it from hander file to the\ndeeper layer.\n\nChange-Id: I4efdc65395e69a6d33fba927018d003cce26fa68\nStory: 2005669\nTask: 30980\n(cherry picked from commit 727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/28a341acfd77fe34dc8948ddb663439f67dea7d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/28a341acfd77fe34dc8948ddb663439f67dea7d6"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}