)]}'
{"id":"openstack%2Fplacement~659522","triplet_id":"openstack%2Fplacement~master~I98ce4cade9acd64285c5a65bd439e37cb6a308f3","project":"openstack/placement","branch":"master","topic":"story/2005647","hashtags":[],"change_id":"I98ce4cade9acd64285c5a65bd439e37cb6a308f3","subject":"Enhance debug logging in allocation candidate handling","status":"MERGED","created":"2019-05-16 10:24:55.000000000","updated":"2019-05-20 09:35:40.000000000","submitted":"2019-05-20 09:35:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659522-1558344940023-795c03e7","meta_rev_id":"53eff50a3506369c560abb91beefc84f4b820279","_number":659522,"virtual_id_number":659522,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"date":"2019-05-16 19:02:43.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-05-20 09:35:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-05-17 02:47:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-05-16 18:31:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-05-20 07:47:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-05-20 07:43:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":1,"date":"2019-05-20 07:43:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-16 18:31:49.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-17 02:47:15.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-05-20 07:43:38.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2019-05-20 07:47:01.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-05-20 09:35:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cdee881e8d7f2655be8b67c4298fc94e8a0041c7","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 10:24:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"028c524be6ab57bb13f98b32afe5154dfee533e5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 10:25:35.000000000","message":"Patch Set 1: Workflow-1\n\nWaiting on evidence from the gate\u0027s logs.","accounts_in_message":[],"_revision_number":1},{"id":"e9341b6a1ba1b3e56011d479da204ab3eed317da","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 10:45:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1f4d1006808fbecebe6706f9430e68247e862953","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 10:57:32.000000000","message":"Patch Set 2:\n\nEnd of http://logs.openstack.org/22/659522/2/check/placement-perfload/85a7ff3/logs/placement-api.log has:\n\n2019-05-16 10:49:55.794 2276 DEBUG placement.objects.allocation_candidate [req-74cec67a-aaaa-455a-91e6-be3e8b189330 admin admin - - -] Merging candidates yields 1010 allocation requests and 1010 provider summaries _merge_candidates ./placement/objects/allocation_candidate.py:944\n\nBecause neither limit nor nested are present the other two log additions are not expected.","accounts_in_message":[],"_revision_number":2},{"id":"b0c95712fe51551c07f9160ea97eb06db993f533","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 12:11:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/22/659522/2/check/grenade-py3/0dca862/ : SUCCESS in 54m 19s\n- tempest-full-py3 http://logs.openstack.org/22/659522/2/check/tempest-full-py3/8f4bfef/ : SUCCESS in 1h 20m 51s\n- openstack-tox-docs http://logs.openstack.org/22/659522/2/check/openstack-tox-docs/287be63/html/ : SUCCESS in 3m 45s\n- openstack-tox-cover http://logs.openstack.org/22/659522/2/check/openstack-tox-cover/378014f/cover/ : SUCCESS in 4m 43s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/659522/2/check/openstack-tox-lower-constraints/5aeedcf/ : SUCCESS in 4m 35s\n- openstack-tox-pep8 http://logs.openstack.org/22/659522/2/check/openstack-tox-pep8/1301c47/ : SUCCESS in 3m 42s\n- openstack-tox-py27 http://logs.openstack.org/22/659522/2/check/openstack-tox-py27/3ea6375/ : SUCCESS in 3m 58s\n- openstack-tox-py36 http://logs.openstack.org/22/659522/2/check/openstack-tox-py36/3631446/ : SUCCESS in 3m 58s\n- openstack-tox-py37 http://logs.openstack.org/22/659522/2/check/openstack-tox-py37/325b592/ : SUCCESS in 5m 14s\n- openstack-tox-functional http://logs.openstack.org/22/659522/2/check/openstack-tox-functional/d34fe7f/ : SUCCESS in 4m 40s\n- openstack-tox-functional-py36 http://logs.openstack.org/22/659522/2/check/openstack-tox-functional-py36/cc9e7b9/ : SUCCESS in 5m 28s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/22/659522/2/check/placement-nova-tox-functional-py36/0e0544e/ : SUCCESS in 11m 18s\n- placement-perfload http://logs.openstack.org/22/659522/2/check/placement-perfload/85a7ff3/ : SUCCESS in 3m 36s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5069287265f8a2bbbd29394719e2130478fc1671","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 14:45:47.000000000","message":"Patch Set 2:\n\nand http://logs.openstack.org/22/659522/2/check/tempest-full-py3/8f4bfef/controller/logs/screen-placement-api.txt.gz#_May_16_11_16_29_453992","accounts_in_message":[],"_revision_number":2},{"id":"38fbbf1581ae653a4564d6adc68869420c664a52","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-16 18:31:49.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nYup, good additions.","accounts_in_message":[],"_revision_number":2},{"id":"f57e1facb56776e02cb21391c770f68a4d35b69a","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-16 19:02:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d3d38f1257a5efd01a1bffcd2cbd87622ec4419b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-16 19:51:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0b881dc0300d7700e816ef0639adba531a54f862","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-05-17 02:47:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"adbf537db2a13cfb927fd1096e6da440701fb84a","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-05-20 07:43:38.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6ee8e3cb95b9a5d0659144bc27c16309d5ca2cc3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 07:43:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"10e346b6f9ac69b5a30b27447f2d1167ccdfacb4","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-20 07:47:01.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1d6d95ee17bc2ca16899c45986d1b3405cc900e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 09:35:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/22/659522/2/gate/grenade-py3/fce7b4a/ : SUCCESS in 56m 45s\n- tempest-full-py3 http://logs.openstack.org/22/659522/2/gate/tempest-full-py3/a90c284/ : SUCCESS in 1h 46m 56s\n- openstack-tox-docs http://logs.openstack.org/22/659522/2/gate/openstack-tox-docs/4baa458/html/ : SUCCESS in 5m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/659522/2/gate/openstack-tox-lower-constraints/ec19372/ : SUCCESS in 4m 25s\n- openstack-tox-pep8 http://logs.openstack.org/22/659522/2/gate/openstack-tox-pep8/5c98ec3/ : SUCCESS in 3m 51s\n- openstack-tox-py27 http://logs.openstack.org/22/659522/2/gate/openstack-tox-py27/aff0a4f/ : SUCCESS in 6m 28s\n- openstack-tox-py36 http://logs.openstack.org/22/659522/2/gate/openstack-tox-py36/00372d1/ : SUCCESS in 5m 14s\n- openstack-tox-py37 http://logs.openstack.org/22/659522/2/gate/openstack-tox-py37/ffa0dfb/ : SUCCESS in 4m 33s\n- openstack-tox-functional http://logs.openstack.org/22/659522/2/gate/openstack-tox-functional/a61f957/ : SUCCESS in 4m 12s\n- openstack-tox-functional-py36 http://logs.openstack.org/22/659522/2/gate/openstack-tox-functional-py36/0011d2e/ : SUCCESS in 5m 59s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/22/659522/2/gate/placement-nova-tox-functional-py36/e4c207a/ : SUCCESS in 12m 54s","accounts_in_message":[],"_revision_number":2},{"id":"347d84a05ddadb5b9e7acc64385b64b018a351cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 09:35:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"73b29cd6e474882380b19c0fc0217cc47434de59","revisions":{"2002987113051547fff1cde421bfd4b4349ae080":{"kind":"REWORK","_number":1,"created":"2019-05-16 10:24:55.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/22/659522/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/22/659522/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/22/659522/1"}}},"commit":{"parents":[{"commit":"1281806c99ceb80fed78237b39aa34b9097a39e6","subject":"Merge \"Skip _exclude_nested_providers() if not nested\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/1281806c99ceb80fed78237b39aa34b9097a39e6"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-16 10:21:32.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-16 10:21:32.000000000","tz":60},"subject":"Enhance debug logging in allocation candidate handling","message":"Enhance debug logging in allocation candidate handling\n\nThere is reasonably good debug logging when filtering results to\ncreate a set of allocation candidates, but the latter half of the\nprocessing which merges candidates, removes nested providers and\nlimits results is not well logged.\n\nThis change adds some debug logs in that handling to provide more\ninformation. While the logs do report the sizes of the entities\ninvolved another important factor of the logging is the timestamps\nthat indicate time spent between each message.\n\nChange-Id: I98ce4cade9acd64285c5a65bd439e37cb6a308f3\nStory: 2005647\nTask: 30927\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/2002987113051547fff1cde421bfd4b4349ae080"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/2002987113051547fff1cde421bfd4b4349ae080"}]},"branch":"refs/heads/master"},"73b29cd6e474882380b19c0fc0217cc47434de59":{"kind":"REWORK","_number":2,"created":"2019-05-16 10:45:55.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/22/659522/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/22/659522/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/659522/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/22/659522/2"}}},"commit":{"parents":[{"commit":"1281806c99ceb80fed78237b39aa34b9097a39e6","subject":"Merge \"Skip _exclude_nested_providers() if not nested\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/1281806c99ceb80fed78237b39aa34b9097a39e6"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-16 10:21:32.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-16 10:45:37.000000000","tz":60},"subject":"Enhance debug logging in allocation candidate handling","message":"Enhance debug logging in allocation candidate handling\n\nThere is reasonably good debug logging when filtering results to\ncreate a set of allocation candidates, but the latter half of the\nprocessing which merges candidates, removes nested providers and\nlimits results is not well logged.\n\nThis change adds some debug logs in that handling to provide more\ninformation. While the logs do report the sizes of the entities\ninvolved another important factor of the logging is the timestamps\nthat indicate time spent between each message.\n\nChange-Id: I98ce4cade9acd64285c5a65bd439e37cb6a308f3\nStory: 2005647\nTask: 30927\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/73b29cd6e474882380b19c0fc0217cc47434de59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/73b29cd6e474882380b19c0fc0217cc47434de59"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}